Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footprint with edge cut placed on back causes KiKit to flip edge cut vertically #572

Open
2 tasks done
bradanlane opened this issue Jul 25, 2023 · 8 comments
Open
2 tasks done

Comments

@bradanlane
Copy link

Prerequisites

  • I have read FAQ
  • I use KiKit at least version 1.3.0 (older version are not supported)

KiKit version

kikit, version 1.3.0+39.g07c707d

KiCAD version

7.0.5

Operating system

Windows 11

Description

If the PCB edge cut is part of a footprint and that footprint is placed on the back of the PCB, then KiKit flips the edge cut vertically. It should flip horizontally.

Steps to Reproduce

  • create a footprint which contains an irregular shaped footprint. (the irregularity to to make it easy to identify the orientation of the footprint and the edge cut)
  • create a PCB with this footprint
  • position the footprint on the back of the PCB (this will flip the irregular edge cut left/right)
  • generate a 1x1 panel

The edge cut on the panel will have been flipped top/bottom.

Source PCB:
original pcb with footprint on back

KiKit Result:
kikit result with edgecut flipped top/bottom

@bradanlane bradanlane changed the title Footprint with edgecut placed on back causes KiKit to flip edcut vertically Footprint with edge cut placed on back causes KiKit to flip edge cut vertically Jul 26, 2023
@yaqwsx
Copy link
Owner

yaqwsx commented Aug 17, 2023

I tried to reproduce your issue - I created the following project:
example.zip
Screenshot from 2023-08-17 17-44-09

After running kikit panelize ~/projects/kikit/repro/mfootprint/mfootprint.kicad_pcb panel.kicad_pcb I get:
Screenshot from 2023-08-17 17-44-41

Which looks just right. Tested on kikit, version 1.3.0+42.g63301c2. Could you try the upstream version? If it doesn't help, could you share the project (problematic footprint and outline should be sufficient).

@bradanlane
Copy link
Author

I will test with the upstream. It's odd but I thought I added a zip of a simple project to reproduce the issue. If it still persists I will insure test file appears here.

@bradanlane
Copy link
Author

I tested with the current upstream but used our footprint and am still able to reproduce. attached file.
mfootprint_bradan.zip

@yaqwsx
Copy link
Owner

yaqwsx commented Aug 18, 2023

Ah, the difference is in whether you use lines or polygon. With polygons, there is something strange happening inside KiCAD that causes the problem. I wasn't able to trace it yet. As a work-around before we find fix I suggest converting the polyline outline to lines.

@yaqwsx
Copy link
Owner

yaqwsx commented Mar 10, 2024

I just retested this issue with KiCAD 8 and it seems to me that the problem was fixed. Could you confirm it (after a long time I am unsure if I executed the steps for reproduction correctly).

@bradanlane
Copy link
Author

I have not been able to upgrade KiCAD since 7.0.7 because later 7.- released broke multiple things related to edge cuts.

I cannot move to 8.x until my current designs are done and shipped because I can't not afford the regression cycles.

If you want to close this, then go ahead. If this issue reappears after I move to 8.x I can either reopen it or create a new issue.

@yaqwsx
Copy link
Owner

yaqwsx commented Mar 10, 2024

Could you elaborate more on " 7.- released broke multiple things related to edge cuts."? Why I am asking: I observed a bug in KiCAD's handling of edges in footprints. If 7.0.8 broke something, it might be related to fixing it. Knowing the details could help us trace the root cause.

@bradanlane
Copy link
Author

bradanlane commented Mar 10, 2024

I encountered 2 issues (one started with 7.0.8 and another appeared with 7.0.9).

Edge cut was no longer considered closed but no error appeared. Filled zones stop filling (even though the board was unchanged from 7.0.7).

Irregular openings within edge cuts started to generate hundreds of DRC errors related to net segments and bias being outside edge cuts.

In both cases, the edge cuts and related openings were all defined within a footprint (not directly in the pcbnew).

Changing from line segments to polygon (or vise versa) caused other errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants