Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPEATED_FIELD_NAMES_PLURALIZED should account for uncountable names #447

Open
CoRfr opened this issue Jan 20, 2025 · 3 comments
Open

REPEATED_FIELD_NAMES_PLURALIZED should account for uncountable names #447

CoRfr opened this issue Jan 20, 2025 · 3 comments

Comments

@CoRfr
Copy link

CoRfr commented Jan 20, 2025

While adding a field

repeated AdditionalInfo additional_info = 6;

protolint raised the following issue:

Repeated field name "additional_info" must be pluralized name "additional_infos"

My understanding is that info is uncountable, and therefore that the pluralized version of info is also info.

@yoheimuta
Copy link
Owner

That's right. Thank you for letting me know.

@yoheimuta
Copy link
Owner

📝 You can implement a workaround to adjust uncountable names by using a config file, such as

repeated_field_names_pluralized:
uncountable_rules:
- paper
.

@jduan-highnote
Copy link

Our CI job picked up the latest release (0.53.0) and now it's failing due to the following:

[protos/proto-onboarding/src/main/java/proto/onboarding/onboarding.proto:413:3] Repeated field name "preliminary_business_infos" must be pluralized name "preliminary_business_info"

How do I allow "preliminary_business_infos" in .protolintrc? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants