NetBSD Problem Report #54351
From tsutsui@ceres.dti.ne.jp Sat Jul 6 12:13:47 2019
Return-Path: <tsutsui@ceres.dti.ne.jp>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
by mollari.NetBSD.org (Postfix) with ESMTPS id EE31E7A0D9
for <gnats-bugs@gnats.NetBSD.org>; Sat, 6 Jul 2019 12:13:46 +0000 (UTC)
Message-Id: <201907061213.x66CDhIr021588@ceres.dti.ne.jp>
Date: Sat, 6 Jul 2019 21:13:43 +0900 (JST)
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
Reply-To: tsutsui@ceres.dti.ne.jp
To: gnats-bugs@NetBSD.org
Cc: tsutsui@ceres.dti.ne.jp
Subject: 10-wpa_supplicant for dhcpcd(8) shouldn't be marked obsolete
X-Send-Pr-Version: 3.95
>Number: 54351
>Category: install
>Synopsis: 10-wpa_supplicant for dhcpcd(8) shouldn't be marked obsolete
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: install-manager
>State: closed
>Class: change-request
>Submitter-Id: net
>Arrival-Date: Sat Jul 06 12:15:00 +0000 2019
>Closed-Date: Sat Nov 02 00:20:30 +0000 2019
>Last-Modified: Sat Nov 02 00:20:30 +0000 2019
>Originator: Izumi Tsutsui
>Release: NetBSD 8.1
>Organization:
>Environment:
System: NetBSD/i386 8.1 (GENERIC)
Architecture: i386 (affects all ports)
Machine: i386
>Description:
The dhcpcd(8) man page suggest to install 10-wpa_supplicant files
to use WiFi devices with dhcpcd(8):
---
More scripts are supplied in /usr/share/examples/dhcpcd/hooks and need to
be copied to /libexec/dhcpcd-hooks if you intend to use them. For
example, you could install 10-wpa_supplicant so that dhcpcd can ensure
that wpa_supplicant(8) is always running on a hot-plugged wireless
interface.
---
and it works fine.
However src/distrib/sets/lists/base/mi has the following entry:
---
./libexec/dhcpcd-hooks/10-wpa_supplicant base-obsolete obsolete
---
So the manually installed 10-wpa_supplicant script is removed
as obsolete on every upgrade installation by sysinst(8)
(or postinstall(8) fix command).
>How-To-Repeat:
- copy /usr/share/examples/dhcpcd/hooks/10-wpa_supplicant to
/libexec/dhcpcd-hooks
- upgrade the system to 8.1 using sysinst
>Fix:
Remove the entry of ./libexec/dhcpcd-hooks/10-wpa_supplicant from
src/distrib/sets/lists/base/mi?
---
>Release-Note:
>Audit-Trail:
From: Leonardo Taccari <leot@NetBSD.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: install/54351: 10-wpa_supplicant for dhcpcd(8) shouldn't be marked obsolete
Date: Sat, 06 Jul 2019 14:36:58 +0200
Hello Izumi,
Izumi Tsutsui writes:
> [...]
> >Fix:
> Remove the entry of ./libexec/dhcpcd-hooks/10-wpa_supplicant from
> src/distrib/sets/lists/base/mi?
> [...]
Not a fix - and probably obvious workaround! - but it can be copied to
/libexec/dhcpcd-hooks/15-wpa_supplicant or similar to avoid that.
That's what I usually do, I think it was marked as obsolete because
there wasn't an agreement on starting wpa_supplicant by default when
invoking dhcpcd. In any case - if it's should be kept as obsolete entry
due that - probably it's less surprising to rename the example to
11-wpa_supplicant or similar so just directly copying it will work and
avoid further surprises.
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/54351 CVS commit: src/distrib/sets/lists/base
Date: Sat, 6 Jul 2019 15:45:25 -0400
Module Name: src
Committed By: christos
Date: Sat Jul 6 19:45:25 UTC 2019
Modified Files:
src/distrib/sets/lists/base: mi
Log Message:
PR/54351: Izumi Tsutsui: Remove obsolete entries that are in
/usr/share/examples/dhcpcd/hooks/, so that when someone uses
the examples, they don't get removed by postinstall. A more
advanced way to fix this is to put a date in the the obsolete
entry and only remove files when they pre-date that date. But
this is too much complexity for little benefit for now.
To generate a diff of this commit:
cvs rdiff -u -r1.1205 -r1.1206 src/distrib/sets/lists/base/mi
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Roy Marples <roy@marples.name>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: install/54351: 10-wpa_supplicant for dhcpcd(8) shouldn't be
marked obsolete
Date: Wed, 24 Jul 2019 22:27:19 +0100
10-wpa_supplicant IS obsolete.
Using a stock install, just add wpa_supplicant=YES to rc.conf and the
defaults will enable interface matching (ie launch with the -M flag)
which gives you exactly the same functionality that this dhcpcd hook
script did.
Roy
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
To: gnats-bugs@netbsd.org
Cc: roy@marples.name, tsutsui@ceres.dti.ne.jp
Subject: Re: install/54351: 10-wpa_supplicant for dhcpcd(8) shouldn't bemarked
obsolete
Date: Fri, 26 Jul 2019 02:08:16 +0900
> 10-wpa_supplicant IS obsolete.
Hmm, from which dhcpcd version?
> Using a stock install, just add wpa_supplicant=YES to rc.conf and the
> defaults will enable interface matching (ie launch with the -M flag)
> which gives you exactly the same functionality that this dhcpcd hook
> script did.
Then the following stuff should also be updated accordingly?
src/external/bsd/dhcpcd/dist/src/dhcpcd.8.in
---
More scripts are supplied in @DATADIR@/dhcpcd/hooks and need to be copied
to @HOOKDIR@ if you intend to use them. For example, you could install
10-wpa_supplicant so that dhcpcd can ensure that wpa_supplicant(8) is
always running on a hot-plugged wireless interface.
---
src/external/bsd/dhcpcd/dist/hooks/dist/hooks/10-wpa_supplicant
src/external/bsd/dhcpcd/examples/hooks/Makefile
---
.if ${MKSHARE} != "no"
FILES= 10-wpa_supplicant 15-timezone 29-lookup-hostname
---
src/distrib/sets/lists/misc/mi
---
./usr/share/examples/dhcpcd/hooks/10-wpa_supplicant misc-dhcpcd-examples share
---
From: Roy Marples <roy@marples.name>
To: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>, gnats-bugs@netbsd.org
Cc:
Subject: Re: install/54351: 10-wpa_supplicant for dhcpcd(8) shouldn't bemarked
obsolete
Date: Thu, 25 Jul 2019 19:05:05 +0100
On 25/07/2019 18:08, Izumi Tsutsui wrote:
>> 10-wpa_supplicant IS obsolete.
>
> Hmm, from which dhcpcd version?
Requires wpa_supplicant-2.6 or newer built with CONFIG_MATCH_IFACE OR
NetBSD-8 which has that combo.
>
>> Using a stock install, just add wpa_supplicant=YES to rc.conf and the
>> defaults will enable interface matching (ie launch with the -M flag)
>> which gives you exactly the same functionality that this dhcpcd hook
>> script did.
>
> Then the following stuff should also be updated accordingly?
>
> src/external/bsd/dhcpcd/dist/src/dhcpcd.8.in
> ---
> More scripts are supplied in @DATADIR@/dhcpcd/hooks and need to be copied
> to @HOOKDIR@ if you intend to use them. For example, you could install
> 10-wpa_supplicant so that dhcpcd can ensure that wpa_supplicant(8) is
> always running on a hot-plugged wireless interface.
> ---
Will fix that in the next import, along with an updated comment at the
top of 10-wpa_supplicant.
> src/external/bsd/dhcpcd/dist/hooks/dist/hooks/10-wpa_supplicant
> src/external/bsd/dhcpcd/examples/hooks/Makefile
> ---
> .if ${MKSHARE} != "no"
> FILES= 10-wpa_supplicant 15-timezone 29-lookup-hostname
> ---
>
> src/distrib/sets/lists/misc/mi
> ---
> ./usr/share/examples/dhcpcd/hooks/10-wpa_supplicant misc-dhcpcd-examples share
> ---
I don't see this being a problem? It's still bundled as an example with
a stock dhcpcd install as there is no clue what wpa_suppliant if any is
installed or how it was built.
I know this isn't an issue for NetBSD, but is the consensus that the
example file be removed? and 50-ypbind if MKYP=no?
Roy
From: "Roy Marples" <roy@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/54351 CVS commit: src
Date: Fri, 26 Jul 2019 10:34:26 +0000
Module Name: src
Committed By: roy
Date: Fri Jul 26 10:34:26 UTC 2019
Modified Files:
src/distrib/sets/lists/misc: mi
src/external/bsd/dhcpcd/examples/hooks: Makefile
Log Message:
Stop installing 10-wpa_supplicant.
Only install 50-ypbind when MKYP=yes.
Partially addresses PR install/54351.
To generate a diff of this commit:
cvs rdiff -u -r1.212 -r1.213 src/distrib/sets/lists/misc/mi
cvs rdiff -u -r1.1 -r1.2 src/external/bsd/dhcpcd/examples/hooks/Makefile
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "Roy Marples" <roy@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/54351 CVS commit: src/external/bsd/dhcpcd/dist/src
Date: Fri, 26 Jul 2019 10:39:29 +0000
Module Name: src
Committed By: roy
Date: Fri Jul 26 10:39:29 UTC 2019
Modified Files:
src/external/bsd/dhcpcd/dist/src: dhcpcd.8.in
Log Message:
Replace hook example 10-wpa_supplicant with 29-lookup-hostname.
Fixes PR install/54351.
To generate a diff of this commit:
cvs rdiff -u -r1.1.1.13 -r1.2 src/external/bsd/dhcpcd/dist/src/dhcpcd.8.in
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Leonardo Taccari <leot@NetBSD.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: install/54351: 10-wpa_supplicant for dhcpcd(8) shouldn't bemarked obsolete
Date: Fri, 26 Jul 2019 13:40:11 +0200
Hello Roy and Izumi,
Roy Marples writes:
> [...]
> > src/external/bsd/dhcpcd/dist/hooks/dist/hooks/10-wpa_supplicant
> > src/external/bsd/dhcpcd/examples/hooks/Makefile
> > ---
> > .if ${MKSHARE} != "no"
> > FILES= 10-wpa_supplicant 15-timezone 29-lookup-hostname
> > ---
> >
> > src/distrib/sets/lists/misc/mi
> > ---
> > ./usr/share/examples/dhcpcd/hooks/10-wpa_supplicant misc-dhcpcd-examples share
> > ---
>
> I don't see this being a problem? It's still bundled as an example with
> a stock dhcpcd install as there is no clue what wpa_suppliant if any is
> installed or how it was built.
> [...]
I personally find the 10-wpa_supplicant hook very handy.
I always manually invoke dhcpcd via `dhcpcd <interface>' and I like
that wpa_supplicant is started by dhcpcd in that way only when it is
needed (and without requiring a prior `service wpa_supplicant onestart'
or similar!).
State-Changed-From-To: open->closed
State-Changed-By: tsutsui@NetBSD.org
State-Changed-When: Sat, 02 Nov 2019 00:20:30 +0000
State-Changed-Why:
The set list was workarounded and an example in man page was also updated.
>Unformatted:
|
|
Home(Contact us) $NetBSD: query-full-pr,v 1.43 2018/01/16 07:36:43 maya Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2017 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.