Index: solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/Policy.java IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== --- solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/Policy.java (revision fc6f3a45f8bdd1518ed49b68fbdc62988b34644b) +++ solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/Policy.java (revision ) @@ -70,7 +70,10 @@ public static final String CLUSTER_POLICY = "cluster-policy"; public static final String CLUSTER_PREFERENCES = "cluster-preferences"; public static final Set GLOBAL_ONLY_TAGS = Collections.singleton("cores"); - public static final Preference DEFAULT_PREFERENCE = new Preference((Map) Utils.fromJSONString("{minimize : cores, precision:1}")); + public static final List DEFAULT_PREFERENCES = Collections.unmodifiableList( + Arrays.asList( + new Preference((Map) Utils.fromJSONString("{minimize : cores, precision:1}")), + new Preference((Map) Utils.fromJSONString("{maximize : freedisk}")))); final Map> policies; final List clusterPolicy; final List clusterPreferences; @@ -91,7 +94,7 @@ preference.next = initialClusterPreferences.get(i + 1); } if (initialClusterPreferences.isEmpty()) { - initialClusterPreferences.add(DEFAULT_PREFERENCE); + initialClusterPreferences.addAll(DEFAULT_PREFERENCES); } this.clusterPreferences = Collections.unmodifiableList(initialClusterPreferences); final SortedSet paramsOfInterest = new TreeSet<>(); @@ -122,8 +125,7 @@ private Policy(Map> policies, List clusterPolicy, List clusterPreferences) { this.policies = policies != null ? Collections.unmodifiableMap(policies) : Collections.emptyMap(); this.clusterPolicy = clusterPolicy != null ? Collections.unmodifiableList(clusterPolicy) : Collections.emptyList(); - this.clusterPreferences = clusterPreferences != null ? Collections.unmodifiableList(clusterPreferences) : - Collections.singletonList(DEFAULT_PREFERENCE); + this.clusterPreferences = clusterPreferences != null ? Collections.unmodifiableList(clusterPreferences) : DEFAULT_PREFERENCES; this.params = Collections.unmodifiableList(buildParams(this.clusterPreferences, this.clusterPolicy, this.policies)); perReplicaAttributes = readPerReplicaAttrs(); }