Date | Tue, 02 Oct 2012 00:52:29 +0200 | From | Willy Tarreau <> | Subject | [ 032/180] usbnet: dont clear urb->dev in tx_complete |
| |
2.6.32-longterm review patch. If anyone has any objections, please let me know.
------------------
From: tom.leiming@gmail.com <tom.leiming@gmail.com>
commit 5d5440a835710d09f0ef18da5000541ec98b537a upstream.
URB unlinking is always racing with its completion and tx_complete may be called before or during running usb_unlink_urb, so tx_complete must not clear urb->dev since it will be used in unlink path, otherwise invalid memory accesses or usb device leak may be caused inside usb_unlink_urb.
Cc: stable@kernel.org Cc: Alan Stern <stern@rowland.harvard.edu> Cc: Oliver Neukum <oliver@neukum.org> Signed-off-by: Ming Lei <tom.leiming@gmail.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Willy Tarreau <w@1wt.eu> --- drivers/net/usb/usbnet.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index a92a415..07f69ee 100644 --- a/drivers/net/usb/usbnet.c +++ b/drivers/net/usb/usbnet.c @@ -998,7 +998,6 @@ static void tx_complete (struct urb *urb) } } - urb->dev = NULL; entry->state = tx_done; defer_bh(dev, skb, &dev->txq); } -- 1.7.2.1.45.g54fbc
|