Code Review Office Hours
ActivePublic
Actions

Hosted by • mmodell on Jun 2 2016, 8:00 PM - 9:00 PM.

Description

What's this all about

This is an initiative of Wikimedia Developer-Advocacy and Release-Engineering-Team intended to promote quality and timely code reviews on Wikimedia projects. See T128371: Set up Code Review office hours for related discussion.

How does it work

If you have a patch that needs attention, please subscribe to this event and post a link to your patch in the comments, then show up on freenode IRC in the #wikimedia-codereview channel during the scheduled office hours. Developers with +2 should be on hand to review patches, provide feedback and merge any acceptable/deployable patches.

Nominated Patches

Suggested by	Link to patch	Task and/or Description of patch
@Danny_B	https://gerrit.wikimedia.org/r/#/c/8036/	T12817: Filtering Special:NewPages by page size by @Chughakshay16
	https://gerrit.wikimedia.org/r/#/c/113759/	T66460: Dynamically generate files with Scribunto by @JanusTroelsen
	https://gerrit.wikimedia.org/r/#/c/139760/	T47850: Code editor should work stand-alone, and not need the user to enable the 2010 wikitext editor (WikiEditor) by @TheDJ
	https://gerrit.wikimedia.org/r/#/c/244139/	T16086: Allow filtering user contributions by minor/not minor by @TTO
	https://gerrit.wikimedia.org/r/#/c/251280/	T107128: Scribunto string comparison works case insensitive while the standard Lua case sensitive by @Anomie
	https://gerrit.wikimedia.org/r/#/c/279956/	T18922: Have listing special pages show watched pages in bold by @ferveo
	https://gerrit.wikimedia.org/r/#/c/27526/	T30397: Allow collation to be specified per category by @liangent
	https://gerrit.wikimedia.org/r/#/c/87288/18	T37378: Support multiple collations at the same time by @liangent
	https://gerrit.wikimedia.org/r/#/c/290071/	T135949: Disruptive: Display title ... was ignored since it is not equivalent to the page's actual title by @Glaisher
	https://gerrit.wikimedia.org/r/#/c/290073/

@name

Tnnn

...

Other Patches "for-review"

To find other patches to review, try this maniphest query which will show you tasks with the Patch-For-Review tag.

Recurring Event
Next
Previous

Event Series: This event is an instance of E181: Code Review Office Hours, and repeats every week.

Details

Invitees

• Mholloway
• mmodell
Florian
Luke081515
• brooke
• ksmith
Nikerabbit
Jdlrobson
Bawolff
• Catrope
Tgr
phuedx
Danny_B
MGChecker
greg
TheDJ
• JGirault
• bmansurov
Smalyshev

Event Timeline

Proposals:

It looks like Chughakshay16 is long gone, so I'm happy to shepherd the first one through the office hour.

MGChecker added a project: IRC-Meetings.Jun 1 2016, 6:26 PM

• mmodell updated the event description. (Show Details)Jun 2 2016, 7:55 PM

• mmodell updated the event description. (Show Details)

Danny_B invited: ; uninvited: .Jun 2 2016, 8:13 PM

I'd like to propose a new rule. Any suggested patches must:

have been rebased in the last month (Or at least, still cleanly apply to master. If they need minor rebasing I don't think it matters, but if they've been bit rotting for 2 years, I don't think they should be listed here)
Not be gigantic. I don't think these types of office hours are the place for big sweeping complicated changes. e.g. If the patch touches more then 500 lines, it should be excluded. (Maybe line count isn't the best thing to judge something by)

@Bawolff: agreed, I think you're right on both points.

• Mholloway invited: ; uninvited: .Jun 3 2016, 1:23 AM

Paladox subscribed.Jun 3 2016, 1:35 AM

Code Review Office HoursActivePublicActions