Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Page MenuHomePhabricator
Create Task
Maniphest T130847

"Uncaught TypeError: Cannot read property 'equals' of null" when inserting Citoid-generated reference
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Open a page with the visual editor
  2. Open the citation tool
  3. Enter a URL (for example http://www.jstor.org/stable/2786878 )
  4. When the citation has been generated by Citoid, click "Insert"
  5. Nothing happens.

The console indicates:

Uncaught TypeError: Cannot read property 'equals' of null

ve.dm.LinearSelection.equals @ load.php?debug=false&lang=en&modules=ext.visualEditor.core|oojs-ui-core&skin=vector&version=7245fa0…:219
ve.dm.SurfaceFragment.update @ load.php?debug=false&lang=en&modules=ext.visualEditor.core|oojs-ui-core&skin=vector&version=7245fa0…:140
ve.dm.SurfaceFragment.change @ load.php?debug=false&lang=en&modules=ext.visualEditor.core|oojs-ui-core&skin=vector&version=7245fa0…:141
ve.dm.SurfaceFragment.insertContent @ load.php?debug=false&lang=en&modules=ext.visualEditor.core|oojs-ui-core&skin=vector&version=7245fa0…:150
ve.dm.MWTransclusionModel.insertTransclusionNode @ VM279:464
ve.ui.CiteFromIdInspector.onPreviewSelectWidgetChoose @ VM279:654
oo.EventEmitter.emit @ VM275:38
ve.ui.CiteFromIdGroupWidget.onItemInsert @ VM279:644
oo.EventEmitter.emit @ VM275:38
oo.EventEmitter.emit @ VM275:38
ve.ui.CiteFromIdReferenceWidget.onInsertButtonClick @ VM279:647
oo.EventEmitter.emit @ VM275:38OO
.ui.mixin.ButtonElement.onClick @ load.php?debug=false&lang=en&modules=ext.visualEditor.core|oojs-ui-core&skin=vector&version=7245fa0…:718
jQuery.event.dispatch @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=tbOYKAbm:65
elemData.handle @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=tbOYKAbm:60

Reproducible every time I try to add a reference on Meta, in Chromium 49.

Details

SubjectRepoBranchLines +/-
SurfaceFramgent: Guard against tx.getModifiedRange returning nullVisualEditor/VisualEditorwmf/1.27.0-wmf.18+12 -14
SurfaceFramgent: Guard against tx.getModifiedRange returning nullVisualEditor/VisualEditormaster+12 -14
Customize query in gerrit

Related Objects

Event Timeline

• gpaumier created this task.Mar 24 2016, 5:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 24 2016, 5:42 PM
Jdforrester-WMF assigned this task to Esanders.Mar 24 2016, 7:57 PM
Jdforrester-WMF triaged this task as Unbreak Now! priority.
Jdforrester-WMF merged a task: T130867: Inserting a citation fails with JS error.
Jdforrester-WMF added projects: VisualEditor-MediaWiki, Citoid.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF added a subscriber: nshahquinn-wmf.
Ryasmeen merged a task: T130777: getRange is null => adding citation fails.Mar 24 2016, 8:05 PM
Ryasmeen added subscribers: Ryasmeen, Jdforrester-WMF, eranroz.
nshahquinn-wmf merged tasks: T130796: Cannot add citation, getting error "this.getRange(...) is null" , T130777: getRange is null => adding citation fails.Mar 24 2016, 8:08 PM
gerritbot subscribed.Mar 24 2016, 10:29 PM

Change 279531 had a related patch set uploaded (by Esanders):
SurfaceFramgent: Guard against tx.getModifiedRange returning null

https://gerrit.wikimedia.org/r/279531

gerritbot added a project: Patch-For-Review.Mar 24 2016, 10:29 PM
gerritbot added a comment.Mar 24 2016, 10:34 PM

Change 279532 had a related patch set uploaded (by Jforrester):
SurfaceFramgent: Guard against tx.getModifiedRange returning null

https://gerrit.wikimedia.org/r/279532

gerritbot added a comment.Mar 24 2016, 10:37 PM

Change 279531 merged by jenkins-bot:
SurfaceFramgent: Guard against tx.getModifiedRange returning null

https://gerrit.wikimedia.org/r/279531

gerritbot added a comment.Mar 24 2016, 10:38 PM

Change 279532 merged by jenkins-bot:
SurfaceFramgent: Guard against tx.getModifiedRange returning null

https://gerrit.wikimedia.org/r/279532

Jdforrester-WMF closed this task as Resolved.Mar 24 2016, 11:24 PM
Jdforrester-WMF edited projects, added User-notice, MW-1.27-release (WMF-deploy-2016-03-22_(1.27.0-wmf.18)), MW-1.27-release (WMF-deploy-2016-03-29_(1.27.0-wmf.19)); removed Patch-For-Review.
Quiddity moved this task from To Triage to In current Tech/News draft on the User-notice board.Mar 24 2016, 11:32 PM
Ryasmeen added a comment.Mar 25 2016, 9:58 PM

This is not working on Beta cluster yet, not updated I guess?

• AlexMonk-WMF subscribed.Mar 25 2016, 10:03 PM

It can't take effect on beta until https://gerrit.wikimedia.org/r/#/c/279535/ goes through

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Mar 26 2016, 12:41 AM
Johan moved this task from In current Tech/News draft to Recently announced in Tech/News on the User-notice board.Mar 30 2016, 10:53 AM
Johan moved this task from Recently announced in Tech/News to Already announced/Archive on the User-notice board.Apr 6 2016, 2:02 PM
Maintenance_bot edited projects, added User-notice-archive; removed MW-1.27-release (WMF-deploy-2016-03-29_(1.27.0-wmf.19)), User-notice.Aug 13 2022, 1:03 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptAug 13 2022, 1:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits