Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Page MenuHomePhabricator
Create Task
Maniphest T280747

Reimplement all the skin module/feature things that have been randomly removed or are no longer usable in core
Open, Needs TriagePublic
Actions

Description

  • ToC indentation (can't use 'toc' because of sizing, alignment, just generally weirdly inconsistent)
  • ToC collapsing (okay, maybe we should just use 'toc' anyway and just override all the weird bits?!)
  • visualClear class (randomly removed)
  • In-content catlinks styles on desktop-small, mobile (can't use 'interface-category' due to being monobook-styled)
  • thumb left, right positioning (can't use 'content' due to thumbs being monobook styled)
  • thumb 'magnify' link positioning (per above)
  • plainlinks (can't use 'elements' due to monobook/vector header underlines/borders, and who knows what else)

Related Objects

Event Timeline

Isarra created this task.Apr 21 2021, 3:36 AM
Ostrzyciel subscribed.Apr 21 2021, 7:11 AM
MusikAnimal mentioned this in T359611: Search panel should use the same direction as the interface.Apr 11 2024, 12:13 AM
MusikAnimal added subscribers: GMikesell-WMF, MusikAnimal.EditedApr 11 2024, 1:15 AM

Of relevance:

In T359611#9705604, @MusikAnimal wrote:
In T359611#9705501, @GMikesell-WMF wrote:

@MusikAnimal Everything seems to be fine except for the Timeless Skin as seen in the video below. It still reads as LTR besides RTL.

Timeless Skin

❌Issue
The search panel [input field] is shown in left-to-right, matching the page language (en) when it should be en-rtl

Thanks for checking! This looks like an issue with Timeless itself, per https://gerrit.wikimedia.org/g/mediawiki/skins/Timeless/+/6dc3d2c902a6840b2a616e1b538951979666a175/resources/libraries/shared.css#24

It's going by the site language rather than the user's language. From reading the relevant commit, it looks like the developer copied styles from MediaWiki Core. Those styles have presumably since been fixed, but have not been copied or whatever over to Timeless. T280747 was linked to as the task.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits