Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Page MenuHomePhabricator
Create Task
Maniphest T292293

Error in "Homepage Shows a suggested edits card and allows navigation forwards and backwards through queue"
Closed, ResolvedPublic
Actions

Assigned To
kostajh
Authored By
Reedy
Oct 1 2021, 1:29 PM
Tags
Referenced Files
F34675980: image.png
Oct 6 2021, 12:53 PM
F34675982: Homepage-Shows-a-suggested-edits-card-and-allows-navigation-forwards-and-backwards-through-queue-2021-10-06T10-33-18-388Z.mp4
Oct 6 2021, 12:53 PM
F34675974: image.png
Oct 6 2021, 12:47 PM
F34675973: Homepage-Shows-a-suggested-edits-card-and-allows-navigation-forwards-and-backwards-through-queue-2021-10-01T13-18-10-709Z.mp4
Oct 6 2021, 12:47 PM
Subscribers
Aklapper
Etonkovidova
Reedy
Tgr

Description

Similar to T291450: GrowthExperiments Selenium test error in specs/homepage.js > HomepagePage.suggestedEditsCard.isExisting, but not the same

Just happened on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/725163/ https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/116081/console

14:18:11 [0-0] Error in "Homepage Shows a suggested edits card and allows navigation forwards and backwards through queue"
14:18:23 Error: element (".suggested-edits-next .oo-ui-buttonElement-button") still not clickable after 5000ms
14:18:23     at Context.it (/workspace/src/extensions/GrowthExperiments/tests/selenium/specs/homepage.js:33:41)
14:18:23 [0-0] FAILED in chrome - /tests/selenium/specs/homepage.js
14:18:23 [0-1] RUNNING in chrome - /tests/selenium/specs/welcomesurvey.js

Details

SubjectRepoBranchLines +/-
selenium: Rework and re-enable suggested edit navigation testmediawiki/extensions/GrowthExperimentsmaster+65 -32
selenium: Use Special:CreateAccount for account creationmediawiki/extensions/GrowthExperimentsmaster+14 -24
selenium: Default suggested edits to preactivatedmediawiki/extensions/GrowthExperimentsmaster+8 -2
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Oct 1 2021, 1:29 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 1 2021, 1:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Reedy updated the task description. (Show Details)Oct 1 2021, 1:30 PM
Tgr triaged this task as High priority.Oct 2 2021, 3:18 AM
Tgr edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
Tgr subscribed.

Marking as high and moving to current spring as it interferes with CI for other repos. Could be an infrastructure error but doesn't sound like it.

Tgr moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 2 2021, 3:18 AM
kostajh claimed this task.Oct 6 2021, 12:44 PM
kostajh moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh added a comment.Oct 6 2021, 12:47 PM

The relevant failure:

Homepage-Shows-a-suggested-edits-card-and-allows-navigation-forwards-and-backwards-through-queue-2021-10-01T13-18-10-709Z.mp4138 KBDownload

image.png (1×2 px, 1 MB)

kostajh added a comment.Oct 6 2021, 12:53 PM

Compare with a successful run:

Homepage-Shows-a-suggested-edits-card-and-allows-navigation-forwards-and-backwards-through-queue-2021-10-06T10-33-18-388Z.mp4154 KBDownload

image.png (1×2 px, 1 MB)

It looks like the code in beforeSuite in wdio.conf.js that we added in T291450: GrowthExperiments Selenium test error in specs/homepage.js > HomepagePage.suggestedEditsCard.isExisting to fix this issue is not working:

browser.executeAsync( ( done ) =>
    mw.loader.using( 'mediawiki.api' ).then( () =>
        new mw.Api().saveOptions( {
            'growthexperiments-homepage-suggestededits-activated': 1,
            'growthexperiments-tour-homepage-discovery': 1,
            'growthexperiments-tour-homepage-welcome': 1
        } ).done( () => done() )
    )
);
gerritbot added a comment.Oct 6 2021, 1:13 PM

Change 726898 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] selenium: Default suggested edits to preactivated

https://gerrit.wikimedia.org/r/726898

gerritbot added a project: Patch-For-Review.Oct 6 2021, 1:14 PM
kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 6 2021, 1:14 PM
gerritbot added a comment.Oct 7 2021, 10:10 AM

Change 726898 abandoned by Kosta Harlan:

[mediawiki/extensions/GrowthExperiments@master] selenium: Default suggested edits to preactivated

Reason:

I think this is fixed in PS7 of I6eeb63d895bb75a55e6ae5bab70deec01351d98c, so abandoning this in the interests of not introducing more complexity

https://gerrit.wikimedia.org/r/726898

Maintenance_bot removed a project: Patch-For-Review.Oct 7 2021, 11:10 AM
gerritbot added a comment.Oct 13 2021, 1:13 PM

Change 702893 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] selenium: Use Special:CreateAccount for account creation

https://gerrit.wikimedia.org/r/702893

gerritbot added a project: Patch-For-Review.Oct 13 2021, 1:13 PM
Urbanecm_WMF changed the task status from Open to In Progress.Jan 31 2022, 11:33 AM
Krinkle mentioned this in T301441: Flaky selenium test: "add link.link inspector appears after clicking through task from Special:Homepage".Feb 10 2022, 7:03 AM
gerritbot added a comment.Feb 14 2022, 2:17 PM

Change 762445 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] selenium: Rework and re-enable homepage test

https://gerrit.wikimedia.org/r/762445

MShilova_WMF lowered the priority of this task from High to Medium.Apr 6 2022, 1:25 PM
kostajh moved this task from Code Review to Blocked / Needs work on the Growth-Team (Sprint 0 (Growth Team)) board.May 24 2022, 2:27 PM
kostajh moved this task from Blocked / Needs work to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 27 2022, 6:24 AM
kostajh lowered the priority of this task from Medium to Low.Jul 29 2022, 12:59 PM
gerritbot added a comment.Oct 11 2022, 11:53 AM

Change 702893 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] selenium: Use Special:CreateAccount for account creation

https://gerrit.wikimedia.org/r/702893

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.6; 2022-10-17).Oct 11 2022, 12:00 PM
gerritbot added a comment.Oct 11 2022, 1:14 PM

Change 762445 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] selenium: Rework and re-enable suggested edit navigation test

https://gerrit.wikimedia.org/r/762445

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 11 2022, 1:18 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 11 2022, 1:30 PM
Etonkovidova closed this task as Resolved.Oct 18 2022, 11:17 PM
Etonkovidova subscribed.

All recent builds -e.g. https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php74-docker/3008/console - are successful.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits