Global blocks should apply to password reset
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Tchanders
	Sep 13 2022, 1:22 PM

Description

Background

Password reset currently checks separately for global blocks, but global blocks don't actually apply to password reset, as explained in T317334.

However, password reset should be blocked by global blocks, as reasoned in this comment: T317334#8223449.

We can do this by ensuring GlobalBlock::appliesToPasswordReset returns true.

Acceptance criteria

Attempting to reset password while globally blocked results in a blocked error.

Notes

This task can be done straight away, and is not blocked on T317334: Remove separate checks for global blocks from PasswordReset.

Details

	Subject	Repo	Branch	Lines +/-
	Override GlobalBlock::appliesToPasswordReset to return true	mediawiki/extensions/GlobalBlocking	master	+7 -0

Customize query in gerrit

Related Objects

Mentioned In: T317334: Remove separate checks for global blocks from PasswordReset
Mentioned Here: T317334: Remove separate checks for global blocks from PasswordReset

Event Timeline

Tchanders created this task.Sep 13 2022, 1:22 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2022, 1:22 PM

Tchanders moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Sep 13 2022, 1:23 PM

Tchanders mentioned this in T317334: Remove separate checks for global blocks from PasswordReset.Sep 13 2022, 1:26 PM

Tchanders set the point value for this task to 2.Sep 13 2022, 1:36 PM

STran moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.Sep 14 2022, 4:40 PM

Tchanders moved this task from Cards ready for development to AHaT Sprint 16: The Sorting Hat on the Anti-Harassment board.Sep 21 2022, 2:15 PM

Tchanders edited projects, added Anti-Harassment (AHaT Sprint 16: The Sorting Hat); removed Anti-Harassment.

• AGueyte claimed this task.Sep 27 2022, 3:19 PM

• AGueyte moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 16: The Sorting Hat) board.Sep 27 2022, 3:34 PM

STran edited projects, added Anti-Harassment (AHT Sprint 17: The Fruit Hat); removed Anti-Harassment (AHaT Sprint 16: The Sorting Hat).Sep 27 2022, 4:48 PM

STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHT Sprint 17: The Fruit Hat) board.

Change 837679 had a related patch set uploaded (by AGueyte; author: AGueyte):

[mediawiki/extensions/GlobalBlocking@master] Global blocks applies to password reset

https://gerrit.wikimedia.org/r/837679

gerritbot added a project: Patch-For-Review.Oct 3 2022, 2:18 PM

• AGueyte moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHT Sprint 17: The Fruit Hat) board.Oct 3 2022, 2:27 PM

Change 837679 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Override GlobalBlock::appliesToPasswordReset to return true

https://gerrit.wikimedia.org/r/837679

Bypassing QA, since this will be tested via T317334: Remove separate checks for global blocks from PasswordReset

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.6; 2022-10-17).Oct 11 2022, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 11 2022, 3:29 PM

Niharika closed this task as Resolved.Dec 8 2022, 12:58 AM

Global blocks should apply to password resetClosed, ResolvedPublic2 Estimated Story PointsActions