Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Page MenuHomePhabricator
Create Task
Maniphest T324431

Parsoid: displaytitle HTML now appearing in <title> element rather than page title
Open, Needs TriagePublic
Actions

Description

Visit https://en.wikipedia.org/api/rest_v1/page/html/...And_Justice_for_All_(film) and in the HTML you'll see <title>&lt;i>...And Justice for All&lt;/i> (film)</title>.

Previously the actual page title would be in the title element, not the displaytitle's HTML (not really sure when this broke). Aside from it being a regression, using the displaytitle is a bad fit because you can't have HTML tags inside the title (per https://developer.mozilla.org/en-US/docs/Web/HTML/Element/title)

If this is the intended behavior, what's the correct way to get a page's title out of its HTML? Parse it from <link rel="dc:isVersionOf" href="//en.wikipedia.org/wiki/...And_Justice_for_All_(film)"/>?

Details

SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to 0.20.0-a19mediawiki/vendormaster+70 -70
Bump wikimedia/parsoid to 0.20.0-a19mediawiki/vendormaster+70 -70
Parsoid <title> element should be actual title, not displaytitlemediawiki/services/parsoidmaster+13 -11
Customize query in gerrit

Related Objects

Event Timeline

Legoktm created this task.Dec 5 2022, 2:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 5 2022, 2:28 AM
Legoktm renamed this task from displaytitle HTML now appearing in <title> element rather than page title to Parsoid: displaytitle HTML now appearing in <title> element rather than page title.Dec 5 2022, 2:28 AM
Arlolra subscribed.Dec 5 2022, 6:12 PM

not really sure when this broke

Maybe with the port to PHP? See T294621

Some other open displaytitle tasks are T293514 and T122976

Izno subscribed.Dec 6 2022, 9:25 PM
• JMcLeod_WMF moved this task from Needs Triage to Feature requests on the Parsoid board.Dec 15 2022, 3:25 PM
Legoktm mentioned this in T326490: mwbot-rs/parsoid: fails transforming html to wikitext if title is italic.Jan 8 2023, 5:42 AM
Legoktm merged a task: T331120: Article with DOM node tags in <title> value (REST API).Mar 3 2023, 9:27 PM
Legoktm added a project: affects-Kiwix-and-openZIM.
Legoktm added a subscriber: Kelson.
Legoktm mentioned this in T342491: REST `/page/html/` API endpoint does not follow redirects as documented & demoed.Jul 24 2023, 5:11 AM
Krinkle added a project: Content-Transform-Team.Aug 19 2024, 8:45 PM
cscott subscribed.EditedAug 29 2024, 2:30 PM

~~~I can't find the code in Parsoid which actually sets the title element (!).~~~ It was originally thought that the title element would be a good way to convey the title metadata, but as @Legoktm points out there's some additional sanitization which happens with the value on its way to title which complicates this. This isn't really an issue for 'modern' parsoid since we communicate the title via ParserOutput/ContentMetadataCollector metadata, not the title element. The actual page title (as opposed to displaytitle) is passed in a <link rel="dc:isVersionOf"> element in the head as @Legoktm mentioned. Perhaps we should be passing displaytitle that way as well.

cscott claimed this task.Aug 29 2024, 2:30 PM
gerritbot added a comment.Aug 29 2024, 3:03 PM

Change #1068802 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] Parsoid <title> element should be actual title, not displaytitle

https://gerrit.wikimedia.org/r/1068802

gerritbot added a project: Patch-For-Review.Aug 29 2024, 3:03 PM
gerritbot added a comment.Aug 29 2024, 8:59 PM

Change #1068802 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Parsoid <title> element should be actual title, not displaytitle

https://gerrit.wikimedia.org/r/1068802

Maintenance_bot removed a project: Patch-For-Review.Aug 29 2024, 9:34 PM
gerritbot added a comment.Sep 2 2024, 3:21 PM

Change #1070043 had a related patch set uploaded (by Jgiannelos; author: Jgiannelos):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a19

https://gerrit.wikimedia.org/r/1070043

gerritbot added a project: Patch-For-Review.Sep 2 2024, 3:21 PM
gerritbot added a comment.Sep 2 2024, 4:04 PM

Change #1070051 had a related patch set uploaded (by Jgiannelos; author: Jgiannelos):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a19

https://gerrit.wikimedia.org/r/1070051

gerritbot added a comment.Sep 2 2024, 4:05 PM

Change #1070043 abandoned by Jgiannelos:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a19

https://gerrit.wikimedia.org/r/1070043

gerritbot added a comment.Sep 2 2024, 4:58 PM

Change #1070051 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a19

https://gerrit.wikimedia.org/r/1070051

Maintenance_bot removed a project: Patch-For-Review.Sep 2 2024, 5:30 PM
SLopes-WMF edited projects, added Content-Transform-Team-WIP; removed Content-Transform-Team.Sep 5 2024, 2:15 PM
MSantos added a project: Essential-Work.Mon, Sep 9, 2:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits