Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Page MenuHomePhabricator

IP address warning on Lexeme editing page
Closed, ResolvedPublic8 Estimated Story Points

Description

As an anonymous editor I want to be warned that my IP address will be used in edit histories when I am making edits to a Lexeme, Form or Sense.

Problem:
We currently don't show the "IP address warning" message when a Lexeme, Form or Sense is edited like we do when an Item is edited.

We need to have the same pop-up message appear when a Lexeme, Form or Sense is edited to notify the users that their IP address will be included in the edit history.

Screenshot

image.png (196×319 px, 19 KB)

Screenshot from an Item page when not logged in and an edit is being made

Copy
Warning: You are not logged in. Your IP address will be publicly visible if you make any edits. If you log in or create an account, your edits will be attributed to a username, among other benefits.

BDD
GIVEN a Lexeme
AND an editor that is not logged in
WHEN a Lexeme, Form or Sense is edited
THEN the IP address warning message is displayed

Acceptance criteria:

  • "IP address warning" is displayed when an edit of a Lexeme, Form or Sense is made by an anonymous user

Event Timeline

Arian_Bozorg renamed this task from IP address warning on Lexeme editing page to [SW] IP address warning on Lexeme editing page .Aug 11 2023, 9:15 AM
Arian_Bozorg renamed this task from [SW] IP address warning on Lexeme editing page to IP address warning on Lexeme editing page .Aug 16 2023, 9:02 AM
Arian_Bozorg updated the task description. (Show Details)

Task breakdown notes:

  • A good place to start looking into this is: attachAnonymousEditWarningTrigger in repo/resources/wikibase.ui.entityViewInit.js
  • This is probably not parallellizable.

Change 956943 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/WikibaseLexeme@master] Show a warning when editing forms and sense as anonymous

https://gerrit.wikimedia.org/r/956943

Change 957299 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/WikibaseLexeme@master] Show a warning when editing the lexeme "header" as anonymous

https://gerrit.wikimedia.org/r/957299

Change 956943 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Show a warning when editing forms and sense as anonymous

https://gerrit.wikimedia.org/r/956943

Change 957299 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Show a warning when editing the lexeme "header" as anonymous

https://gerrit.wikimedia.org/r/957299

This looks good to me :) thanks so much