Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Page MenuHomePhabricator

Ctrl+Enter should not submit the comment while the focus is outside the textbox
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Start composing a reply
  • Switch to the source mode
  • Enter e.g. [[Foo]]
  • Use the Tab key to focus the link "Foo" in the preview
  • Press Ctrl+Enter

What happens?:
The reply gets submitted.

What should have happened instead?:
The link opens in a new tab.

Event Timeline

Change #1105665 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Don't submit on CTRL+Enter on non-form elements (e.g. links)

https://gerrit.wikimedia.org/r/1105665

Change #1105665 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Don't submit on CTRL+Enter on non-form elements (e.g. links)

https://gerrit.wikimedia.org/r/1105665

matmarex assigned this task to Esanders.
matmarex removed a project: Patch-For-Review.