Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Page MenuHomePhabricator

TheDJ (Derk-Jan Hartman)
Volunteer developer (NOT NOT NOT WMF)

Projects (34)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 10:32 PM (515 w, 11 h)
Availability
Available
IRC Nick
thedj
LDAP User
TheDJ
MediaWiki User
TheDJ [ Global Accounts ]

Have you heard ? I'm not part of WMF, never have been.

  • Open Source dev since 2001
  • Wikipedian since 2005
  • Wikipedia admin 2008-2019
  • Commons admin 2010-2015
  • MediaWiki dev (+2) since 2009

Uses Safari most of the time (because someone has to)

Recent Activity

Today

TheDJ added a comment to T75602: Mirrored EXIF rotations are not applied to thumbnails.

@Tgr btw. Regarding our wikimania conversation, I was referring to T32961

Tue, Aug 20, 9:19 AM · User-TheDJ, Patch-For-Review, Commons, Multimedia, MediaWiki-File-management
TheDJ added a comment to T368190: Stock Photo gadget: "All sizes" not true.

There are infinite sizes, so 'all sizes' doesn't exist to begin with.

Tue, Aug 20, 9:06 AM · Local-Wiki-Template-And-Gadget-Issues, Commons

Fri, Aug 16

TheDJ closed T160141: Coord::bboxAround() works only on Earth as Resolved.
Fri, Aug 16, 9:52 AM · MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), User-thiemowmde, Discovery-Search, GeoData

Thu, Aug 15

TheDJ edited projects for T369361: Mobile MediaViewer dumps HTML instead of author, added: CommonsMetadata; removed MediaViewer.
Thu, Aug 15, 8:04 PM · CommonsMetadata, MobileFrontend, Mobile
TheDJ added projects to T372561: Add last updated data to footer of generated PDFs: Browser-support-print-media, Desktop Improvements (Vector 2022).

PrintPdf isn't any different than any other print. So this isn't really PDF specific but more print in general.

Thu, Aug 15, 2:55 PM · Desktop Improvements (Vector 2022), Browser-support-print-media, Electron-PDFs, Proton
TheDJ awarded T354242: Uncaught Error: ZipArchive::addFile(): Argument #1 ($filepath) cannot be empty a Doubloon token.
Thu, Aug 15, 11:57 AM · WikiHiero, Community-Tech, WS Export
TheDJ updated the task description for T146798: Replace Moment.js in core with something smaller (what?).
Thu, Aug 15, 11:39 AM · Patch-For-Review, MediaWiki-General, Technical-Debt, I18n, Front-end-Standards-Group
TheDJ created T372538: https://gitlab.devtools.wmcloud.org is being indexed by google (and scoring pretty high).
Thu, Aug 15, 9:42 AM · Patch-For-Review, User-brennen, collaboration-services, Release-Engineering-Team, VPS-project-devtools, GitLab

Wed, Aug 14

TheDJ added a comment to T230812: Use native image lazy loading on mobile site.

@Krinkle and @Jdlrobson I did some testing and I was able to force Safari to load the native lazy images, using a onbeforeprint handler and setting the loading property of each img to 'eager'. I can also just remove the loading attribute and this too seems to load the images. I had tried this in the past and it wasn't working back then., so possibly some improvements have been made by Apple.

Wed, Aug 14, 11:41 AM · Wikimedia-Performance-recommendation, MobileFrontend

Tue, Aug 13

TheDJ added projects to T370413: Contributions are not shown for usemod-style IP address octets that end with xxx: Temporary accounts, Trust-and-Safety.

Quite possibly a regression due to the temporary accounts refactoring, so adding that project.

Tue, Aug 13, 11:27 AM · Patch-For-Review, Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)), Trust and Safety Product Team, Temporary accounts, Regression, MediaWiki-Special-pages

Sun, Aug 11

TheDJ added a comment to T369361: Mobile MediaViewer dumps HTML instead of author.

many files with weird wikitext.

Yes, this is impossible to do 100% correctly without Commons Data. parsing wikitext will always have failures.

Sun, Aug 11, 11:18 AM · CommonsMetadata, MobileFrontend, Mobile

Fri, Aug 9

TheDJ updated subscribers of T372165: Reduce number of bucketsizes for MediaViewer.
Fri, Aug 9, 5:13 PM · MediaViewer
TheDJ created T372165: Reduce number of bucketsizes for MediaViewer.
Fri, Aug 9, 5:13 PM · MediaViewer
TheDJ closed T368301: STL 3D models broken: "Sorry, the file Undefined cannot be displayed since it is not present on the current page." as Resolved.
Fri, Aug 9, 5:04 PM · MW-1.43-notes (1.43.0-wmf.18; 2024-08-13), Wikimania-Hackathon-2024, serviceops, Regression, 3D, Commons
TheDJ closed T269987: Make thumbnail width buckets a config variable as Resolved.
Fri, Aug 9, 5:04 PM · MW-1.43-notes (1.43.0-wmf.18; 2024-08-13), Wikimania-Hackathon-2024, Patch-For-Review, User-TheDJ, MediaViewer
TheDJ added a comment to T107875: Use InnoDB engine for searchindex table in MySQL.

Discussed this with @Ladsgroup
We concluded that this is simply not really worth the effort in the this patch round. As Wikimedia doesn't rely on it, rearchitecting the testcases of Wikimedia to not so strongly depend on searchindex will needlessly complicate things. Instead, I'll provide maintenance script to convert to innodb for those who desire this.

Fri, Aug 9, 5:03 PM · User-TheDJ, Patch-Needs-Improvement, MediaWiki-Installer, MediaWiki-Search
TheDJ added a comment to T75602: Mirrored EXIF rotations are not applied to thumbnails.

Note: we don't have any of the mirroring info in our metadata tables, as we actively turn it into jepgRotation (with a value in degrees). So retroactively figuring this out for all images, requires reparsing all images, which is an known impossible issue...

Fri, Aug 9, 4:31 PM · User-TheDJ, Patch-For-Review, Commons, Multimedia, MediaWiki-File-management
TheDJ added a comment to T156433: Geoline/geoshape does not work with relations other than multipolygon/route/boundary.

We've been trying to determine what "Wikimedia has switched from osm2pgsql to imposm3, support for more relation types can be configured, now type=waterway is supported in addition to previous three types. It should be further reviewed which other relation types can be and should be supported." actually means.

Fri, Aug 9, 3:00 PM · Community-Wishlist-Survey-2022, Maps (Kartotherian)
TheDJ created T372150: Cannot find geoline/geoways of OSM links that have been set on ways and shapes that are NOT relations.
Fri, Aug 9, 2:32 PM · Maps (Kartotherian)
TheDJ added a comment to T77349: Reduce Javascript Code Size per 2014 Mobile Team recommendation.

Reminder: todo rewrite the modules to make use of RL's config.json logic / virtual files provided by PHP, instead of using our own config object.

Fri, Aug 9, 1:32 PM · MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), Patch-For-Review, Multimedia, Mobile, MediaViewer
TheDJ added a project to T269987: Make thumbnail width buckets a config variable: User-TheDJ.
Fri, Aug 9, 1:25 PM · MW-1.43-notes (1.43.0-wmf.18; 2024-08-13), Wikimania-Hackathon-2024, Patch-For-Review, User-TheDJ, MediaViewer
TheDJ added a comment to T363885: Panoramic images thumbnailing component.

Any ideas ?

I don't know why it would work in the src dir. The find module is documented as setting JPEG_INCLUDE_DIRS which should then be passed to target_include_directories(), it shouldn't just work by magic.

Fri, Aug 9, 11:53 AM · Community-Tech, Commons, MediaWiki-File-management, Thumbor
TheDJ added a comment to T368301: STL 3D models broken: "Sorry, the file Undefined cannot be displayed since it is not present on the current page.".

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/3D/+/1061039

Fri, Aug 9, 9:48 AM · MW-1.43-notes (1.43.0-wmf.18; 2024-08-13), Wikimania-Hackathon-2024, serviceops, Regression, 3D, Commons
TheDJ awarded T369875: Page banner doesn't work in dark mode. a Stroopwafel token.
Fri, Aug 9, 7:45 AM · MW-1.43-notes (1.43.0-wmf.18; 2024-08-13), Web Team Essential Work 2024 (Complete roll out of dark mode and font-size to all Wikimedia wikis), Web-Team-Backlog (FY2024-25 Q1 Sprint 3), patch-welcome, dark-mode, Wikidata-Page-Banner

Thu, Aug 8

TheDJ added a comment to T371621: ApiUsageException: Could not normalize image parameters for [file].pdf..

If @TheDJ is correct then this is likely not an issue on the Structured Content team/MediaSearch extension side, right?

Thu, Aug 8, 3:45 PM · Structured-Data-Backlog, User-brennen, Wikimedia-production-error
TheDJ added a comment to T363885: Panoramic images thumbnailing component.

@tstarling I tried compiling on my mac, and i'm glad to report that it works.

Thu, Aug 8, 1:10 PM · Community-Tech, Commons, MediaWiki-File-management, Thumbor

Wed, Aug 7

TheDJ reopened T370740: "Download as PDF" button links to Special:Book instead of Special:DownloadAsPdf on dewiki as "Open".
Wed, Aug 7, 2:32 PM · Patch-For-Review, FlaggedRevs, Electron-PDFs, Proton, Collection
TheDJ added a comment to T367463: Tables with images inside them appear at minuscule size or disappear due to responsive image CSS.

I see that this is still happening here: https://eu.wikipedia.org/wiki/Wikipedia:Bost_euskarriak. What should we do to improve that? Should we find every affected page and solve it manually?

Wed, Aug 7, 1:48 PM · User-notice-archive, MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), Desktop Improvements (Vector 2022), MinervaNeue, Web-Team-Backlog (FY2023-24 Q4 Sprint 6)

Tue, Aug 6

TheDJ added a comment to T117618: Add restrictive CSP to upload.wikimedia.org.

What's the effect? Shall Wikimedia content be include-able into Commons svg graphics? Are we talking about resources external to a given svg graphic or external to Wikimedia?

Tue, Aug 6, 8:17 AM · Patch-For-Review, Traffic, ContentSecurityPolicy, WMF-General-or-Unknown, Security-Team
TheDJ awarded T370474: Refresh membership of Toolforge standards committee a Mountain of Wealth token.
Tue, Aug 6, 8:09 AM · User-notice, User-bd808, Toolforge-standards-committee

Sat, Aug 3

TheDJ added a comment to T371727: Do not show closed captions by default if video language matches user lang.

Traditionally...

  • the vast majority of Wikimedia video material is in English
  • english wikipedia has a large international non-native speaking audience
  • subtitles for Wikimedia videos (especially in your own language) are actually pretty rare.

To facilitate and encourage discovery of subtitles, they are enabled by default when available in your language.

Sat, Aug 3, 6:15 PM · TimedMediaHandler-TimedText, Commons

Fri, Aug 2

TheDJ added a comment to T369874: [Spike 1day] Many template styles are following outdated instructions that we gave them and need fixing.

Community: Go left, no RIIIGHT, no middle !!!

Fri, Aug 2, 9:33 PM · Web Team Essential Work 2024, Web-Team-Backlog (FY2024-25 Q1 Sprint 3)
TheDJ added a comment to T369499: Underline links: never preference should not affect hover state in Vector 2022.

I think the "Never" option dates from when some skins had links underlined by default: the long-since removed classic and the long-since deprecated Cologne Blue. So it made sense to have an option to override that.

Fri, Aug 2, 8:45 AM · Accessibility, Patch-For-Review, MediaWiki-Core-Preferences, Web-Team-Backlog, Design-System-Team, Desktop Improvements (Vector 2022), CSS

Thu, Aug 1

TheDJ closed T369388: Upload errors due to swift failures, 503s as Resolved.

As the cause of this seems covered by T360913 and the incident as reported was resolved, i'm closing this.

Thu, Aug 1, 5:56 PM · Data-Persistence, MediaWiki-Uploading, SRE-swift-storage
TheDJ added a subtask for T328872: Commons: UploadChunkFileException: Error storing file: backend-fail-internal; local-swift-codfw: T360913: Swift proxy server misbehaviour (no longer calling `accept`?).
Thu, Aug 1, 5:56 PM · API Platform, MediaWiki-File-management, MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), Unstewarded-production-error, MediaWiki-Uploading, Wikimedia-production-error, SRE-swift-storage, Commons
TheDJ added a parent task for T360913: Swift proxy server misbehaviour (no longer calling `accept`?): T328872: Commons: UploadChunkFileException: Error storing file: backend-fail-internal; local-swift-codfw.
Thu, Aug 1, 5:56 PM · SRE-swift-storage
TheDJ added a comment to T371621: ApiUsageException: Could not normalize image parameters for [file].pdf..

This is a pretty common exception, nothing new, not a blocker: https://logstash.wikimedia.org/goto/8d2eb4f8c362a150b5819e17602fda7d

Thu, Aug 1, 5:31 PM · Structured-Data-Backlog, User-brennen, Wikimedia-production-error
TheDJ added a comment to T367645: The background of some SVG maps is not rendered.

@Tsarivan613 I purged the page, and this regenerated the thumbnails and now it works.

Thu, Aug 1, 1:25 PM · Wikimedia-SVG-rendering
TheDJ added a comment to T371265: Getting rid of mw-content-{ltr,rtl}.

Related logical properties tickets: T322482, T304017

Thu, Aug 1, 6:47 AM · MW-1.43-notes (1.43.0-wmf.18; 2024-08-13), I18n, MediaWiki-Internationalization, RTL, Patch-For-Review

Wed, Jul 31

TheDJ added a comment to T366623: Create a parser function to get the BCP47 code for a language.

Documented at: https://www.mediawiki.org/wiki/Help:Magic_words#Localization

Wed, Jul 31, 12:30 PM · MW-1.43-notes (1.43.0-wmf.17; 2024-08-06), User-notice, MediaWiki-Parser, MediaWiki-Internationalization
TheDJ added a comment to T371383: Empty KartographerLiveData if rendered with Parsoid.

I do not think so. dewikivoyage uses the same Parsoid (0.20.0-a14) and Kartographer versions (4b02f48, 22 July 2024) like enwikivoyage.

Wed, Jul 31, 8:50 AM · Parsoid-Read-Views, Content-Transform-Team-WIP, Parsoid-Rendering, Parsoid, Maps (Kartographer)

Tue, Jul 30

TheDJ added a comment to T224922: Code Stewardship Review: Collection Extension.

The Book Creator has not been disabled anywhere. It's been hidden from the sidebar, but still works if you know about it I think. But that, and the decision to delete the book namespace, were both much more hard-fought than you think.

And there's also https://mediawiki2latex.wmcloud.org/

I personally think the entire collection extension should be undeployed and archived at this point. But it appears that at least some segment of the community still sees value in it, as comments like https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(proposals)/Archive_177#c-Steelpillow-2021-03-16T17:35:00.000Z-Aza24-2021-03-13T06:48:00.000Z show.

Tue, Jul 30, 9:51 PM · Collection, Code-Stewardship-Reviews
TheDJ updated the task description for T371147: Electron/Collection/Proton cleanup.
Tue, Jul 30, 9:31 PM · Technical-Debt, MW-1.43-notes (1.43.0-wmf.17; 2024-08-06), Collection, Proton, Electron-PDFs
TheDJ added a comment to T224922: Code Stewardship Review: Collection Extension.
  • The book creator is disabled from some of the biggest wikipedia's: dewiki, enwiki, fawiki, fiwiki, nowiki, ruwiki
  • it hasn't been maintained since around 2014
  • the ui has references to downloads all over the place, but these downloads are not actually being provided for books. All downloads are done via Electron/Proton
  • it uses jquery ui
  • the JS style is very old and has lots of inline JS
  • it doesn't support dark mode
Tue, Jul 30, 9:29 PM · Collection, Code-Stewardship-Reviews
TheDJ added a comment to T371377: 'Report an issue with dark mode' button not keyboard-focusable .

This seems strange... are we just pretending that anon users can provide feedback ? Or are we accidentally adding that element when we shouldnt be ?

We were supposed to be logging events on every click, and then the idea was to provide summaries of that data to the community.
However, as we started working on generating these reports in T370233 we discovered a bug (T371325) which meant this isn't working so we're currently in the process of re-evaluation (T370825).
We want anons to provide feedback but there are concerns (not mine) that if we push them to the talk page, we'll get a lot of spam/useless reports from IP users.

Tue, Jul 30, 9:04 PM · Verified, Desktop Improvements (Vector 2022), MW-1.43-notes (1.43.0-wmf.17; 2024-08-06), Web-Team-Backlog (FY2024-25 Q1 Sprint 3), Unplanned-Sprint-Work, Accessibility, dark-mode
TheDJ updated subscribers of T371377: 'Report an issue with dark mode' button not keyboard-focusable .

@Jdlrobson was looking at this, and there is more going on here that i do not understand...

Tue, Jul 30, 7:53 PM · Verified, Desktop Improvements (Vector 2022), MW-1.43-notes (1.43.0-wmf.17; 2024-08-06), Web-Team-Backlog (FY2024-25 Q1 Sprint 3), Unplanned-Sprint-Work, Accessibility, dark-mode
TheDJ merged T371381: Report an issue in Appearance menu should use role=button into T371377: 'Report an issue with dark mode' button not keyboard-focusable .
Tue, Jul 30, 1:26 PM · Verified, Desktop Improvements (Vector 2022), MW-1.43-notes (1.43.0-wmf.17; 2024-08-06), Web-Team-Backlog (FY2024-25 Q1 Sprint 3), Unplanned-Sprint-Work, Accessibility, dark-mode
TheDJ merged task T371381: Report an issue in Appearance menu should use role=button into T371377: 'Report an issue with dark mode' button not keyboard-focusable .
Tue, Jul 30, 1:26 PM · Accessibility, Web-Team-Backlog, Desktop Improvements (Vector 2022)
TheDJ created T371381: Report an issue in Appearance menu should use role=button.
Tue, Jul 30, 1:22 PM · Accessibility, Web-Team-Backlog, Desktop Improvements (Vector 2022)

Mon, Jul 29

TheDJ added a comment to T242031: Allow multiple different 2FA devices.

@taavi anything left to do here, or shall we resolve the ticket ?

Mon, Jul 29, 7:47 PM · MediaWiki-Platform-Team (Radar), MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), Wikimania-Hackathon-2023, Community-Wishlist-Survey-2023, MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), MediaWiki-extensions-OATHAuth
TheDJ added a comment to T370514: class=noresize is invalid for video file.

Noresize is a bit of a workaround, but there theoretically can be lots of elements inside a thumbnail. Adding every element possible seems like it might not scale, but i think adding it for video might be warranted.

Mon, Jul 29, 10:09 AM · Web Team Essential Work 2024 (Improve display of large tables in Vector 2022 and Minerva skins), Web-Team-Backlog, Desktop Improvements (Vector 2022)

Sun, Jul 28

TheDJ added a comment to T306232: "Download as PDF" on an old revision goes to Special:Book rather than Special:DownloadAsPdf.

But it’s possible to add a query or path parameter to it that accepts a revision ID, isn’t it? It may require quite some work, of course (I don’t know how it works), I’m only talking about the possibility. (If it takes a lot of work, merging your patch as a short-term solution probably makes sense, but I hope it won’t be the long-term solution.)

Sun, Jul 28, 2:59 PM · MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), Electron-PDFs, Browser-support-print-media
TheDJ added a comment to T306232: "Download as PDF" on an old revision goes to Special:Book rather than Special:DownloadAsPdf.

From the patch commit message:

Remove Download as PDF link on old revisions, as Electron/Proton do
not support it. […]

Couldn’t they be made support it? The merged-in task T370740 highlighted that download as PDF is broken on FlaggedRevs wikis if and only if the current page has unreviewed changes.

Sun, Jul 28, 12:42 PM · MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), Electron-PDFs, Browser-support-print-media
TheDJ added a comment to T158989: Add img_sha256, related columns with SHA-256 hash of file.

Btw. I figured that this might be resource intensive to calculate for all files, but I realized that the sha256’s are already in swift. So should be relatively easy to backfill one day.

Sun, Jul 28, 8:43 AM · Security, Schema-change, MediaWiki-File-management, Commons, Multimedia, Technical-Debt

Fri, Jul 26

TheDJ merged task T370740: "Download as PDF" button links to Special:Book instead of Special:DownloadAsPdf on dewiki into T306232: "Download as PDF" on an old revision goes to Special:Book rather than Special:DownloadAsPdf.
Fri, Jul 26, 11:09 PM · Patch-For-Review, FlaggedRevs, Electron-PDFs, Proton, Collection
TheDJ merged T370740: "Download as PDF" button links to Special:Book instead of Special:DownloadAsPdf on dewiki into T306232: "Download as PDF" on an old revision goes to Special:Book rather than Special:DownloadAsPdf.
Fri, Jul 26, 11:08 PM · MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), Electron-PDFs, Browser-support-print-media
TheDJ closed T279327: Replace usages of Linker::link() and Linker::linkKnown() in extension Collection as Resolved.
Fri, Jul 26, 10:29 PM · MW-1.43-notes (1.43.0-wmf.16; 2024-07-30), Collection, Technical-Debt
TheDJ closed T279327: Replace usages of Linker::link() and Linker::linkKnown() in extension Collection, a subtask of T149346: Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions, as Resolved.
Fri, Jul 26, 10:29 PM · Patch-Needs-Improvement, MediaWiki-extensions-Other, MediaWiki-extensions-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Google-Code-in-2017, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), patch-welcome, MW-1.29-release-notes, Google-Code-In-2016, Technical-Debt
TheDJ updated the task description for T371147: Electron/Collection/Proton cleanup.
Fri, Jul 26, 9:39 PM · Technical-Debt, MW-1.43-notes (1.43.0-wmf.17; 2024-08-06), Collection, Proton, Electron-PDFs
TheDJ updated the task description for T371147: Electron/Collection/Proton cleanup.
Fri, Jul 26, 8:59 PM · Technical-Debt, MW-1.43-notes (1.43.0-wmf.17; 2024-08-06), Collection, Proton, Electron-PDFs
TheDJ added a comment to T256071: Collection extension should be made aware of the ElectronPdf extension: Settle on a common sidebar key for both extensions.

I agree as well but there are some provenance issues:

  • a common id is/should? generally only used when it is defined in core
  • renaming this will cause the translation strings to move (should check if there are a lot of local overrides of these string perhaps)
Fri, Jul 26, 8:57 PM · Electron-PDFs, Collection
TheDJ created T371147: Electron/Collection/Proton cleanup.
Fri, Jul 26, 8:54 PM · Technical-Debt, MW-1.43-notes (1.43.0-wmf.17; 2024-08-06), Collection, Proton, Electron-PDFs
TheDJ added a comment to T224922: Code Stewardship Review: Collection Extension.

So.. it's been a couple of years.. Any thoughts ?

Fri, Jul 26, 8:15 PM · Collection, Code-Stewardship-Reviews
TheDJ added a project to T285400: Hide disabled download box from Special:Book: User-TheDJ.
Fri, Jul 26, 8:03 PM · User-TheDJ, Patch-For-Review, good first task, Collection

Thu, Jul 25

TheDJ added a comment to T370740: "Download as PDF" button links to Special:Book instead of Special:DownloadAsPdf on dewiki.

That definitely is quite strange...

Thu, Jul 25, 2:17 PM · Patch-For-Review, FlaggedRevs, Electron-PDFs, Proton, Collection

Wed, Jul 24

TheDJ assigned T370357: MobileFrontend is adding `diffonly=true` query param to navigation links on category pages to Func.

Thank you for the patch @Func !

Wed, Jul 24, 9:24 PM · Verified, Unplanned-Sprint-Work, MW-1.43-notes (1.43.0-wmf.16; 2024-07-30), Web-Team-Backlog (FY2024-25 Q1 Sprint 3), patch-welcome, MobileFrontend
TheDJ closed T370194: Upstream printfooter clear from en.wp to interface-print.less as Resolved.
Wed, Jul 24, 9:20 PM · MW-1.43-notes (1.43.0-wmf.16; 2024-07-30), patch-welcome, Browser-support-print-media, Web-Team-Backlog, MediaWiki-Core-Skin-Architecture
TheDJ claimed T370194: Upstream printfooter clear from en.wp to interface-print.less.
Wed, Jul 24, 12:40 PM · MW-1.43-notes (1.43.0-wmf.16; 2024-07-30), patch-welcome, Browser-support-print-media, Web-Team-Backlog, MediaWiki-Core-Skin-Architecture

Sun, Jul 21

TheDJ added a comment to T365806: Infinite scroll for articles (split documents on wikisource).

Why can't the entire text be rendered at load time? As long as the browser doesn't run out of memory and crash, it should work fine. I would personally find infinite scroll annoying if for example I were reading Wikisource on an unstable connection.

Sun, Jul 21, 10:59 AM · MediaWiki-General, All-and-every-Wikisource
TheDJ added a comment to T362831: High dynamic range (HDR) videos aren't consistently supported or tone-mapped to SDR.

Is this issue being prioritized at all?

Sun, Jul 21, 10:20 AM · TimedMediaHandler-Transcode

Jul 18 2024

TheDJ awarded Blog Post: Iterative Improvements a Stroopwafel token.
Jul 18 2024, 7:43 AM

Jul 17 2024

TheDJ added a comment to T191156: Convert FlaggedRevisions to Codex.

In sports we have an old wisdom: never change a winning game. So was there a real reason to begin meddling with that? I mean a true real reason?

Jul 17 2024, 8:06 PM · Patch-For-Review, MW-1.43-notes (1.43.0-wmf.17; 2024-08-06), MW-1.41-notes (1.41.0-wmf.20; 2023-08-01), User-notice, Growth-Team-Filtering, MinervaNeue (Tracking), Mobile, Growth-Team, FlaggedRevs
TheDJ closed T295514: Score audio uses different players depending on whether the page has other embedded media as Resolved.
Jul 17 2024, 7:31 PM · MW-1.43-notes (1.43.0-wmf.15; 2024-07-23), Essential-Work, Content-Transform-Team-WIP, MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), TimedMediaHandler, MediaWiki-extensions-Score
TheDJ reassigned T295514: Score audio uses different players depending on whether the page has other embedded media from TheDJ to Fomafix.
Jul 17 2024, 7:30 PM · MW-1.43-notes (1.43.0-wmf.15; 2024-07-23), Essential-Work, Content-Transform-Team-WIP, MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), TimedMediaHandler, MediaWiki-extensions-Score
TheDJ closed T295514: Score audio uses different players depending on whether the page has other embedded media, a subtask of T301156: Request: Smaller play bar for scores, as Resolved.
Jul 17 2024, 7:29 PM · MediaWiki-extensions-Score
TheDJ added a comment to T364675: Special:Nearby forces pages to open in desktop view.

So this happens because https://www.mediawiki.org/wiki/API:Info returns urls that do not take into account the mobile domain.
I also think there is no way for it to do that at the moment.

Jul 17 2024, 7:14 PM · Unplanned-Sprint-Work, Web-Team-Backlog (FY2024-25 Q1 Sprint 2), MW-1.43-notes (1.43.0-wmf.16; 2024-07-30), patch-welcome, Mobile, NearbyPages
Prototyperspective awarded T24660: Display the categories on the mobile site for everyone a Burninate token.
Jul 17 2024, 12:02 PM · Community-Wishlist-Survey-2023, Web-Team-Backlog, Advanced Mobile Contributions, Mobile, Regression, Wikimedia-Israel-Hackers, MobileFrontend, Design
TheDJ closed T60663: media viewer doesn't preserve thumbnail options like svg language as Resolved.

This was fixed as part of T208564

Jul 17 2024, 10:21 AM · Multimedia, MediaViewer
TheDJ closed T60663: media viewer doesn't preserve thumbnail options like svg language, a subtask of T18052: Support for multilingual SVGs, as Resolved.
Jul 17 2024, 10:21 AM · Commons, MediaWiki-File-management
TheDJ added a project to T370194: Upstream printfooter clear from en.wp to interface-print.less: Browser-support-print-media.
Jul 17 2024, 8:39 AM · MW-1.43-notes (1.43.0-wmf.16; 2024-07-30), patch-welcome, Browser-support-print-media, Web-Team-Backlog, MediaWiki-Core-Skin-Architecture
TheDJ added a comment to T370194: Upstream printfooter clear from en.wp to interface-print.less.

Yes this was a pretty common problem where quite regularly floating content would bleed into the skin over the past 20 years. There was no consistency in skins that dealt with this universally, and quite often it made assumptions about where content could appear. I remember especially this being a problem in the edit/preview screen, where the previewed content would overlap into the edit screen.

Jul 17 2024, 8:33 AM · MW-1.43-notes (1.43.0-wmf.16; 2024-07-30), patch-welcome, Browser-support-print-media, Web-Team-Backlog, MediaWiki-Core-Skin-Architecture
TheDJ added a comment to T369499: Underline links: never preference should not affect hover state in Vector 2022.

We think it might be better served as a gadget rather than a feature baked into the skin.

Jul 17 2024, 8:20 AM · Accessibility, Patch-For-Review, MediaWiki-Core-Preferences, Web-Team-Backlog, Design-System-Team, Desktop Improvements (Vector 2022), CSS

Jul 16 2024

TheDJ added a project to T369499: Underline links: never preference should not affect hover state in Vector 2022: Accessibility.

Change #1054627 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Drop support for underline links

https://gerrit.wikimedia.org/r/1054627

Jul 16 2024, 6:58 PM · Accessibility, Patch-For-Review, MediaWiki-Core-Preferences, Web-Team-Backlog, Design-System-Team, Desktop Improvements (Vector 2022), CSS
TheDJ added a comment to T257652: Add support for AVIF: serve AVIF thumbnails where possible.

It is true that AVIF encoding is much slower than earlier formats. If this is too CPU heavy to achieve during upload, it might be possible to use a maintenance script that generates new thumbnails in avif format during off-peak hours - perhaps even Imaginary or similar tools on other servers. The gain in bandwidth could be substantial, especially for image heavy sites like Wikimedia Commons.

Here are some examples Netflix did 2020. The examples anf comparisons are a bit down the article. https://netflixtechblog.com/avif-for-next-generation-image-coding-b1d75675fe4

Jul 16 2024, 6:10 PM · Thumbor, Commons, MediaWiki-File-management

Jul 15 2024

TheDJ changed the status of T107875: Use InnoDB engine for searchindex table in MySQL from Open to Stalled.

This is currently blocked on all our testcases relying on tables to be cloneable, but innoDB cannot create a TEMPORARY table of a table that has a FULLTEXT index.

Jul 15 2024, 7:18 PM · User-TheDJ, Patch-Needs-Improvement, MediaWiki-Installer, MediaWiki-Search
TheDJ changed the status of T249976: Convert searchindex UNIQUE to PK from Open to Stalled.
Jul 15 2024, 7:18 PM · Patch-For-Review, User-TheDJ, MediaWiki-Search, Discovery-Search, Platform Team Workboards (External Code Reviews), Schema-change
TheDJ changed the status of T231827: Data too long for column 'si_title' from Open to Stalled.
Jul 15 2024, 7:18 PM · affects-Miraheze, Patch-For-Review, Discovery-Search, MediaWiki-Search
TheDJ moved T353985: Deprecated usage of PrefixSearchBackend hook from Inbox to For-review on the User-TheDJ board.
Jul 15 2024, 7:15 PM · User-TheDJ, Wikimedia-Hackathon-2024, MediaWiki-extensions-TitleKey
TheDJ added a comment to T355342: Update the sticky header FAQ.

You know... if we used wiki's instead of google docs... then half completed drafts would still be useful :)

Jul 15 2024, 6:40 PM · Web-Team-Backlog, Community Feedback (Web)

Jul 12 2024

TheDJ updated the task description for T340456: Tooltip: Add Tooltip component to Codex.
Jul 12 2024, 1:36 PM · Design-System-Team (Design-System-Product-Roadmap), Wikimedia-Hackathon-2024, Wikimedia-Design, Design, Codex
TheDJ closed T369659: Next and previous icons in MultimediaViewer are flipped in RTL interface as Resolved.
Jul 12 2024, 1:35 PM · MW-1.43-notes (1.43.0-wmf.14; 2024-07-16), Patch-For-Review, Regression, RTL, I18n, MediaViewer
TheDJ added a comment to T369659: Next and previous icons in MultimediaViewer are flipped in RTL interface.

This made me realise. Do users actually expect the left side is Next action and the right side is Previous ? Are we the exception to everything else or not ?

Jul 12 2024, 11:09 AM · MW-1.43-notes (1.43.0-wmf.14; 2024-07-16), Patch-For-Review, Regression, RTL, I18n, MediaViewer
TheDJ added a comment to T12347: Should protection status indicators be handled by MediaWiki core (vs. templates)?.

@Soda btw. should we perhaps set the default for WMF to false, and then flip the default for MW core to true ? I think it is good to have features like this enabled by default for new installs, otherwise most MW installs will never use them.

Jul 12 2024, 8:22 AM · MediaWiki-Page-protection, User-notice, MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), MediaWiki-Engineering, Design, Vector (legacy skin), Desktop Improvements (Vector 2022), Community-Wishlist-Survey-2016, JavaScript, MediaWiki-User-Interface

Jul 10 2024

TheDJ added a comment to T369659: Next and previous icons in MultimediaViewer are flipped in RTL interface.

So I imagine one of the following solutions,

  • To not use ::after for icons themselves and partially revert the mentioned change (more plausible solution I guess)
  • Add a dir attribute to next and previous icons (and stripe and dialog icons also apparently) so the first line of the CSS can match them at least
  • Apply the following that only fixes it for next and previous icons,
Jul 10 2024, 9:23 AM · MW-1.43-notes (1.43.0-wmf.14; 2024-07-16), Patch-For-Review, Regression, RTL, I18n, MediaViewer
TheDJ added a comment to T369659: Next and previous icons in MultimediaViewer are flipped in RTL interface.

I think I have some time this weekend to fix it.

Jul 10 2024, 8:10 AM · MW-1.43-notes (1.43.0-wmf.14; 2024-07-16), Patch-For-Review, Regression, I18n, RTL, MediaViewer

Jul 8 2024

TheDJ added a comment to T367831: Frameless images are not responsive.

Looked into the table/flex problem a bit.

Jul 8 2024, 9:36 PM · Web-Team-Backlog
TheDJ added a project to T369475: Make ul and ol margin values direction aware: Web-Team-Backlog.

Tagging web team for visibility. I personally think this is worth it (with fallback margins). I'd actually would very much like to use more of the logical properties, but 97% is I think just a tad too large a group of users to rely on it solely without fallback to commit to it. Especially the fact that Safari only started fully supporting in Safari 15, is problematic, as we have plenty of users with 6 - 7 year old iPads and iPhones.

Jul 8 2024, 2:56 PM · MW-1.43-notes (1.43.0-wmf.18; 2024-08-13), Verified, User-notice, Unplanned-Sprint-Work, Web-Team-Backlog (FY2024-25 Q1 Sprint 2), MediaWiki-Platform-Team (Radar), CSSJanus, MediaWiki-General, I18n, CSS

Jul 6 2024

TheDJ added a comment to T367645: The background of some SVG maps is not rendered.

That is amazing work @Nux, thank you so much!

Jul 6 2024, 10:05 PM · Wikimedia-SVG-rendering
Yann awarded T369388: Upload errors due to swift failures, 503s a Like token.
Jul 6 2024, 1:16 AM · Data-Persistence, MediaWiki-Uploading, SRE-swift-storage

Jul 5 2024

TheDJ added a comment to T360844: Links in elements with background color should become black so they are accessible.

@Jdlrobson This override also breaks quite a few infobox and navboxes, because for those we reset the background to black. so you get black on black. Perhaps these overrides need to be limited to wikitables ?

Jul 5 2024, 8:14 PM · Wikimedia-Hackathon-2024, FY2023-24-WE 2.1 Typography and palette customizations, Local-Wiki-Template-And-Gadget-Issues