Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Page MenuHomePhabricator

cscott (C. Scott Ananian)
Parser whisperer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 21 2014, 6:47 PM (514 w, 3 d)
Availability
Available
IRC Nick
cscott
LDAP User
Unknown
MediaWiki User
Cscott [ Global Accounts ]

Editor since 2005; WMF developer since 2013. I work on Parsoid and OCG, and dabble with VE, real-time collaboration, and OOjs.

On github: https://github.com/cscott

See https://en.wikipedia.org/wiki/User:cscott for more.

Recent Activity

Yesterday

cscott created T373719: Use MessageSerializationTestTrait to test Message serialization.
Fri, Aug 30, 9:45 PM · MW-1.43-notes (1.43.0-wmf.21; 2024-09-03), Patch-For-Review, MediaWiki-General, MediaWiki-Internationalization

Thu, Aug 29

cscott renamed T373229: Deploy to next set of wikivoyages (week of Sep 1) from Deploy to next set of wikivoyages to Deploy to next set of wikivoyages (week of Sep 1).
Thu, Aug 29, 9:47 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Content-Transform-Team-WIP
cscott added a subtask for T371640: [EPIC] Deploy Parsoid Read Views for all Wikivoyage wikis: T373229: Deploy to next set of wikivoyages (week of Sep 1).
Thu, Aug 29, 9:44 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Epic, Content-Transform-Team-WIP, OKR-Work
cscott added a parent task for T373229: Deploy to next set of wikivoyages (week of Sep 1): T371640: [EPIC] Deploy Parsoid Read Views for all Wikivoyage wikis.
Thu, Aug 29, 9:44 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Content-Transform-Team-WIP
cscott updated the task description for T372810: Deploy Parsoid Read Views to eo/sv/fi wikivoyages.
Thu, Aug 29, 9:43 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
cscott updated the task description for T372810: Deploy Parsoid Read Views to eo/sv/fi wikivoyages.
Thu, Aug 29, 9:43 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
cscott updated the task description for T372810: Deploy Parsoid Read Views to eo/sv/fi wikivoyages.
Thu, Aug 29, 9:40 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
cscott updated the task description for T371640: [EPIC] Deploy Parsoid Read Views for all Wikivoyage wikis.
Thu, Aug 29, 9:29 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Epic, Content-Transform-Team-WIP, OKR-Work
cscott updated the task description for T371640: [EPIC] Deploy Parsoid Read Views for all Wikivoyage wikis.
Thu, Aug 29, 9:29 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Epic, Content-Transform-Team-WIP, OKR-Work
cscott closed T365367: [EPIC] Deploy Parsoid Read Views for English Wikivoyage and Hebrew Wikivoyage as Resolved.
Thu, Aug 29, 9:25 PM · Epic, OKR-Work, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
cscott updated the task description for T372810: Deploy Parsoid Read Views to eo/sv/fi wikivoyages.
Thu, Aug 29, 9:25 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
cscott closed T365367: [EPIC] Deploy Parsoid Read Views for English Wikivoyage and Hebrew Wikivoyage, a subtask of T371640: [EPIC] Deploy Parsoid Read Views for all Wikivoyage wikis, as Resolved.
Thu, Aug 29, 9:24 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Epic, Content-Transform-Team-WIP, OKR-Work
cscott added a comment to T351953: "RuntimeException: PCRE failure" displaying oldest revisions on eowiki.

Updated the https://gerrit.wikimedia.org/r/c/mediawiki/core/+/981354 patch, if that is merged we could turn on validation on enwikibooks and eowiki. Folks who add logstash traces, if you could add the wiki prefix which shows the error that would be helpful.

Thu, Aug 29, 9:10 PM · MediaWiki-Parser, User-brennen, Patch-For-Review, Essential-Work, Content-Transform-Team, Wikimedia-production-error, Wikimedia-database-issue (Bad data)
cscott closed T371353: Deploy Parsoid Read Views for cs/ro wikivoyage as Resolved.
Thu, Aug 29, 4:57 PM · OKR-Work, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
cscott renamed T371353: Deploy Parsoid Read Views for cs/ro wikivoyage from Deploy Parsoid Read Views for cs, ro, tr, hi, shn, ps wikivoyage to Deploy Parsoid Read Views for cs/ro wikivoyage.
Thu, Aug 29, 4:56 PM · OKR-Work, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
cscott added a subtask for T371640: [EPIC] Deploy Parsoid Read Views for all Wikivoyage wikis: T372810: Deploy Parsoid Read Views to eo/sv/fi wikivoyages.
Thu, Aug 29, 4:55 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Epic, Content-Transform-Team-WIP, OKR-Work
cscott added a parent task for T372810: Deploy Parsoid Read Views to eo/sv/fi wikivoyages: T371640: [EPIC] Deploy Parsoid Read Views for all Wikivoyage wikis.
Thu, Aug 29, 4:55 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
cscott closed T371353: Deploy Parsoid Read Views for cs/ro wikivoyage, a subtask of T371640: [EPIC] Deploy Parsoid Read Views for all Wikivoyage wikis, as Resolved.
Thu, Aug 29, 4:55 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Epic, Content-Transform-Team-WIP, OKR-Work
cscott updated the task description for T372810: Deploy Parsoid Read Views to eo/sv/fi wikivoyages.
Thu, Aug 29, 4:53 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
cscott renamed T373229: Deploy to next set of wikivoyages (week of Sep 1) from Roll-out el, sv, fi, and vi wikivoyages to Deploy to next set of wikivoyages.
Thu, Aug 29, 4:50 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Content-Transform-Team-WIP
cscott renamed T372810: Deploy Parsoid Read Views to eo/sv/fi wikivoyages from Roll out ja, eo, uk, bn, and ro wikivoyages to Deploy Parsoid Read Views to eo/sv/fi wikivoyages.
Thu, Aug 29, 4:48 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
cscott added a comment to T324431: Parsoid: displaytitle HTML now appearing in <title> element rather than page title.

I can't find the code in Parsoid which actually sets the title element (!). It was originally thought that the title element would be a good way to convey the title metadata, but as @Legoktm points out there's some additional sanitization which happens with the value on its way to title which complicates this. This isn't really an issue for 'modern' parsoid since we communicate the title via ParserOutput/ContentMetadataCollector metadata, not the title element. The actual page title (as opposed to displaytitle) is passed in a <meta> element in the head. Perhaps we should be passing displaytitle that way as well.

Thu, Aug 29, 2:31 PM · Content-Transform-Team, affects-Kiwix-and-openZIM, Parsoid
cscott claimed T324431: Parsoid: displaytitle HTML now appearing in <title> element rather than page title.
Thu, Aug 29, 2:30 PM · Content-Transform-Team, affects-Kiwix-and-openZIM, Parsoid
cscott added a comment to T342491: REST `/page/html/` API endpoint does not follow redirects as documented & demoed.

The RESTBASE API has been deprecated, please use https://api.wikimedia.org/wiki/Core_REST_API/Reference/Pages/Get_HTML

Thu, Aug 29, 2:18 PM · RESTBase Sunsetting, Parsoid, RESTBase-API
cscott added a comment to T372716: [BUG]: Football (soccer) kits are blank.

An example: https://en.wikipedia.org/wiki/Liverpool_F.C.

Thu, Aug 29, 2:14 PM · Page Content Service, dark-mode, Content-Transform-Team, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog
cscott claimed T373400: Bug in HandleParsoidSectionLinks - seems to skip some headings?.
Thu, Aug 29, 2:06 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Parsoid

Wed, Aug 28

cscott added a comment to T373480: Display categories in sorted order by default.

Latest version of the patch makes it a configuration option, $wgSortedCategories, which is false by default. It adds a query parameter &sortcat=1 which will sort the categories, which will facilitate the Content-Transform-Team's visualdiff testing by ensuring that differences in category order don't obscure other page differences.

Wed, Aug 28, 5:03 PM · MediaWiki-User-Interface, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, MW-1.43-notes (1.43.0-wmf.21; 2024-09-03), User-notice, Parsoid

Tue, Aug 27

cscott closed T371536: Purge ParserCache to mitigate RelatedArticles bug as Resolved.

It's been almost 30 days already. I don't think we're going to do this, we're just going to wait for the pages to expire.

Tue, Aug 27, 11:08 PM · Content-Transform-Team-WIP, Parsoid-Read-Views
cscott merged T373494: After edit, VisualEdit rerenders the article without Parsoid read views into T373212: Legacy parser rendering showing after VE edit on wikis where Parsoid read-views are deployed (still with the "rendered with Parsoid" tag).
Tue, Aug 27, 11:06 PM · MW-1.43-notes (1.43.0-wmf.21; 2024-09-03), Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
cscott merged task T373494: After edit, VisualEdit rerenders the article without Parsoid read views into T373212: Legacy parser rendering showing after VE edit on wikis where Parsoid read-views are deployed (still with the "rendered with Parsoid" tag).
Tue, Aug 27, 11:06 PM · Parsoid-Read-Views, VisualEditor, Parsoid, Content-Transform-Team-WIP
cscott added a comment to T373212: Legacy parser rendering showing after VE edit on wikis where Parsoid read-views are deployed (still with the "rendered with Parsoid" tag).

I think what's going on is that VE is reloading the content area w/o doing a full reload of the page, and VE isn't using the ArticleParserOptions hook appropriately to get the proper 'useParsoid' status.

Tue, Aug 27, 11:05 PM · MW-1.43-notes (1.43.0-wmf.21; 2024-09-03), Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
cscott closed T356024: TypeError: Argument 4 passed to Wikimedia\Parsoid\Utils\Title::__construct() must be of the type string, null given, called in /srv/mediawiki/php-1.42.0-wmf.15/vendor/wikimedia/parsoid/src/Utils/Title.php on line 392 as Resolved.
Tue, Aug 27, 10:55 PM · MW-1.42-notes (1.42.0-wmf.17; 2024-02-06), Patch-For-Review, Essential-Work, serviceops, Wikimedia-production-error
cscott created T373494: After edit, VisualEdit rerenders the article without Parsoid read views.
Tue, Aug 27, 10:52 PM · Parsoid-Read-Views, VisualEditor, Parsoid, Content-Transform-Team-WIP
cscott created T373480: Display categories in sorted order by default.
Tue, Aug 27, 7:51 PM · MediaWiki-User-Interface, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, MW-1.43-notes (1.43.0-wmf.21; 2024-09-03), User-notice, Parsoid
cscott added a comment to T268144: Add setFunctionHook equivalent support to Parsoid Extension API.

Also related:

Tue, Aug 27, 6:37 PM · Patch-Needs-Improvement, Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), Parsoid
cscott added a comment to T373252: Ensure Parsoid can issue batch precompute requests for external services like wikifunctions.

We also need to determine "how much processing" is done on the /arguments/ to the wikifunction invocation before this preflight request is done. Obviously we can fire it off fastest if the arguments are just raw strings extracted from wikitext. But if we need to do wikitext expansion on the arguments, that might slow down the preflight.

Tue, Aug 27, 6:34 PM · Content-Transform-Team, Wikifunctions, Parsoid
cscott added a comment to T373256: Define ParserCache strategy for pages with content placeholder slots (as with wikifunctions).

The MVP default would be "don't cache", which already has support in core (ParserOutput::setCacheTime(-1)).

Tue, Aug 27, 6:32 PM · Content-Transform-Team, Parsoid, Wikifunctions
cscott added a comment to T363484: Update ParserMigration notice.

Current status: this task is not considered a blocker for our current rollouts on wikivoyage, which are relatively small wikis, but we plan to schedule more work on this task before we proceed to rollouts on larger wikis. Child task T365371: ParserMigration: Add "report visual bug" link is the major remaining task here. The indicator is still very useful to our team for debugging purposes, but T372789: Compact Parsoid indicator for ParserMigration for wikivoyage is prototyping a more compact form more suited for our current deployments on wikivoyage, and I've filed T373472: Make ParserMigration indicator optional to hide it entirely for most users.

Tue, Aug 27, 5:57 PM · OKR-Work, Parsoid-Read-Views (Phase 1 - DiscussionTools support), MW-1.43-notes (1.43.0-wmf.6; 2024-05-21), Content-Transform-Team-WIP, MediaWiki-extensions-ParserMigration
cscott created T373472: Make ParserMigration indicator optional.
Tue, Aug 27, 5:56 PM · Patch-For-Review, OKR-Work, Parsoid-Read-Views (Phase 1 - DiscussionTools support), MW-1.43-notes (1.43.0-wmf.6; 2024-05-21), Content-Transform-Team-WIP, MediaWiki-extensions-ParserMigration, Parsoid
cscott added a comment to T363484: Update ParserMigration notice.

See also T372789: Compact Parsoid indicator for ParserMigration for wikivoyage where we are prototyping a more compact indicator for wikivoyage.

Tue, Aug 27, 5:48 PM · OKR-Work, Parsoid-Read-Views (Phase 1 - DiscussionTools support), MW-1.43-notes (1.43.0-wmf.6; 2024-05-21), Content-Transform-Team-WIP, MediaWiki-extensions-ParserMigration
cscott added a comment to T373257: Pick wikitext syntax for wikifunction calls.

I think the initial proposal from wikifuntions was {{#function|...}} but I don't know what the arguments are.

Tue, Aug 27, 5:01 PM · Content-Transform-Team, Parsoid, Wikifunctions
cscott added a comment to T373255: Define the wikifunctions API that Parsoid needs.

I was going to propose that the API was a hook, so the "request and response format" is just the method parameters and return value for hook.

Tue, Aug 27, 4:59 PM · Content-Transform-Team, Wikifunctions, Parsoid
cscott claimed T371125: When using Parsoid rendering, DiscussionTools "empty state" appears on all talk pages.
Tue, Aug 27, 2:46 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), Content-Transform-Team-WIP, DiscussionTools
cscott added a comment to T373400: Bug in HandleParsoidSectionLinks - seems to skip some headings?.

Section links match by the ID from the TOCData, I bet parsoid's TOCData got confused. You should be able to check this by asking for the section info using the parse API.

Tue, Aug 27, 1:39 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Parsoid
cscott added a comment to T373405: `isParsoidContent` is not set causing parsoid-specific output transform stages to be skipped for Parsoid Read Views.

Patch has been merged and beta is verified fixed.

Tue, Aug 27, 12:53 AM · MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Patch-For-Review, Parsoid, Parsoid-Read-Views
cscott updated the task description for T373405: `isParsoidContent` is not set causing parsoid-specific output transform stages to be skipped for Parsoid Read Views.
Tue, Aug 27, 12:12 AM · MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Patch-For-Review, Parsoid, Parsoid-Read-Views
cscott updated the task description for T373405: `isParsoidContent` is not set causing parsoid-specific output transform stages to be skipped for Parsoid Read Views.
Tue, Aug 27, 12:09 AM · MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Patch-For-Review, Parsoid, Parsoid-Read-Views

Mon, Aug 26

cscott added a parent task for T373405: `isParsoidContent` is not set causing parsoid-specific output transform stages to be skipped for Parsoid Read Views: T373407: Write selenium test to ensure that Parsoid Read Views isn't totally broken.
Mon, Aug 26, 11:56 PM · MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Patch-For-Review, Parsoid, Parsoid-Read-Views
cscott added a subtask for T373407: Write selenium test to ensure that Parsoid Read Views isn't totally broken: T373405: `isParsoidContent` is not set causing parsoid-specific output transform stages to be skipped for Parsoid Read Views.
Mon, Aug 26, 11:56 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Essential-Work, Parsoid, MediaWiki-extensions-ParserMigration
cscott created T373407: Write selenium test to ensure that Parsoid Read Views isn't totally broken.
Mon, Aug 26, 11:56 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Essential-Work, Parsoid, MediaWiki-extensions-ParserMigration
cscott added a subtask for T366965: 1.43.0-wmf.20 deployment blockers: T373405: `isParsoidContent` is not set causing parsoid-specific output transform stages to be skipped for Parsoid Read Views.
Mon, Aug 26, 11:43 PM · Release-Engineering-Team (Priority Backlog 📥), Release, Train Deployments
cscott added a parent task for T373405: `isParsoidContent` is not set causing parsoid-specific output transform stages to be skipped for Parsoid Read Views: T366965: 1.43.0-wmf.20 deployment blockers.
Mon, Aug 26, 11:43 PM · MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Patch-For-Review, Parsoid, Parsoid-Read-Views
cscott created T373405: `isParsoidContent` is not set causing parsoid-specific output transform stages to be skipped for Parsoid Read Views.
Mon, Aug 26, 11:42 PM · MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Patch-For-Review, Parsoid, Parsoid-Read-Views
cscott created T373385: Parsoid doesn't generate the broken-file-category tracking category.
Mon, Aug 26, 6:54 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Parsoid
cscott created T373384: Parsoid doesn't properly handle double-underscore magic words.
Mon, Aug 26, 6:52 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Parsoid
cscott created T373383: Parsoid doesn't generate tracking categories for the use of magic words (ISBN, RFC, PMID).
Mon, Aug 26, 6:48 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Parsoid
cscott added a comment to T373374: Interwiki links with translation tags and multiple colons seem broken in Parsoid.

I can reproduce on my local wiki, when I have the translate extension installed:

$ echo '<translate>[[mw:Extension:Foo|Bar]]</translate>' | php maintenance/run.php parse.php --parsoid
parse.php: warning: reading wikitext from STDIN. Press CTRL+D to parse.
Mon, Aug 26, 5:32 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Parsoid
cscott added a comment to T373374: Interwiki links with translation tags and multiple colons seem broken in Parsoid.

Test page: https://meta.wikimedia.org/wiki/User:Cscott/T373374

Mon, Aug 26, 5:21 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Parsoid
cscott moved T364830: Parsoid should render empty references list the same as default parser from Code Review to In Progress on the Content-Transform-Team-WIP board.
Mon, Aug 26, 3:21 PM · OKR-Work, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Patch-For-Review, Content-Transform-Team-WIP, Parsoid (Tracking), Cite
cscott moved T368722: Missing edit-source button rendered in parsoid read views (from visualdiff testing) from Code Review to In Progress on the Content-Transform-Team-WIP board.
Mon, Aug 26, 3:21 PM · OKR-Work, Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Patch-For-Review, Parsoid
cscott claimed T368722: Missing edit-source button rendered in parsoid read views (from visualdiff testing).
Mon, Aug 26, 3:20 PM · OKR-Work, Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Patch-For-Review, Parsoid
cscott claimed T364830: Parsoid should render empty references list the same as default parser.
Mon, Aug 26, 3:19 PM · OKR-Work, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Patch-For-Review, Content-Transform-Team-WIP, Parsoid (Tracking), Cite
cscott moved T372592: Find a way to replace the use of ParserOutput::addJsConfigVars() in DiscussionTools from Backlog to In Progress on the Content-Transform-Team-WIP board.
Mon, Aug 26, 3:14 PM · Essential-Work, Content-Transform-Team-WIP, Parsoid, DiscussionTools

Fri, Aug 23

cscott added a comment to T371713: Instrumentation & data gathering to inform future performance & templating improvements.

Hm. The page_touched property of pages doesn't quite do what we need it to. Consider a page [[Foo]] which contains:

{{1x|{{Bar}}}}

Now, Foo's backlinks contain Template:1x and Template:Bar, and if either of them is edited, [[Foo]]'s page_touched will be bumped as well.

Fri, Aug 23, 11:45 PM · MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), OKR-Work, Patch-For-Review, MediaWiki-Parser, Content-Transform-Team-WIP
cscott added a comment to T371713: Instrumentation & data gathering to inform future performance & templating improvements.

In initial exploration, it was discovered to be quite difficult to plumb through precise reasons for each update (eg, "update to section X of revision Y of page Z" or "update because of an update template A included by template B included by page C").

Fri, Aug 23, 8:31 PM · MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), OKR-Work, Patch-For-Review, MediaWiki-Parser, Content-Transform-Team-WIP
cscott added a comment to T373212: Legacy parser rendering showing after VE edit on wikis where Parsoid read-views are deployed (still with the "rendered with Parsoid" tag).

Maybe related, maybe not: when I log in to a new wiki I'm not always seeing my preferences (including the "rendered with Parsoid") applied. The thing I notice most is user interface language, which often is still in the wiki's content language. I have to manually reload to get a render with English as the interface language (which is a global preference).

Fri, Aug 23, 5:50 PM · MW-1.43-notes (1.43.0-wmf.21; 2024-09-03), Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
cscott added a comment to T372889: CSS issue in a navbox on jawikivoyage (causes visual diffs on a number of pages).

A counterargument to "fixing this in code" is that the stylesheet in question applies to a bunch of different hlists, some of which *will* be generated from wikitext.

Fri, Aug 23, 2:51 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Patch-For-Review, Content-Transform-Team-WIP
cscott added a comment to T372889: CSS issue in a navbox on jawikivoyage (causes visual diffs on a number of pages).

(Also as a matter of timing, adjusting the site CSS to fix the line breaks can be done immediately as an edit and doesn't require a code change + deploy, etc. Counterargument for that is that we're concerned that this same pattern might exist on other wikis, and we don't want to have to deal with editing the CSS in a dozen places.)

Fri, Aug 23, 2:37 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Patch-For-Review, Content-Transform-Team-WIP
cscott added a comment to T372889: CSS issue in a navbox on jawikivoyage (causes visual diffs on a number of pages).

I'm feeling kind of puzzled here. What's the reticence to adjusting the output in ParsoidCite to add \ns in reasonable places? As I noted, normal wikitext lists work as expected before and after, as does (obviously) Cite before. ParsoidCite's output is also pretty fully in your power to adjust, rather than having a bunch of edge cases like wikitext does.

Fri, Aug 23, 2:36 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Patch-For-Review, Content-Transform-Team-WIP

Thu, Aug 22

cscott added a comment to T372889: CSS issue in a navbox on jawikivoyage (causes visual diffs on a number of pages).

@lzno which side of the <li> do you want the pipe to stick to? Just make the content: ... clause include a &nbsp; on the side where you don't want a break.

Thu, Aug 22, 10:32 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Patch-For-Review, Content-Transform-Team-WIP
cscott updated the task description for T371353: Deploy Parsoid Read Views for cs/ro wikivoyage.
Thu, Aug 22, 10:01 PM · OKR-Work, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
cscott updated the task description for T371353: Deploy Parsoid Read Views for cs/ro wikivoyage.
Thu, Aug 22, 9:58 PM · OKR-Work, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
cscott added a comment to T371327: Notify enwikivoyage and hewikivoyage of the upcoming rollout of Parsoid Read Views.

Another note for the future: https://meta.wikimedia.org/wiki/Global_message_delivery/Targets#Global_delivery_lists points to the various village pumps.
https://meta.wikimedia.org/wiki/Distribution_list/Global_message_delivery#Wikivoyage especially will probably be useful.

Thu, Aug 22, 9:41 PM · OKR-Work, Parsoid-Read-Views, Content-Transform-Team-WIP
cscott renamed T371353: Deploy Parsoid Read Views for cs/ro wikivoyage from Deploy Parsoid Read Views for cs, tr, hi, shn, ps wikivoyage to Deploy Parsoid Read Views for cs, ro, tr, hi, shn, ps wikivoyage.
Thu, Aug 22, 9:36 PM · OKR-Work, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
cscott updated the task description for T371353: Deploy Parsoid Read Views for cs/ro wikivoyage.
Thu, Aug 22, 9:32 PM · OKR-Work, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
cscott updated the task description for T371353: Deploy Parsoid Read Views for cs/ro wikivoyage.
Thu, Aug 22, 9:23 PM · OKR-Work, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
cscott renamed T371353: Deploy Parsoid Read Views for cs/ro wikivoyage from Turn of Parsoid Read Views for cs, hi, shn, ps wikivoyage to Deploy Parsoid Read Views for cs, hi, shn, ps wikivoyage.
Thu, Aug 22, 9:20 PM · OKR-Work, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
cscott updated the task description for T371353: Deploy Parsoid Read Views for cs/ro wikivoyage.
Thu, Aug 22, 9:17 PM · OKR-Work, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
cscott renamed T371353: Deploy Parsoid Read Views for cs/ro wikivoyage from Turn on Parsoid Read Views for cs, hi, shn, ps wikivoyage to Turn of Parsoid Read Views for cs, hi, shn, ps wikivoyage.
Thu, Aug 22, 9:16 PM · OKR-Work, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
cscott renamed T371353: Deploy Parsoid Read Views for cs/ro wikivoyage from Notify cs, hi, shn, ps, and tr wikivoyages about upcoming Parsoid Read Views roll-out to Turn of Parsoid Read Views for cs, hi, shn, ps wikivoyage.
Thu, Aug 22, 9:02 PM · OKR-Work, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
cscott merged T371271: Run visualdiff on cs, hi, shn, ps, and tr in Wikivoyage into T371353: Deploy Parsoid Read Views for cs/ro wikivoyage.
Thu, Aug 22, 8:58 PM · OKR-Work, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
cscott merged task T371271: Run visualdiff on cs, hi, shn, ps, and tr in Wikivoyage into T371353: Deploy Parsoid Read Views for cs/ro wikivoyage.
Thu, Aug 22, 8:57 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), OKR-Work, Content-Transform-Team-WIP
cscott added a comment to T372889: CSS issue in a navbox on jawikivoyage (causes visual diffs on a number of pages).

This can be fixed in the CSS like this:

.mw-parser-output .hlist-pipe dd::after, .mw-parser-output .hlist-pipe li::after {
  content: " | ";
  font-weight: normal;
  white-space: break-spaces;
}

See the added white-space rule there, which ensures that the list items can be broken at the separators between them.

Thu, Aug 22, 2:54 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Patch-For-Review, Content-Transform-Team-WIP
cscott added a comment to T372062: Infobox title with apostrophe has erroneous line break..

This seems to be a CSS styling issue, and not a Parsoid/PCS bug. The root cause is this CSS rule:

.content .infobox > caption, .content .infobox > tbody {
  display: flex;
  flex-flow: column nowrap;
}

The flex layout has special handling for the children of the parent container (in this case the <caption>) but there are no children of the caption. Instead, any <span> or other tags, like <b> or <i>, are treated as the children and given a flex box layout inside of the caption.

Thu, Aug 22, 2:49 PM · Essential-Work, Page Content Service, Wikipedia-Android-App-Backlog
cscott added a comment to T372062: Infobox title with apostrophe has erroneous line break..

The problem doesn't exist on https://en.wikipedia.org/api/rest_v1/page/html/I'm_Glad_My_Mom_Died and the underlying HTML from Parsoid is:

I<span typeof="mw:Entity">'</span>m Glad My Mom Died <span class="Z3988" title="ctx_ver=Z39.88-2004&amp;rft_val_fmt=info%3Aofi%2Ffmt%3Akev%3Amtx%3Abook&amp;rft.genre=book&amp;rft.btitle=&amp;rft.author=%5B%5BJennette+McCurdy%5D%5D&amp;rft.date=August+9%2C+2022&amp;rft.pub=%5B%5BSimon+%26+Schuster%5D%5D&amp;rft.pages=320"></span>

So it appears to be related to how PCS is handling the <span typeof="mw:Entity">?

Thu, Aug 22, 2:33 PM · Essential-Work, Page Content Service, Wikipedia-Android-App-Backlog

Wed, Aug 21

cscott updated subscribers of T372789: Compact Parsoid indicator for ParserMigration for wikivoyage.

I believe @Arlolra is using "old" Vector, which shows this appearance. I tested with "new" Vector, which does not.

Wed, Aug 21, 6:25 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), Parsoid, Patch-For-Review, MediaWiki-extensions-ParserMigration, Content-Transform-Team-WIP
cscott created T373047: Add `title.content` alias for `Title::getContent()` in Scribunto.
Wed, Aug 21, 5:32 PM · MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Patch-For-Review, Scribunto
cscott added a comment to T372935: Parsoid doesn't recognize valid image options on eowikivoyage and lints them as bogus options.

Some more information:

> $services = \MediaWiki\MediaWikiServices::getInstance();
> $l = $services->getLanguageFactory()->getLanguage('eo');
> $mwf = new \MediaWiki\Parser\MagicWordFactory($l, $services->getHookContainer());
> $x = $mwf->newArray(['img_left','img_width']);
> $x->getBaseRegex();
= [
    "(?i:(?!))",
    "(?P<a_img_left>maldekstra)|(?P<b_img_left>maldekstre)|(?P<c_img_left>left)|(?P<a_img_width>\$1ra)|(?P<b_img_width>\$1px)",
  ]
> $x->matchVariableStartToEnd('maldekstra');
= [
    "img_left",
    false,
  ]
> $x = $mwf->newArray(['img_width','img_left']);
> $x->getBaseRegex();
= [
    "(?i:(?!))",
    "(?P<a_img_width>\$1ra)|(?P<b_img_width>\$1px)|(?P<a_img_left>maldekstra)|(?P<b_img_left>maldekstre)|(?P<c_img_left>left)",
  ]
> $x->matchVariableStartToEnd('maldekstra');
= [
    "img_width",
    "maldekst",
  ]

Note that the precedence of options is pretty much arbitrary, it just *happens* that img_width is added after other options. Parsoid is a bit more principled here, always preferring literal parameters to parameterized (prefix) parameters.

Wed, Aug 21, 3:54 PM · MW-1.43-notes (1.43.0-wmf.21; 2024-09-03), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Content-Transform-Team-WIP

Mon, Aug 19

cscott moved T372789: Compact Parsoid indicator for ParserMigration for wikivoyage from Backlog to Current Deploy Target on the Content-Transform-Team-WIP board.
Mon, Aug 19, 3:35 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), Parsoid, Patch-For-Review, MediaWiki-extensions-ParserMigration, Content-Transform-Team-WIP
cscott created T372789: Compact Parsoid indicator for ParserMigration for wikivoyage.
Mon, Aug 19, 3:32 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), Parsoid, Patch-For-Review, MediaWiki-extensions-ParserMigration, Content-Transform-Team-WIP
cscott added a comment to T372522: "Wikitext for this page has duplicate ids: fileinfotpl_creator_authority_value" in php-fpm stderr.

These should be a tracking category or a linter entry, not a log.

Mon, Aug 19, 3:23 PM · Essential-Work, Content-Transform-Team-WIP, Parsoid, Wikimedia-production-error
cscott closed T371327: Notify enwikivoyage and hewikivoyage of the upcoming rollout of Parsoid Read Views as Resolved.
Mon, Aug 19, 3:22 PM · OKR-Work, Parsoid-Read-Views, Content-Transform-Team-WIP
cscott claimed T329457: IP Masking Considerations: services/parsoid.
Mon, Aug 19, 3:19 PM · Essential-Work, Content-Transform-Team-WIP, Temporary accounts
cscott added a project to T372592: Find a way to replace the use of ParserOutput::addJsConfigVars() in DiscussionTools: Content-Transform-Team-WIP.
Mon, Aug 19, 3:15 PM · Essential-Work, Content-Transform-Team-WIP, Parsoid, DiscussionTools
cscott claimed T372592: Find a way to replace the use of ParserOutput::addJsConfigVars() in DiscussionTools.
Mon, Aug 19, 3:14 PM · Essential-Work, Content-Transform-Team-WIP, Parsoid, DiscussionTools
cscott added a project to T367074: Deprecate and remove ParsoidOutputAccess: MW-1.44-release.
Mon, Aug 19, 3:12 PM · MW-1.44-release, MW-1.43-notes (1.43.0-wmf.15; 2024-07-23), Parsoid, Essential-Work
cscott removed a project from T367074: Deprecate and remove ParsoidOutputAccess: Content-Transform-Team-WIP.
Mon, Aug 19, 3:12 PM · MW-1.44-release, MW-1.43-notes (1.43.0-wmf.15; 2024-07-23), Parsoid, Essential-Work
cscott moved T371745: [error/wt2html] TableFixups: Failed to successfully reparse {{fbu|20|SCO}}|| as table cell attributes from To Deploy to To Verify on the Content-Transform-Team-WIP board.
Mon, Aug 19, 3:09 PM · Patch-For-Review, Content-Transform-Team-WIP, Essential-Work, Parsoid, Wikimedia-production-error
cscott closed T362499: MediaWiki\Parser\Parsoid\Config\SiteConfig::namespaceId(): Argument #1 ($name) must be of type string as Resolved.
Mon, Aug 19, 3:09 PM · Essential-Work, Content-Transform-Team-WIP, Parsoid (Third-party), VisualEditor
cscott closed T358818: Check MassMessages for Linter errors before sending as Resolved.
Mon, Aug 19, 3:08 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Essential-Work, Content-Transform-Team-WIP, Editing-team, MassMessage, MediaWiki-extensions-Linter