Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Page MenuHomePhabricator

vvv (Victor Vasiliev)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 10 2014, 10:04 PM (525 w, 2 d)
Availability
Available
LDAP User
Victor Vasiliev
MediaWiki User
VasilievVV [ Global Accounts ]

Recent Activity

Oct 8 2019

Daimona awarded T156095: Re-enable AbuseFilterCachingParser once we are sure it's safe a Mountain of Wealth token.
Oct 8 2019, 4:42 PM · User-notice-archive, Wikimedia-Performance-publish, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Performance-Team, AbuseFilter

Oct 4 2019

Ladsgroup awarded T156095: Re-enable AbuseFilterCachingParser once we are sure it's safe a Like token.
Oct 4 2019, 10:44 AM · User-notice-archive, Wikimedia-Performance-publish, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Performance-Team, AbuseFilter

Sep 6 2019

Huji awarded T156095: Re-enable AbuseFilterCachingParser once we are sure it's safe a Love token.
Sep 6 2019, 3:22 PM · User-notice-archive, Wikimedia-Performance-publish, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Performance-Team, AbuseFilter

Jan 10 2019

Krinkle awarded T156096: Deprecate and then reject empty operators a Orange Medal token.
Jan 10 2019, 6:39 PM · User-notice-archive, MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), User-Daimona, AbuseFilter

Jan 24 2017

vvv created T156096: Deprecate and then reject empty operators.
Jan 24 2017, 5:00 AM · User-notice-archive, MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), User-Daimona, AbuseFilter
vvv added a subtask for T156095: Re-enable AbuseFilterCachingParser once we are sure it's safe: T153251: AbuseFilterCachingParser fails to parse filters with trailing comma in function calls (works in old parser).
Jan 24 2017, 4:54 AM · User-notice-archive, Wikimedia-Performance-publish, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Performance-Team, AbuseFilter
vvv added a parent task for T153251: AbuseFilterCachingParser fails to parse filters with trailing comma in function calls (works in old parser): T156095: Re-enable AbuseFilterCachingParser once we are sure it's safe.
Jan 24 2017, 4:54 AM · AbuseFilter
vvv created T156095: Re-enable AbuseFilterCachingParser once we are sure it's safe.
Jan 24 2017, 4:52 AM · User-notice-archive, Wikimedia-Performance-publish, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Performance-Team, AbuseFilter

Dec 18 2016

vvv added a comment to T153251: AbuseFilterCachingParser fails to parse filters with trailing comma in function calls (works in old parser).

Okay, the answer is simple and somewhat disturbing: the new parser just failed to parse the filter in question with the syntax error, so it presumably never got executed. I've expected this to fail more loudly than silently failing open, but I am not sure how the filter edit hooks actually handle this.

Dec 18 2016, 9:09 AM · AbuseFilter

Nov 10 2016

RandomDSdevel awarded T148673: Order of operations has changed in AbuseFilters a Haypence token.
Nov 10 2016, 12:48 AM · User-notice-archive, Patch-For-Review, AbuseFilter

Nov 7 2016

vvv added a comment to T148660: Stack overflow in AbuseFilter when using AbuseFilterCachingParser.

So, my current understanding is that the reason why we are hitting this is
(1) There is no recursion limit in the new parser (definitely a bug),
(2) Previously the tree for same operations were flat, meaning that the trees we now get are much deeper. I'd need to think how to work this fact around.

Nov 7 2016, 2:16 AM · AbuseFilter

Oct 20 2016

vvv added a comment to T148673: Order of operations has changed in AbuseFilters.

The specific change which happened, as far as I understand it, is that the precedence remained the same, but apparently the new parser treats boolean operators as right-associative, whereas it used to treat them as left-associative. This is an oversight on my part. I will write a patch to fix that and add tests.

Oct 20 2016, 5:06 AM · User-notice-archive, Patch-For-Review, AbuseFilter

Sep 4 2016

vvv added a comment to T144599: New "engineer" usergroup for ruwiki.

What I meant is the traditional power structure of Wikimedia projects ask bureaucrats are the ones to grant sensible rights. Independantly with their sysop status, they are also used to grant sensible rights,

Sep 4 2016, 12:59 AM · Russian-Sites, MW-1.28-release (WMF-deploy-2016-10-11_(1.28.0-wmf.22)), User-Nikerabbit, Patch-For-Review, Wikimedia-Site-requests
vvv added a comment to T144599: New "engineer" usergroup for ruwiki.

No, they're not different. They all have the same purpose: unbundling from
the sysops the privs to edit css and js site files and other things. That
the permissions are a bit different across the sites is nothing new and it
happens with some non standard groups such as patrollers, rollbackers, etc.

Sep 4 2016, 12:50 AM · Russian-Sites, MW-1.28-release (WMF-deploy-2016-10-11_(1.28.0-wmf.22)), User-Nikerabbit, Patch-For-Review, Wikimedia-Site-requests

Sep 3 2016

vvv added a comment to T144599: New "engineer" usergroup for ruwiki.

So, there seems to be a security concern expressed here about allowing sysops to delegate editinterface permission. However, the more I think about it, the more unconvinced I become that there is any actual difference between the existing situation and the proposed one. Could someone elaborate what the suggested threat model is?

Sep 3 2016, 5:49 PM · Russian-Sites, MW-1.28-release (WMF-deploy-2016-10-11_(1.28.0-wmf.22)), User-Nikerabbit, Patch-For-Review, Wikimedia-Site-requests

Nov 2 2015

vvv placed T117471: Special:Contribs cuts last "0" in the username up for grabs.

Well, I clearly cannot reproduce it locally then. Unassigning myself from this.

Nov 2 2015, 8:44 PM · MediaWiki-Special-pages
vvv claimed T117471: Special:Contribs cuts last "0" in the username.

Will take a look.

Nov 2 2015, 8:39 PM · MediaWiki-Special-pages

Mar 13 2015

Ricordisamoa awarded T38939: User name blacklist should be managed globally to avoid SUL fragmentation a Yellow Medal token.
Mar 13 2015, 5:37 PM · User-notice-archive, Stewards-and-global-tools, Patch-For-Review, SUL-Finalization, TitleBlacklist, Wikimedia-Site-requests

Jan 7 2015

vvv added a comment to T16416: MergeAccount should assign never-been-used accounts to the global account.

I am fairly skeptical about the requested change. The situation for as long as I remember have been (and correct me if that changed) has been that the account usurpation policy is up to each individual project, and some projects never allowed usurpation under any circumstances. I am concerned that we might be possibly circumventing local policies with this decision.

Jan 7 2015, 8:43 AM · MediaWiki-extensions-CentralAuth

Dec 17 2014

Kozuch awarded T5525: Cross-wiki watchlists a Like token.
Dec 17 2014, 8:30 PM · Growth-Team-Filtering, Growth-Team, MediaWiki-CrossWikiWatchlist, Phlogiston-Category, Community-Wishlist-Survey-2015, MediaWiki-Watchlist, German-Community-Wishlist, Contributors-Team, Design, Epic, Crosswiki, MediaWiki-extensions-CentralAuth

Dec 12 2014

Nemo_bis awarded T5525: Cross-wiki watchlists a Like token.
Dec 12 2014, 8:02 AM · Growth-Team-Filtering, Growth-Team, MediaWiki-CrossWikiWatchlist, Phlogiston-Category, Community-Wishlist-Survey-2015, MediaWiki-Watchlist, German-Community-Wishlist, Contributors-Team, Design, Epic, Crosswiki, MediaWiki-extensions-CentralAuth

Dec 3 2014

waldyrious awarded T16416: MergeAccount should assign never-been-used accounts to the global account a Like token.
Dec 3 2014, 4:51 PM · MediaWiki-extensions-CentralAuth

Dec 2 2014

vvv added a comment to T63030: Migrate to Tool Labs: https://toolserver.org/~vvv/adminstats.php.

So, do I actually have to go and reimplement adminstats? I would be happy to do that, but I never wanted to duplicate effort.

Dec 2 2014, 12:48 PM · Tools

Nov 24 2014

He7d3r awarded T5525: Cross-wiki watchlists a Love token.
Nov 24 2014, 12:03 PM · Growth-Team-Filtering, Growth-Team, MediaWiki-CrossWikiWatchlist, Phlogiston-Category, Community-Wishlist-Survey-2015, MediaWiki-Watchlist, German-Community-Wishlist, Contributors-Team, Design, Epic, Crosswiki, MediaWiki-extensions-CentralAuth