Re: [HACKERS] btree_gin and btree_gist for enums

28.02.2017 00:22, Andrew Dunstan:
> OK, here's the whole series of patches.
>
> Patch 1 adds the CallerFInfoFunctionCall{1,2} functions.
>
> Patch 2 adds btree_gist support for their use for non-varlena types
>
> Patch 3 does the same for varlena types (Not required for patch 4, but
> better to be consistent, I think.)
>
> Patch 4 adds enum support to btree_gist
>
> Patch 5 adds enum support to btree_gin
>
> cheers
>
> andrew

Thank you for implementing the feature!
These patches seem to have some merge conflicts with recent commit:

commit c7a9fa399d557c6366222e90b35db31e45d25678
Author: Stephen Frost <sfrost@snowman.net>
Date:   Wed Mar 15 11:16:25 2017 -0400

     Add support for EUI-64 MAC addresses as macaddr8

And also, it's needed to update patch 0002 to consider macaddr8, I 
attached the diff.
Complete patch (including 0002_addition fix) rebased to the current 
master is attached as well.
It works as expected, code itself looks clear and well documented.

The only issue I've found is a make check failure in contrib/btree_gin 
subdirectory:

test numeric                  ... ok
test enum                     ... /bin/sh: 1: cannot open 
/home/anastasia/newprojects/original_repo/postgres/contrib/btree_gin/sql/enum.sql: 
No such file
diff: 
/home/anastasia/newprojects/original_repo/postgres/contrib/btree_gin/results/enum.out: 
No such file or directory
diff command failed with status 512: diff 
"/home/anastasia/newprojects/original_repo/postgres/contrib/btree_gin/expected/enum.out" 
"/home/anastasia/newprojects/original_repo/postgres/contrib/btree_gin/results/enum.out" 
 > 
"/home/anastasia/newprojects/original_repo/postgres/contrib/btree_gin/results/enum.out.diff"


Please, add regression test for btree_gin, and this patch can be 
considered "Ready for committer".

-- 
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers