Re: [PATCH] Timestamp for a XLOG_BACKUP_END WAL-record

On 10.07.2018 22:26, Fujii Masao wrote:
> On Tue, Jul 10, 2018 at 6:41 PM, Andrey V. Lepikhov
> <a.lepikhov@postgrespro.ru> wrote:
>>
>>
>> On 10.07.2018 06:45, Andres Freund wrote:
>>>
>>> Hi,
>>>
>>> On 2018-07-10 06:41:32 +0500, Andrey V. Lepikhov wrote:
>>>>
>>>> This functionality is needed in practice when we have to determine a
>>>> recovery time of specific backup.
>>>
>>>
>>> What do you mean by "recovery time of specific backup"?
>>>
>>
>> recovery time - is a time point where backup of PostgreSQL database instance
>> was made.
>> Performing database recovery, we want to know what point in time the
>> restored database will correspond to.
>> This functionality refers to improving the usability of pg_basebackup and
>> pg_probackup utilities.
> 
> Why don't you use a backup history file for that purpose?

Timestamp in a backup history file not correspond to any WAL record and 
can't be bind with a time of backup exactly.
In my opinion, keeping timestamp in XLOG_BACKUP_END is more reliable, 
safe and easy way for recovering a database to a specific time.

> 
> Regards,
> 

-- 
Andrey Lepikhov
Postgres Professional:
https://postgrespro.com
The Russian Postgres Company