Re: pg_upgrade check fails on Solaris 10

On 2019-09-18 17:36, Alvaro Herrera wrote:
> On 2019-Sep-17, Marina Polyakova wrote:
> 
>> Hello, hackers!
>> 
>> We got an error for pg_upgrade check on the branch REL_11_STABLE 
>> (commit
>> 40ad4202513c72f5c1beeb03e26dfbc8890770c0) on Solaris 10 because IIUC 
>> the
>> argument to the sed command is not enclosed in quotation marks (see 
>> [1]):
> 
> Hmm, I'm surprised it has taken this long to detect the problem.

Looking at the members of buildfarm [1] castoroides and protosciurus  - 
IIUC they do not check pg_upgrade. And I was that lucky one who have run 
the branch with the latest commits at our buildfarm...

>> Attached diff.patch fixes the problem.
> 
> I have pushed it to all branches that have src/bin/pg_upgrade (namely,
> 9.5 onwards), thanks.  I hope this won't make the msys/mingw machines
> angry ;-)

Thank you! I ran pg_upgrade tests for MSYS, everything is fine.

The branch REL9_4_STABLE (commit 
8a17afe84be6fefe76d0d2f4d26c5ee075e64487) has the same issue - according 
to the release table [2] it is still supported, isn't it?...

[1] https://buildfarm.postgresql.org/cgi-bin/show_members.pl
[2] https://www.postgresql.org/support/versioning/

-- 
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company