pgsql: Two fixes from Tom Lan.
От | ishii@postgresql.org (Tatsuo Ishii) |
---|---|
Тема | pgsql: Two fixes from Tom Lan. |
Дата | |
Msg-id | 20051204012243.69DFB9DCC3F@postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Log Message: ----------- Two fixes from Tom Lan. See the posting "[PATCHES] A couple of proposed pgbench changes" on 2005/11/29 for more details. The change at line 490 updates doCustom's local variable "commands" after selecting a new file (command sequence). I think that the existing coding will cause the thing to use the first command of the old sequence in the remainder of the routine, which would be a bug. I have not tried to set up a test case to prove it, though. The other two changes cause doCustom to loop after processing a meta-command. This might be a bit controversial, but as the code is currently written, each meta-command "costs" one cycle of the outer select() loop. Thus, for example, with the default TPC-B script, once a backend returns "COMMIT" it will not receive a new command until four cycles of issuing commands to other backends have elapsed. (You can see this very easily by strace'ing pgbench under load.) Tags: ---- REL8_1_STABLE Modified Files: -------------- pgsql/contrib/pgbench: pgbench.c (r1.45.2.2 -> r1.45.2.3) (http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/pgbench/pgbench.c.diff?r1=1.45.2.2&r2=1.45.2.3)
В списке pgsql-committers по дате отправления: