Re: pgadmin go down when I want to start debug pl pgsql function

Pavel Stěhule wrote:
> Dave Page píše v Po 13. 08. 2007 v 20:39 +0100:
>>> ------- Original Message -------
>>> From: Pavel Stěhule <pstehule@ilikethis.cz>
>>> To: pgAdmin Support <pgadmin-support@postgresql.org>
>>> Sent: 13/08/07, 19:36:26
>>> Subject: [pgadmin-support] pgadmin go down when I want to start debug plpgsql function
>>>
> platform fc7
>
> ===========================================================================
> on right click over function item
> ./src/gtk/menu.cpp(984): assert "IsCheckable()" failed in IsChecked():
> can't get state of uncheckable item!
> ASSERT INFO:
> ./src/gtk/menu.cpp(984): assert "IsCheckable()" failed in IsChecked():
> can't get state of uncheckable item!
>

I can't reproduce this on FC6 - I'm downloading F7 now, but it'll
probably be Monday before I get it installed and running.

The fix seems obvious though, assuming the problem is simply a new
assert in GTK - perhaps you could try the attached patch please?

Regards, Dave
Index: pgadmin/utils/factory.cpp
===================================================================
--- pgadmin/utils/factory.cpp    (revision 6569)
+++ pgadmin/utils/factory.cpp    (working copy)
@@ -317,7 +317,7 @@
                     if (!menuItem->IsSubMenu())
                     {
                         lastItem = treeContextMenu->Append(id, menuItem->GetLabel(), menuItem->GetHelp(),
menuItem->IsCheckable()? wxITEM_CHECK : wxITEM_NORMAL); 
-                        if (menuItem->IsChecked())
+                        if (menuItem->IsCheckable() && menuItem->IsChecked())
                             treeContextMenu->FindItem(id)->Check();
                     }
                     else