Re: odd output in initdb

On Sun, Jan 31, 2010 at 18:33, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> On Sun, Jan 31, 2010 at 17:56, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> I notice pgstat_send is still using "if (pgStatSock < 0)" to detect
>>> PGINVALID_SOCKET ...
>
>> That's certainly so, but that shouldn't have any effect on this -
>> since on that platform it's defined to -1 anyway. But I'll go ahead
>> and fix it :-)
>
> I was more worried about the other way around: could a *valid* handle
> be < 0?  Although it's still not clear why it'd only recently have
> started being a problem.

I don't think it can.

And no, I can't figure out why that should've changed recently because
of this, since we've checked against that before..

-- Magnus HaganderMe: http://www.hagander.net/Work: http://www.redpill-linpro.com/