Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Menu ▾ ▴

#58 Cleanup: use METH_NOARGS in _mysql_connections.c

MySQLdb
closed
Andy Dustman
MySQLdb (53)
5
2012-09-19
2009-02-04
Kyle VanderBeek
No

Use METH_NOARGS as this is now the "right way" in python C extensions. It allows us to avoid pointless calls to PyArg_ParseTuple.

Some minor trailing whitespace removed as well.

Discussion

  • Kyle VanderBeek

    Kyle VanderBeek - 2009-02-04
     
    MySQLdb-trunk-NOARGS-conn.patch

  • Andy Dustman

    Andy Dustman - 2009-02-04

    Do you know what is the minimum version of Python this is supported in?

    http://www.python.org/doc/2.5.2/api/common-structs.html

    It doesn't specifically say, unlike some other constants, but the implication is that it's older than Python 2.3, which is fine by me. I don't want to go out of my way to break MySQLdb on Python 2.3 but I'll do it if there's a good reason.

     

  • Kyle VanderBeek

    Kyle VanderBeek - 2009-02-07

    METH_NOARGS showed up way back in Python 2.2. Applied to trunk.

     

Log in to post a comment.