Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.29.0 #1249

Merged
merged 57 commits into from
Dec 11, 2021
Merged

0.29.0 #1249

merged 57 commits into from
Dec 11, 2021

Conversation

mattlewis92
Copy link
Owner

@mattlewis92 mattlewis92 commented May 3, 2020 •
edited
Loading

Hey folks! 👋

Here's the changelog for the upcoming 0.29.0 release, it contains a few nice features as well as a couple of very small and easy to workaround breaking changes that should hopefully only impact a small minority of people.

You can try it out by doing:

npm i angular-calendar@next

If you find any issues please let me know! 😄

Changelog

Bug Fixes

  • week-view: allow dragging events to span multiple days (ef5749c), closes #1234

Features

  • week-view: add hourDuration option (6a72448), closes #1080
  • week-view: add minimumEventHeight option (7789fda), closes #1192
  • week-view: allow customising where events can be dragged (cd12d3c), closes #1183
  • week-view: allow customising where events can be resized (ba45051), closes #1183
  • add support for rtl (caaf96c), closes #1203
  • drop support for angular 6 and 7 (bc15e03)

BREAKING CHANGES

  • angular 6, 7, 8, and 9 are no longer supported. To use this package you must upgrade to angular 10 or higher.
  • week-view: the drag behaviour now mimicks the resize behaviour where you can drag an event down to move it into the next day. To restore the old behaviour you can use the new validateEventTimesChanged input to control where an event can be dragged.
  • week-view: events on the week and day view will now always be at least 30 pixels high by default. To restore the old behaviour you can set [minimumEventHeight]="1".

martinsware and others added 3 commits May 3, 2020 15:49
@martinsware @mattlewis92
feat(week-view): add hourDuration option
6a72448 
Closes #1080
@mattlewis92
feat(week-view): add minimumEventHeight option
7789fda 
BREAKING CHANGE: events on the week and day view will now always be at least 30 pixels high by default. To restore the old behaviour you can set `[minimumEventHeight]="1"`.

Closes #1192
@mattlewis92
fix(week-view): allow dragging events to span multiple days
ef5749c 
BREAKING CHANGE: the drag behaviour now mimicks the resize behaviour where you can drag an event down to move it into the next day. To restore the old behaviour you can use the new `validateEventTimesChanged` input to control where an event can be dragged.

Closes #1234
@mattlewis92 mattlewis92 added this to the 0.29 milestone May 3, 2020
This was referenced May 3, 2020
Closed
Closed
Merged
@codecov-io
Copy link

Codecov Report

Merging #1249 into master will decrease coverage by 0.05%.
The diff coverage is 95.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1249      +/-   ##
==========================================
- Coverage   96.19%   96.13%   -0.06%     
==========================================
  Files          39       39              
  Lines         736      751      +15     
  Branches      121      128       +7     
==========================================
+ Hits          708      722      +14     
- Partials       28       29       +1
Impacted Files Coverage Δ
...rc/modules/common/calendar-drag-helper.provider.ts 91.66% <88.88%> (-8.34%) ⬇️
...ojects/angular-calendar/src/modules/common/util.ts 95.38% <100.00%> (+0.30%) ⬆️
...dar/src/modules/day/calendar-day-view.component.ts 100.00% <100.00%> (ø)
...alendar-week-view-current-time-marker.component.ts 95.65% <100.00%> (+0.41%) ⬆️
...r/src/modules/week/calendar-week-view.component.ts 95.13% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1e2831...ef5749c. Read the comment docs.

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020 •
edited
Loading

Codecov Report

Merging #1249 into master will decrease coverage by 0.15%.
The diff coverage is 95.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1249      +/-   ##
==========================================
- Coverage   96.07%   95.91%   -0.16%     
==========================================
  Files          39       39              
  Lines         739      784      +45     
  Branches      122      139      +17     
==========================================
+ Hits          710      752      +42     
  Misses          1        1              
- Partials       28       31       +3
Impacted Files Coverage Δ
...src/modules/month/calendar-month-view.component.ts 90.12% <ø> (ø)
...odules/month/calendar-open-day-events.component.ts 100.00% <ø> (ø)
...modules/week/calendar-week-view-event.component.ts 100.00% <ø> (ø)
...rc/modules/common/calendar-drag-helper.provider.ts 91.66% <88.88%> (-8.34%) ⬇️
...r/src/modules/week/calendar-week-view.component.ts 94.50% <95.91%> (-0.21%) ⬇️
.../modules/common/calendar-resize-helper.provider.ts 100.00% <100.00%> (ø)
...ndar/src/modules/common/keydown-enter.directive.ts 85.71% <100.00%> (ø)
...ojects/angular-calendar/src/modules/common/util.ts 95.38% <100.00%> (+0.30%) ⬆️
...dar/src/modules/day/calendar-day-view.component.ts 100.00% <100.00%> (ø)
...alendar-week-view-current-time-marker.component.ts 95.65% <100.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62f878e...08d02b3. Read the comment docs.

@mattlewis92 mattlewis92 mentioned this pull request May 23, 2020
Closed
@mattlewis92
Merge branch 'master' into 0.29.0
c7a901d
@mattlewis92
feat: drop support for angular 6 and 7
bc15e03 
BREAKING CHANGE: angular 6 and 7 are no longer supported. To use this package you must upgrade to angular 8 or higher.
@EFritzsche90
Copy link

Do you know when this will be finally be approved?

@mattlewis92
Copy link
Owner Author

Do you know when this will be finally be approved?

It should be in the next couple of weeks, there's one more small breaking change I need to make first to ship the date adapters in ESM: #1283

@cheapfun
Copy link

cheapfun commented Jul 2, 2020 •
edited
Loading

Hello,

Thank you for considering my request: #1183!

I just tested this version, and it works pretty well, I could do anything I want, thank you!

Only one little bug:

Now an event can be moved outside the calendar. To fix this, I had to add a test in the validateEventTimesChanged method to check that the event is within the calendar limits (dayStartHour / dayEndHour).

@mattlewis92
Copy link
Owner Author

Hello,

Thank you for considering my request: #1183!

I just tested this version, and it works pretty well, I could do anything I want, thank you!

Only one little bug:

Now an event can be moved outside the calendar. To fix this, I had to add a test in the validateEventTimesChanged method to check that the event is within the calendar limits (dayStartHour / dayEndHour).

Awesome, that's great to hear, I'm glad it worked for you 😄

Regarding your issue I think this is expected behaviour, it's now completely opinionated where you can drag events to and is noted as a breaking change:

"week-view: the drag behaviour now mimicks the resize behaviour where you can drag an event down to move it into the next day. To restore the old behaviour you can use the new validateEventTimesChanged input to control where an event can be dragged."

@martijn19811
Copy link

Hi,

any idea when this will be approved?

@mattlewis92 mattlewis92 mentioned this pull request Aug 31, 2021
Closed
@mattlewis92
feat: publish package in ivy partial compilation mode
29eb8c9 
BREAKING CHANGE: angular 12 or higher is now required to use this package

Closes #1536
@mattlewis92 mattlewis92 merged commit 3114643 into master Dec 11, 2021
@mattlewis92 mattlewis92 deleted the 0.29.0 branch December 11, 2021 10:30
@mattlewis92
Copy link
Owner Author

Apologies for the people that were waiting on this release, it was long overdue (pandemic + burnout etc, it's a long story that I'm not going into here 😅), but 0.29.0 is now finally released as stable! 🥳

@billyjov
Copy link
Collaborator

Good Job @mattlewis92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.29
10 participants
@mattlewis92 @codecov-io @codecov-commenter @EFritzsche90 @cheapfun @martijn19811 @Julian-B90 @billyjov @martinsware @JaxonWright