This repository was archived by the owner on Sep 27, 2023. It is now read-only.
fix: enable complex resource ids in instantiate()#159
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
============================================
+ Coverage 64.09% 64.43% +0.33%
- Complexity 171 174 +3
============================================
Files 14 14
Lines 713 717 +4
Branches 118 120 +2
============================================
+ Hits 457 462 +5
+ Misses 220 219 -1
Partials 36 36
Continue to review full report at Codecov.
|
|
I just tested this out with a local build, and it seems to have fixed the problem. Thank you for the quick fix here! Any idea when this might make it into the next release. As mentioned in #154, we have another large body of work which depends on this feature, with a hard deadline in mid-July. |
elharo
reviewed
Jul 1, 2020
| Truth.assertThat(match.get("foo")).isEqualTo("foo1"); | ||
| Truth.assertThat(match.get("bar")).isEqualTo("bar2"); | ||
| variables = template.vars(); | ||
| System.out.println("DEL: vars: " + variables); |
| .containsExactly("foo", "bar", "zone_a", "zone_b", "zone_c", "cell1", "cell2"); | ||
|
|
||
| pattern = "projects/{foo}_{bar}/zones/*"; | ||
| template = PathTemplate.create(pattern); |
Contributor
There was a problem hiding this comment.
local variables probably shouldn't be reused
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #154.