This repository was archived by the owner on Sep 27, 2023. It is now read-only.
feat: add ApiFutures.successfulAsList#163
Merged
BenWhitehead merged 1 commit intogoogleapis:masterfrom Jul 17, 2020
thebrianchen:master
Merged
feat: add ApiFutures.successfulAsList#163BenWhitehead merged 1 commit intogoogleapis:masterfrom thebrianchen:master
BenWhitehead merged 1 commit intogoogleapis:masterfrom
thebrianchen:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
============================================
+ Coverage 64.43% 64.68% +0.24%
- Complexity 174 175 +1
============================================
Files 14 14
Lines 717 722 +5
Branches 120 120
============================================
+ Hits 462 467 +5
Misses 219 219
Partials 36 36
Continue to review full report at Codecov.
|
BenWhitehead
approved these changes
Jul 14, 2020
BenWhitehead
left a comment
There was a problem hiding this comment.
This looks okay to me. @chingor13 does this seem okay to you?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to use this in the java-firestore repo. This PR exposes
ApiFutures.successfulAsList(link).Here is a PR that uses it (link).
successfulAsListallows me to wait for all Futures to complete (ApiFutures.allAsListcompletes early if an exception is thrown) before I run my listener. The alternative implementation without this method would be to manually add listeners to all the ApiFutures in order to handle exceptions.