This repository was archived by the owner on Sep 16, 2023. It is now read-only.
feat(v1p3beta1,v1p4beta): breaking resource name changes#133
Merged
feat(v1p3beta1,v1p4beta): breaking resource name changes#133
Conversation
BREAKING CHANGE: The breaking changes are as follows. After discussion please see this PR, these seem to be acceptable given that this is a beta API. com.google.cloud.vision.v1p4beta1.ProductSearchClient: Parameter 2 of 'public void addProductToProductSet(com.google.cloud.vision.v1p4beta1.ProductSetName, java.lang.String)' has changed its type to com.google.cloud.vision.v1p4beta1.ProductName com.google.cloud.vision.v1p4beta1.ProductSearchClient: Parameter 2 of 'public void removeProductFromProductSet(com.google.cloud.vision.v1p4beta1.ProductSetName, java.lang.String)' has changed its type to com.google.cloud.vision.v1p4beta1.ProductName Committer: @miraleung PiperOrigin-RevId: 309787157 Source-Author: Google APIs <noreply@google.com> Source-Date: Mon May 4 11:38:06 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: ab3468cf63abc521be76c9eceb620d61c5ddd76a Source-Link: googleapis/googleapis@ab3468c
BREAKING CHANGE: The breaking changes are as follows. After discussion please see [this PR](googleapis/gapic-generator#3177), these seem to be acceptable given that this is a beta API. com.google.cloud.vision.v1p4beta1.ProductSearchClient: Method 'public com.google.longrunning.Operation purgeProducts(com.google.cloud.vision.v1p4beta1.PurgeProductsRequest)' has been removed - This is because this method was not generating with the same LRO interface that all other configured RPCs receive. com.google.cloud.vision.v1p4beta1.ProductSearchClient: Parameter 2 of 'public void addProductToProductSet(com.google.cloud.vision.v1p4beta1.ProductSetName, java.lang.String)' has changed its type to com.google.cloud.vision.v1p4beta1.ProductName com.google.cloud.vision.v1p4beta1.ProductSearchClient: Parameter 2 of 'public void removeProductFromProductSet(com.google.cloud.vision.v1p4beta1.ProductSetName, java.lang.String)' has changed its type to com.google.cloud.vision.v1p4beta1.ProductName Committer: @miraleung PiperOrigin-RevId: 309788146 Source-Author: Google APIs <noreply@google.com> Source-Date: Mon May 4 11:42:36 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: a737a68e214d1cf927457c996b73e2600b14a949 Source-Link: googleapis/googleapis@a737a68
chingor13
approved these changes
May 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was generated using Autosynth. 🌈
Synth log will be available here:
https://source.cloud.google.com/results/invocations/1e4b8d13-0844-4ca8-9840-ed96ed5334bd/targets