feat: add custom and hp tuning#388
Merged
sasha-gitg merged 32 commits intogoogleapis:masterfrom May 18, 2021
Merged
Conversation
…g pipelines to use snake case instead of camel case to be consistent with custom job
…e as a separate package
ivanmkc
reviewed
May 17, 2021
…ers, will follow up to add them in
ivanmkc
reviewed
May 17, 2021
ivanmkc
reviewed
May 17, 2021
ivanmkc
reviewed
May 17, 2021
vinnysenthil
approved these changes
May 18, 2021
Comment on lines
+569
to
+572
| @property | ||
| def gca_resource(self) -> proto.Message: | ||
| """The underlying resource proto represenation.""" | ||
| return self._gca_resource |
Contributor
There was a problem hiding this comment.
Why are we exposing this?
Member
Author
There was a problem hiding this comment.
Customers may need a field we haven't exposed. This allows us to provide code that doesn't require referencing a private attribute.
Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
Member
Author
|
Thanks for the awesome review Vinny! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.