Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
This repository was archived by the owner on Feb 26, 2026. It is now read-only.

feat: use structured logging on GCF with python 3.7#434

Merged
daniel-sanche merged 8 commits intomainfrom
functions-37
Nov 1, 2021
Merged

feat: use structured logging on GCF with python 3.7#434
daniel-sanche merged 8 commits intomainfrom
functions-37

Conversation

@daniel-sanche
Copy link
Contributor

Previously, GCF Python 3.7 didn't support structured logging, so the library would default to the grpc CloudLoggingHandler. now that the environment supports structured logging, we can update to the StructuredLoggingHandler to make it in line with other serverless environments

@daniel-sanche daniel-sanche requested a review from a team October 27, 2021 19:32
@daniel-sanche daniel-sanche requested a review from a team as a code owner October 27, 2021 19:32
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Oct 27, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 27, 2021
Copy link
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-sanche daniel-sanche changed the title feat: use structured logging on GCF with python 3.7 [DRAFT] feat: use structured logging on GCF with python 3.7 Oct 27, 2021
@daniel-sanche
Copy link
Contributor Author

It looks like the environment still isn't working with structured logging. I'm going to hold this open as a draft for now

@daniel-sanche daniel-sanche changed the title [DRAFT] feat: use structured logging on GCF with python 3.7 feat: use structured logging on GCF with python 3.7 Oct 29, 2021
Copy link
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-sanche daniel-sanche merged commit 5055919 into main Nov 1, 2021
@daniel-sanche daniel-sanche deleted the functions-37 branch November 1, 2021 22:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: logging Issues related to the googleapis/python-logging API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants