-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-test-sequencer: initial service scaffolding #14270
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #14270 +/- ##
============================================
- Coverage 78.11% 42.01% -36.11%
============================================
Files 178 859 +681
Lines 10667 78436 +67769
============================================
+ Hits 8333 32957 +24624
- Misses 2143 42586 +40443
- Partials 191 2893 +2702
Flags with carried forward coverage won't be shown. Click here to find out more. |
fe70b6f
to
dc45c12
Compare
dc45c12
to
48e58e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This scaffolding does indeed look a lot like the supervisor, without any business logic.
I'm inclined to suggest that we somehow turn this commit into a template that can be used in the future. Rather than have this PR use op-test-sequencer/
, it could use op-service-template/
. We could then spawn the op-test-sequencer
by cloning the directory, and filling out any missing names.
Or, at a minimum, this commit should be mentioned in some README.md
so future apps may reuse this scaffolding.
Tracking the service-templating suggestion here now: #14577 |
Description
Completes milestone 0.0 of the test-sequencing work.
Code is largely inspired by the op-supervisor service setup code.
Previous work to de-duplicate more service code was blocked, so we have to go with some boilerplate here.
Tests
Tests CLI usage, service entrypoint RPC, mock backend.
Additional context
Metadata
Fix #14123