Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-test-sequencer: initial service scaffolding #14270

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Conversation

protolambda
Copy link
Contributor

Description

Completes milestone 0.0 of the test-sequencing work.

Code is largely inspired by the op-supervisor service setup code.
Previous work to de-duplicate more service code was blocked, so we have to go with some boilerplate here.

Tests

Tests CLI usage, service entrypoint RPC, mock backend.

Additional context

Metadata

Fix #14123

@protolambda protolambda added the H-interop Hardfork: change planned for interop upgrade label Feb 10, 2025
@protolambda protolambda requested a review from a team as a code owner February 10, 2025 14:43
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.01%. Comparing base (0a2f43d) to head (48e58e6).
Report is 49 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (0a2f43d) and HEAD (48e58e6). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (0a2f43d) HEAD (48e58e6)
cannon-go-tests-32 2 0
cannon-go-tests-64 2 0
contracts-bedrock-tests 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14270       +/-   ##
============================================
- Coverage    78.11%   42.01%   -36.11%     
============================================
  Files          178      859      +681     
  Lines        10667    78436    +67769     
============================================
+ Hits          8333    32957    +24624     
- Misses        2143    42586    +40443     
- Partials       191     2893     +2702     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1029 files with indirect coverage changes

@protolambda protolambda force-pushed the test-sequencing branch 2 times, most recently from fe70b6f to dc45c12 Compare February 21, 2025 22:52
Copy link
Contributor

@axelKingsley axelKingsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This scaffolding does indeed look a lot like the supervisor, without any business logic.

I'm inclined to suggest that we somehow turn this commit into a template that can be used in the future. Rather than have this PR use op-test-sequencer/, it could use op-service-template/. We could then spawn the op-test-sequencer by cloning the directory, and filling out any missing names.

Or, at a minimum, this commit should be mentioned in some README.md so future apps may reuse this scaffolding.

@protolambda
Copy link
Contributor Author

Tracking the service-templating suggestion here now: #14577
There is no readme where we can put this PR link / commit well, but the issue should help surface this for future use if needed.

@protolambda protolambda added this pull request to the merge queue Feb 28, 2025
Merged via the queue into develop with commit e274a15 Feb 28, 2025
46 checks passed
@protolambda protolambda deleted the test-sequencing branch February 28, 2025 14:50
@protolambda protolambda restored the test-sequencing branch February 28, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-test-sequencer Area: op-test-sequencer H-interop Hardfork: change planned for interop upgrade
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

interop: test-sequencing milestone 0.0: service setup
2 participants