Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-e2e: cleanup unused MessageExpiryTime from interop recipe #14634

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

Inphi
Copy link
Contributor

@Inphi Inphi commented Mar 4, 2025

Message expiry time is now configured in the depset. So it's no longer needed in the dev recipe.

@Inphi Inphi marked this pull request as ready for review March 4, 2025 22:35
@Inphi Inphi requested review from a team as code owners March 4, 2025 22:35
@Inphi Inphi requested a review from sebastianst March 4, 2025 22:35
@Inphi Inphi enabled auto-merge March 4, 2025 22:36
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.21%. Comparing base (8fe61f4) to head (26104f2).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14634      +/-   ##
===========================================
- Coverage    46.61%   42.21%   -4.40%     
===========================================
  Files         1038      868     -170     
  Lines        89435    79431   -10004     
===========================================
- Hits         41689    33532    -8157     
+ Misses       44665    42989    -1676     
+ Partials      3081     2910     -171     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-chain-ops/interopgen/recipe.go 74.80% <100.00%> (ø)

... and 177 files with indirect coverage changes

@Inphi Inphi added this pull request to the merge queue Mar 5, 2025
Merged via the queue into develop with commit 8beb603 Mar 5, 2025
46 checks passed
@Inphi Inphi deleted the inphi/clean branch March 5, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants