-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flutter_bloc): expose dispose
on RepositoryProvider
#4356
feat(flutter_bloc): expose dispose
on RepositoryProvider
#4356
Conversation
RepositoryProvider
Hi @felangel, may I kindly ask you to let me know when are you going to merge the changes, if, of course, you're going to accept the PR? And when should I expect it to appear on Thanks in advance! |
After thinking about it a bit more, I think the change is fine. I’ll try to get it merged and released in the next few days. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4356 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 32 32
Lines 802 801 -1
=========================================
- Hits 802 801 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RepositoryProvider
dispose
on RepositoryProvider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for the contribution! 💙
Status
READY
Breaking Changes
NO
Description
Allows to cleanup resources used in the created repo.
Type of Change