build: fix readability details

Removing some leftover common anti-patterns:

- remove unnecessary dict() usage
- remove unnecessary map()
- avoid index-based loops
- use capitalize() instead of index-based capitalization
- use f-strings for concatenation

Pick-to: 6.2 6.3
Change-Id: I0ffdf73ec47c6ef537789015052dea0fd047350d
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>

1 files changed, 3 insertions, 3 deletions

diff --git a/build_scripts/qp5_tool.py b/build_scripts/qp5_tool.py
index aa43b872b..0a22cd707 100644
--- a/build_scripts/qp5_tool.py
+++ b/build_scripts/qp5_tool.py
@@ -192,7 +192,7 @@ def read_config(key):
     """
     if not config_dict:
         read_config_file(config_file)
-    repo_value = config_dict.get(key + '-' + base_dir)
+    repo_value = config_dict.get(f"{key}-{base_dir}")
     return repo_value if repo_value else config_dict.get(key)
 
 
@@ -225,7 +225,7 @@ def read_config_build_arguments():
 def read_config_modules_argument():
     value = read_config(MODULES_KEY)
     if value and value != '' and value != 'all':
-        return '--module-subset=' + value
+        return f"--module-subset={value}"
     return None
 
 
@@ -266,7 +266,7 @@ def get_config_file(base_name):
         if os.path.exists(config_dir):
             config_file = os.path.join(config_dir, base_name)
         else:
-            config_file = os.path.join(home, '.' + base_name)
+            config_file = os.path.join(home, f".{base_name}")
     return config_file