PySide Tools: Fix flake8 warnings

- Fix general flake8 warnings in pyside-tools.
- add F401 to .flake8 to ignore unused imports from __init__.py files
- add E402 from __init__.py to prevent errors related to partial
  initialization of modules.

Pick-to: 6.6 6.5
Change-Id: Ia848b08ff6f0d2808e04f6a83c46636e2d167c02
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>

3 files changed, 8 insertions, 9 deletions

diff --git a/sources/pyside-tools/qtpy2cpp_lib/tests/baseline/basic_test.py b/sources/pyside-tools/qtpy2cpp_lib/tests/baseline/basic_test.py
index 10dc73767..1466ac6b1 100644
--- a/sources/pyside-tools/qtpy2cpp_lib/tests/baseline/basic_test.py
+++ b/sources/pyside-tools/qtpy2cpp_lib/tests/baseline/basic_test.py
@@ -4,7 +4,7 @@
 
 import sys
 
-from PySide6.QtCore import qVersion, Qt
+from PySide6.QtCore import Qt
 from PySide6.QtGui import QColor, QPainter, QPaintEvent, QShortcut
 from PySide6.QtWidgets import QApplication, QWidget
 
diff --git a/sources/pyside-tools/qtpy2cpp_lib/tests/test_qtpy2cpp.py b/sources/pyside-tools/qtpy2cpp_lib/tests/test_qtpy2cpp.py
index f9f921705..894b2a958 100644
--- a/sources/pyside-tools/qtpy2cpp_lib/tests/test_qtpy2cpp.py
+++ b/sources/pyside-tools/qtpy2cpp_lib/tests/test_qtpy2cpp.py
@@ -14,7 +14,7 @@ def diff_code(actual_code, expected_file):
     with tempfile.NamedTemporaryFile(suffix=".cpp") as tf:
         tf.write(actual_code.encode('utf-8'))
         tf.flush()
-        diff_cmd = ["diff", "-u", expected_file,  tf.name]
+        diff_cmd = ["diff", "-u", expected_file, tf.name]
         subprocess.run(diff_cmd)
 
 
@@ -33,22 +33,22 @@ def run_converter(tool, file):
 def test_examples():
     dir = Path(__file__).resolve().parent
     tool = dir.parents[1] / "qtpy2cpp.py"
-    assert(tool.is_file)
+    assert tool.is_file
     for test_file in (dir / "baseline").glob("*.py"):
-        assert(test_file.is_file)
+        assert test_file.is_file
         expected_file = test_file.parent / (test_file.stem + ".cpp")
         if expected_file.is_file():
             actual_code = run_converter(tool, test_file)
-            assert(actual_code)
+            assert actual_code
             expected_code = expected_file.read_text()
             # Strip the license
             code_start = expected_code.find("// Converted from")
-            assert(code_start != -1)
+            assert code_start != -1
             expected_code = expected_code[code_start:]
 
             if actual_code != expected_code:
                 diff_code(actual_code, expected_file)
-            assert(actual_code == expected_code)
+            assert actual_code == expected_code
         else:
             print(f"Warning, {test_file} is missing a .cpp file.",
                   file=sys.stderr)
diff --git a/sources/pyside-tools/qtpy2cpp_lib/visitor.py b/sources/pyside-tools/qtpy2cpp_lib/visitor.py
index 1e8b5dc84..2056951ae 100644
--- a/sources/pyside-tools/qtpy2cpp_lib/visitor.py
+++ b/sources/pyside-tools/qtpy2cpp_lib/visitor.py
@@ -10,8 +10,7 @@ import warnings
 
 from .formatter import (CppFormatter, format_for_loop, format_literal,
                         format_name_constant,
-                        format_reference, format_start_function_call,
-                        write_import, write_import_from)
+                        format_reference, write_import, write_import_from)
 from .nodedump import debug_format_node
 from .qt import ClassFlag, qt_class_flags