Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFriedemann Kleint <Friedemann.Kleint@qt.io>2023-10-27 11:40:12 +0200
committerFriedemann Kleint <Friedemann.Kleint@qt.io>2023-10-27 14:08:09 +0200
commit2a1034684b23f526631dd9d9e85a39f5bd3b71dd (patch)
tree71bfc2325e9185af729ad243c2be963827407e0c /sources/pyside6/libpyside/pysidesignal.cpp
parent205e6f1da941ef6fd2de7cec40f7fe9e8e9e90f3 (diff)
Set error when instantiating a Signal on a non-QObject
Fixes: PYSIDE-2510 Pick-to: 6.6 6.5 Change-Id: Icc1461299907cc116bc75f5de994a687b85c1786 Reviewed-by: Adrian Herrmann <adrian.herrmann@qt.io>
Diffstat (limited to 'sources/pyside6/libpyside/pysidesignal.cpp')
-rw-r--r--sources/pyside6/libpyside/pysidesignal.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/sources/pyside6/libpyside/pysidesignal.cpp b/sources/pyside6/libpyside/pysidesignal.cpp
index 687eb400e..b61ade1f5 100644
--- a/sources/pyside6/libpyside/pysidesignal.cpp
+++ b/sources/pyside6/libpyside/pysidesignal.cpp
@@ -733,7 +733,8 @@ static PyObject *signalDescrGet(PyObject *self, PyObject *obj, PyObject * /*type
{
auto signal = reinterpret_cast<PySideSignal *>(self);
// Return the unbound signal if there is nothing to bind it to.
- if (obj == nullptr || obj == Py_None) {
+ if (obj == nullptr || obj == Py_None
+ || !PySide::isQObjectDerived(Py_TYPE(obj), true)) {
Py_INCREF(self);
return self;
}