diff options
author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2023-05-22 15:53:02 +0200 |
---|---|---|
committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2023-05-23 11:33:23 +0200 |
commit | a088afe165cdf4377edd9c691733a8e8da3e641d (patch) | |
tree | ea0f06032e503cbdd44a21811d04d6866654d0d0 /sources/pyside6/libpyside/qobjectconnect.cpp | |
parent | 64bacdf74cc7a32cd5bd60ed50bf5cbe998483ff (diff) |
Fix crash when mixing other decorators with @Slot
Pick-to: 6.5
Task-number: PYSIDE-2338
Change-Id: Iab13d0550f59a14006e0d650270ac87a6e7fe3b3
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
Diffstat (limited to 'sources/pyside6/libpyside/qobjectconnect.cpp')
-rw-r--r-- | sources/pyside6/libpyside/qobjectconnect.cpp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/sources/pyside6/libpyside/qobjectconnect.cpp b/sources/pyside6/libpyside/qobjectconnect.cpp index bdf77a18e..608eae170 100644 --- a/sources/pyside6/libpyside/qobjectconnect.cpp +++ b/sources/pyside6/libpyside/qobjectconnect.cpp @@ -29,6 +29,8 @@ static bool isMethodDecorator(PyObject *method, bool is_pymethod, PyObject *self function1 = PyMethod_GET_FUNCTION(otherMethod.object()); } else { function1 = PyObject_GetAttr(otherMethod.object(), Shiboken::PyName::im_func()); + if (function1 == nullptr) + return false; Py_DECREF(function1); // Not retaining a reference in line with what PyMethod_GET_FUNCTION does. } |