diff options
| author | Peter Eisentraut | 2023-10-26 07:16:25 +0000 |
|---|---|---|
| committer | Peter Eisentraut | 2023-10-26 07:20:54 +0000 |
| commit | 611806cd726fc92989ac918eac48fd8d684869c7 (patch) | |
| tree | 4ed4dc6fc9a1c5825bf42072e28312440484db28 /contrib/postgres_fdw | |
| parent | f0efa5aec19358e2282d4968a03db1db56f0ac3f (diff) | |
Add trailing commas to enum definitions
Since C99, there can be a trailing comma after the last value in an
enum definition. A lot of new code has been introducing this style on
the fly. Some new patches are now taking an inconsistent approach to
this. Some add the last comma on the fly if they add a new last
value, some are trying to preserve the existing style in each place,
some are even dropping the last comma if there was one. We could
nudge this all in a consistent direction if we just add the trailing
commas everywhere once.
I omitted a few places where there was a fixed "last" value that will
always stay last. I also skipped the header files of libpq and ecpg,
in case people want to use those with older compilers. There were
also a small number of cases where the enum type wasn't used anywhere
(but the enum values were), which ended up confusing pgindent a bit,
so I left those alone.
Discussion: https://www.postgresql.org/message-id/flat/386f8c45-c8ac-4681-8add-e3b0852c1620%40eisentraut.org
Diffstat (limited to 'contrib/postgres_fdw')
| -rw-r--r-- | contrib/postgres_fdw/deparse.c | 2 | ||||
| -rw-r--r-- | contrib/postgres_fdw/postgres_fdw.c | 8 | ||||
| -rw-r--r-- | contrib/postgres_fdw/postgres_fdw.h | 2 |
3 files changed, 6 insertions, 6 deletions
diff --git a/contrib/postgres_fdw/deparse.c b/contrib/postgres_fdw/deparse.c index 09d6dd60ddc..09fd489a901 100644 --- a/contrib/postgres_fdw/deparse.c +++ b/contrib/postgres_fdw/deparse.c @@ -83,7 +83,7 @@ typedef enum * it has default collation that is not * traceable to a foreign Var */ FDW_COLLATE_SAFE, /* collation derives from a foreign Var */ - FDW_COLLATE_UNSAFE /* collation is non-default and derives from + FDW_COLLATE_UNSAFE, /* collation is non-default and derives from * something other than a foreign Var */ } FDWCollateState; diff --git a/contrib/postgres_fdw/postgres_fdw.c b/contrib/postgres_fdw/postgres_fdw.c index 1393716587e..8b3206ceaa3 100644 --- a/contrib/postgres_fdw/postgres_fdw.c +++ b/contrib/postgres_fdw/postgres_fdw.c @@ -82,7 +82,7 @@ enum FdwScanPrivateIndex * String describing join i.e. names of relations being joined and types * of join, added when the scan is join */ - FdwScanPrivateRelations + FdwScanPrivateRelations, }; /* @@ -108,7 +108,7 @@ enum FdwModifyPrivateIndex /* has-returning flag (as a Boolean node) */ FdwModifyPrivateHasReturning, /* Integer list of attribute numbers retrieved by RETURNING */ - FdwModifyPrivateRetrievedAttrs + FdwModifyPrivateRetrievedAttrs, }; /* @@ -129,7 +129,7 @@ enum FdwDirectModifyPrivateIndex /* Integer list of attribute numbers retrieved by RETURNING */ FdwDirectModifyPrivateRetrievedAttrs, /* set-processed flag (as a Boolean node) */ - FdwDirectModifyPrivateSetProcessed + FdwDirectModifyPrivateSetProcessed, }; /* @@ -285,7 +285,7 @@ enum FdwPathPrivateIndex /* has-final-sort flag (as a Boolean node) */ FdwPathPrivateHasFinalSort, /* has-limit flag (as a Boolean node) */ - FdwPathPrivateHasLimit + FdwPathPrivateHasLimit, }; /* Struct for extra information passed to estimate_path_cost_size() */ diff --git a/contrib/postgres_fdw/postgres_fdw.h b/contrib/postgres_fdw/postgres_fdw.h index 02c11523199..47157ac887e 100644 --- a/contrib/postgres_fdw/postgres_fdw.h +++ b/contrib/postgres_fdw/postgres_fdw.h @@ -143,7 +143,7 @@ typedef enum PgFdwSamplingMethod ANALYZE_SAMPLE_AUTO, /* choose by server version */ ANALYZE_SAMPLE_RANDOM, /* remote random() */ ANALYZE_SAMPLE_SYSTEM, /* TABLESAMPLE system */ - ANALYZE_SAMPLE_BERNOULLI /* TABLESAMPLE bernoulli */ + ANALYZE_SAMPLE_BERNOULLI, /* TABLESAMPLE bernoulli */ } PgFdwSamplingMethod; /* in postgres_fdw.c */ |