diff options
| author | Michael Paquier | 2024-02-14 01:07:22 +0000 |
|---|---|---|
| committer | Michael Paquier | 2024-02-14 01:07:22 +0000 |
| commit | 06bd311bce24083c76d9741ae89c98750aaf4b41 (patch) | |
| tree | 0a28e736dc3af52c13d5bb80d36338fe7768fe02 /src/backend/commands/copyfrom.c | |
| parent | d0071f922808981e2371351c46da5bb3c49554b2 (diff) | |
Revert "Refactor CopyReadAttributes{CSV,Text}() to use a callback in COPY FROM"
This reverts commit 95fb5b49024, for reasons similar to what led to
1aa8324b81fa. In this case, the callback was called once per row, which
is less worse than the previous callback introduced for COPY TO called
once per argument for each row, still the patch set discussed to plug in
custom routines to the COPY paths would be able to know which subroutine
to use depending on its CopyFromState, so this led to a suboptimal
approach at the end.
For now, this part is reverted to consider better which approach to use.
Discussion: https://postgr.es/m/20240206014125.qofww7ew3dx3v3uk@awork3.anarazel.de
Diffstat (limited to 'src/backend/commands/copyfrom.c')
| -rw-r--r-- | src/backend/commands/copyfrom.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/src/backend/commands/copyfrom.c b/src/backend/commands/copyfrom.c index 41f6bc43e49..1fe70b91338 100644 --- a/src/backend/commands/copyfrom.c +++ b/src/backend/commands/copyfrom.c @@ -1776,11 +1776,6 @@ BeginCopyFrom(ParseState *pstate, cstate->max_fields = attr_count; cstate->raw_fields = (char **) palloc(attr_count * sizeof(char *)); - - if (cstate->opts.csv_mode) - cstate->copy_read_attributes = CopyReadAttributesCSV; - else - cstate->copy_read_attributes = CopyReadAttributesText; } MemoryContextSwitchTo(oldcontext); |