Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndres Freund2025-02-24 10:39:27 +0000
committerAndres Freund2025-02-24 11:23:41 +0000
commit5ee75e32fa734e8ae85ff096f1523be8e16e1b8d (patch)
tree658cb18707e7dfa01c98ab14630e0d9ba9838626 /src/backend
parent418451bfe161e4b86c29f098e4d93b2347d35774 (diff)
Add static asserts for MAX_BACKENDS limiting factors
So far the various dependencies were documented in the comment above MAX_BACKENDS, but not checked. Discussion: https://postgr.es/m/CA+COZaBO_s3LfALq=b+HcBHFSOEGiApVjrRacCe4VP9m7CJsNQ@mail.gmail.com
Diffstat (limited to 'src/backend')
-rw-r--r--src/backend/storage/lmgr/deadlock.c3
-rw-r--r--src/backend/utils/cache/inval.c5
2 files changed, 8 insertions, 0 deletions
diff --git a/src/backend/storage/lmgr/deadlock.c b/src/backend/storage/lmgr/deadlock.c
index dc6923f8132..c4bfaaa67ac 100644
--- a/src/backend/storage/lmgr/deadlock.c
+++ b/src/backend/storage/lmgr/deadlock.c
@@ -30,6 +30,7 @@
#include "pgstat.h"
#include "storage/lmgr.h"
#include "storage/proc.h"
+#include "storage/procnumber.h"
#include "utils/memutils.h"
@@ -191,6 +192,8 @@ InitDeadLockChecking(void)
* last MaxBackends entries in possibleConstraints[] are reserved as
* output workspace for FindLockCycle.
*/
+ StaticAssertStmt(MAX_BACKENDS_BITS <= (32 - 3),
+ "MAX_BACKENDS_BITS too big for * 4");
maxPossibleConstraints = MaxBackends * 4;
possibleConstraints =
(EDGE *) palloc(maxPossibleConstraints * sizeof(EDGE));
diff --git a/src/backend/utils/cache/inval.c b/src/backend/utils/cache/inval.c
index 6aff1ec01d7..700ccb6df9b 100644
--- a/src/backend/utils/cache/inval.c
+++ b/src/backend/utils/cache/inval.c
@@ -120,6 +120,7 @@
#include "catalog/catalog.h"
#include "catalog/pg_constraint.h"
#include "miscadmin.h"
+#include "storage/procnumber.h"
#include "storage/sinval.h"
#include "storage/smgr.h"
#include "utils/catcache.h"
@@ -1651,6 +1652,10 @@ CacheInvalidateSmgr(RelFileLocatorBackend rlocator)
{
SharedInvalidationMessage msg;
+ /* verify optimization stated above stays valid */
+ StaticAssertStmt(MAX_BACKENDS_BITS <= 23,
+ "MAX_BACKEND_BITS is too big for inval.c");
+
msg.sm.id = SHAREDINVALSMGR_ID;
msg.sm.backend_hi = rlocator.backend >> 16;
msg.sm.backend_lo = rlocator.backend & 0xffff;