Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Dunstan2021-05-20 12:03:15 +0000
committerAndrew Dunstan2021-05-20 12:07:08 +0000
commit8bdd6f563aa2456de602e78991e6a9f61b8ec86d (patch)
tree95b700aa3452359cc6dcdf6ff7f406ffda71e85e /src/test/perl/PostgresNode.pm
parent413c1ef98e0c9c708c4a9a13a838a55b65b16a80 (diff)
Use a more portable way to get the version string in PostgresNode
Older versions of perl on Windows don't like the list form of pipe open, and perlcritic doesn't like the string form of open, so we avoid both with a simpler formulation using qx{}. Per complaint from Amit Kapila.
Diffstat (limited to 'src/test/perl/PostgresNode.pm')
-rw-r--r--src/test/perl/PostgresNode.pm6
1 files changed, 2 insertions, 4 deletions
diff --git a/src/test/perl/PostgresNode.pm b/src/test/perl/PostgresNode.pm
index f7088667a4a..c09a735dae9 100644
--- a/src/test/perl/PostgresNode.pm
+++ b/src/test/perl/PostgresNode.pm
@@ -1248,10 +1248,8 @@ sub _set_pg_version
local %ENV = $self->_get_env();
# We only want the version field
- open my $fh, "-|", $pg_config, "--version"
- or BAIL_OUT("$pg_config failed: $!");
- my $version_line = <$fh>;
- close $fh or die;
+ my $version_line = qx{$pg_config --version};
+ BAIL_OUT("$pg_config failed: $!") if $?;
$self->{_pg_version} = PostgresVersion->new($version_line);