diff options
| author | David Rowley | 2021-07-28 22:14:25 +0000 |
|---|---|---|
| committer | David Rowley | 2021-07-28 22:14:25 +0000 |
| commit | 33d74c5d00e45248df66fa1bcd9222e0713ea5b1 (patch) | |
| tree | 41957d17e09323c6c1e9be9277d568a0bd9310f2 /src/tools/msvc/MSBuildProject.pm | |
| parent | a00c138b78521b9bc68b480490a8d601ecdeb816 (diff) | |
Make the includes field an array in MSVC build scripts
Previously the 'includes' field was a string. It's slightly nicer to
manage this when it's defined as an array instead. This allows us to
more easily detect and eliminate duplicates.
Reviewed-by: Álvaro Herrera, Andrew Dunstan, Dagfinn Ilmari Mannsåker
Discussion: https://postgr.es/m/CAApHDvpo6g5csCTjc_0C7DMvgFPomVb0Rh-AcW5afd=Ya=LRuw@mail.gmail.com
Diffstat (limited to 'src/tools/msvc/MSBuildProject.pm')
| -rw-r--r-- | src/tools/msvc/MSBuildProject.pm | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/src/tools/msvc/MSBuildProject.pm b/src/tools/msvc/MSBuildProject.pm index ebe6530ba58..fdd22e89eb2 100644 --- a/src/tools/msvc/MSBuildProject.pm +++ b/src/tools/msvc/MSBuildProject.pm @@ -313,11 +313,8 @@ sub WriteItemDefinitionGroup my $targetmachine = $self->{platform} eq 'Win32' ? 'MachineX86' : 'MachineX64'; - my $includes = $self->{includes}; - unless ($includes eq '' or $includes =~ /;$/) - { - $includes .= ';'; - } + my $includes = join ';', @{$self->{includes}}, ""; + print $f <<EOF; <ItemDefinitionGroup Condition="'\$(Configuration)|\$(Platform)'=='$cfgname|$self->{platform}'"> <ClCompile> |