Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Lane2017-09-24 16:05:06 +0000
committerTom Lane2017-09-24 16:05:06 +0000
commit8485a25a8c9a419ff3e0d30e43e4abd5e680cc65 (patch)
tree29b32a1524550759e95f4906c33c267f6e60881e /src/tools/msvc/MSBuildProject.pm
parent6dda0998afc7d449145b9ba216844bdba7a817d6 (diff)
Fix assorted infelicities in new SetWALSegSize() function.
* Failure to check for malloc failure (ok, pretty unlikely here, but that's not an excuse). * Leakage of open fd on read error, and of malloc'd buffer always. * Incorrect assumption that a short read would set errno to zero. * Failure to adhere to message style conventions (in particular, not reporting errno where relevant; using "couldn't open" rather than "could not open" is not really in line with project style either). * Missing newlines on some messages. Coverity spotted the leak problems; I noticed the rest while fixing the leaks.
Diffstat (limited to 'src/tools/msvc/MSBuildProject.pm')
0 files changed, 0 insertions, 0 deletions