Report tuple address in data-corruption error message

Most data-corruption reports mention the location of the problem, but
this one failed to.  Add it.

Backpatch all the way back.  In 12 and older, also assign the
ERRCODE_DATA_CORRUPTED error code as was done in commit fd6ec93bf890 for
13 and later.

Discussion: https://postgr.es/m/202108191637.oqyzrdtnheir@alvherre.pgsql

diff --git a/src/backend/access/heap/heapam_handler.c b/src/backend/access/heap/heapam_handler.c
index 9fe426344b1df7085887f54870c95169e65b94d7..5add38d88e3aa3ff9451327d66e100e432817d05 100644 (file)
--- a/src/backend/access/heap/heapam_handler.c
+++ b/src/backend/access/heap/heapam_handler.c
@@ -426,7 +426,13 @@ tuple_lock_retry:
 
                    /* otherwise xmin should not be dirty... */
                    if (TransactionIdIsValid(SnapshotDirty.xmin))
-                       elog(ERROR, "t_xmin is uncommitted in tuple to be updated");
+                       ereport(ERROR,
+                               (errcode(ERRCODE_DATA_CORRUPTED),
+                                errmsg_internal("t_xmin %u is uncommitted in tuple (%u,%u) to be updated in table \"%s\"",
+                                                SnapshotDirty.xmin,
+                                                ItemPointerGetBlockNumber(&tuple->t_self),
+                                                ItemPointerGetOffsetNumber(&tuple->t_self),
+                                                RelationGetRelationName(relation))));
 
                    /*
                     * If tuple is being updated by other transaction then we