Improve wording of error message when a postgresql.conf setting is

ignored because it can only be set at server start.  In particular,
hiding the main reason in the detail message was suboptimal.

diff --git a/src/backend/utils/misc/guc-file.l b/src/backend/utils/misc/guc-file.l
index b1ff03666a9b9232cf6f914d5c01cebdd080f1a5..57c86868235dea82df56d362d6187c1d15700bc4 100644 (file)
--- a/src/backend/utils/misc/guc-file.l
+++ b/src/backend/utils/misc/guc-file.l
@@ -260,9 +260,8 @@ ProcessConfigFile(GucContext context)
                {
                        ereport(elevel,
                                        (errcode(ERRCODE_CANT_CHANGE_RUNTIME_PARAM),
-                                        errmsg("attempted change of parameter \"%s\" ignored",
-                                                       gconf->name),
-                                        errdetail("This parameter cannot be changed after server start.")));
+                                        errmsg("parameter \"%s\" cannot be changed without restarting the server",
+                                                       gconf->name)));
                        continue;
                }
 

diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index 2224d5683d53f97fd55b84275eeb6935d36301f2..33b1f8b3892b172a41d76d76713afb477394e478 100644 (file)
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -4599,18 +4599,16 @@ set_config_option(const char *name, const char *value,
                                if (changeVal && !is_newvalue_equal(record, value))
                                        ereport(elevel,
                                                        (errcode(ERRCODE_CANT_CHANGE_RUNTIME_PARAM),
-                                          errmsg("attempted change of parameter \"%s\" ignored",
-                                                         name),
-                                                        errdetail("This parameter cannot be changed after server start.")));
+                                          errmsg("parameter \"%s\" cannot be changed without restarting the server",
+                                                         name)));
                                return true;
                        }
                        if (context != PGC_POSTMASTER)
                        {
                                ereport(elevel,
                                                (errcode(ERRCODE_CANT_CHANGE_RUNTIME_PARAM),
-                                          errmsg("attempted change of parameter \"%s\" ignored",
-                                                         name),
-                                                errdetail("This parameter cannot be changed after server start.")));
+                                          errmsg("parameter \"%s\" cannot be changed without restarting the server",
+                                                         name)));
                                return false;
                        }
                        break;