-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected forced version number for TFT_eSPI #4423
base: main
Are you sure you want to change the base?
Changes from 1 commit
1466dde
79f3ef9
2646165
7d5b67d
3325b0b
e28f045
98215f5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -23,17 +23,17 @@ build_flags = ${common.build_flags} ${esp32.build_flags} -D WLED_RELEASE_NAME=\" | |||||||||||||||||||
; -D IRPIN=4 | ||||||||||||||||||||
; -D RLYPIN=12 | ||||||||||||||||||||
; -D RLYMDE=1 | ||||||||||||||||||||
; -D WLED_DISABLE_BROWNOUT_DET | ||||||||||||||||||||
; -D WLED_DISABLE_BROWNOUT_DET | ||||||||||||||||||||
;PIN defines - uncomment and change, if needed: | ||||||||||||||||||||
-D DATA_PINS=2 | ||||||||||||||||||||
;or use this for multiple outputs | ||||||||||||||||||||
;-D DATA_PINS=1,3 | ||||||||||||||||||||
; -D DATA_PINS=1,3 | ||||||||||||||||||||
-D BTNPIN=35 | ||||||||||||||||||||
; -D IRPIN=4 | ||||||||||||||||||||
; -D RLYPIN=12 | ||||||||||||||||||||
; -D RLYMDE=1 | ||||||||||||||||||||
; -D RLYODRAIN=0 | ||||||||||||||||||||
; -D LED_BUILTIN=2 # GPIO of built-in LED | ||||||||||||||||||||
; -D IRPIN=4 | ||||||||||||||||||||
; -D RLYPIN=12 | ||||||||||||||||||||
; -D RLYMDE=1 | ||||||||||||||||||||
; -D RLYODRAIN=0 | ||||||||||||||||||||
; -D LED_BUILTIN=2 # GPIO of built-in LED | ||||||||||||||||||||
lib_deps = ${esp32.lib_deps} | ||||||||||||||||||||
#For use of the TTGO T-Display ESP32 Module with integrated TFT display uncomment the following line | ||||||||||||||||||||
;TFT_eSPI @ 2.5.33 | ||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any special reason that TFT library is commented out? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes - the following line is forcing an older version (2.1.4) instead. |
||||||||||||||||||||
|
@@ -44,6 +44,13 @@ monitor_filters = esp32_exception_decoder | |||||||||||||||||||
board_build.partitions = ${esp32.default_partitions} | ||||||||||||||||||||
|
||||||||||||||||||||
; # additional build flags for audioreactive | ||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The part for audioreactive is outdated - please replace with the proposed flags from platformio_override.sample.ini WLED/platformio_override.sample.ini Lines 143 to 150 in ae4de27
WLED/platformio_override.sample.ini Line 32 in ae4de27
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Corrected. |
||||||||||||||||||||
; AR_build_flags = -D USERMOD_AUDIOREACTIVE | ||||||||||||||||||||
; -D sqrt_internal=sqrtf ;; -fsingle-precision-constant ;; forces ArduinoFFT to use float math (2x faster) | ||||||||||||||||||||
; Use Audioreactive usermod and configure I2S microphone | ||||||||||||||||||||
; ${esp32.AR_build_flags} ;; default flags required to properly configure ArduinoFFT | ||||||||||||||||||||
; ;; don't forget to add ArduinoFFT to your libs_deps: ${esp32.AR_lib_deps} | ||||||||||||||||||||
; -D AUDIOPIN=-1 | ||||||||||||||||||||
; -D DMTYPE=1 # 0-analog/disabled, 1-I2S generic, 2-ES7243, 3-SPH0645, 4-I2S+mclk, 5-I2S PDM | ||||||||||||||||||||
; -D I2S_SDPIN=36 | ||||||||||||||||||||
; -D I2S_WSPIN=23 | ||||||||||||||||||||
; -D I2S_CKPIN=19 | ||||||||||||||||||||
; ${esp32.AR_lib_deps} ;; needed for USERMOD_AUDIOREACTIVE | ||||||||||||||||||||
; AR_lib_deps = kosme/arduinoFFT @ 2.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 27 might be part of the problem you had with default pins - platformIO is very picky about indentations, and a comment starting at column 0 might be enough to "end" the multi-line string prematurely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed (hopefully)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that this issue has been fixed, and the data pin is being reassigned correctly.