Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try using expansion/gpu queues #162

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Try using expansion/gpu queues #162

merged 1 commit into from
Feb 23, 2024

Conversation

Sbozzolo
Copy link
Member

Moving buildkite to the new partitions.

@Sbozzolo Sbozzolo force-pushed the gb/try_new_partition branch 3 times, most recently from f7486c5 to c559e23 Compare February 22, 2024 21:51
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.84%. Comparing base (893c289) to head (c1c7df6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   89.84%   89.84%           
=======================================
  Files           4        4           
  Lines         827      827           
=======================================
  Hits          743      743           
  Misses         84       84           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sbozzolo
Copy link
Member Author

I'd merge this in and see how this goes. @charleskawczynski, thoughts?

@charleskawczynski
Copy link
Member

I think it's probably fine? Testing in ClimaCore / ClimaAtmos will be the real stress test since this package doesn't use mpi

@Sbozzolo
Copy link
Member Author

I think it's probably fine? Testing in ClimaCore / ClimaAtmos will be the real stress test since this package doesn't use mpi

Yes, I wanted to move ClimaComms too but I there's a problem in how we do tests there when we use MPITrampoline (JuliaParallel/MPI.jl#820).

I'll start merging this one, and I will open a PR in ClimaCore (to see what it looks like, we will merge it down the line)

@Sbozzolo Sbozzolo merged commit 1094bc6 into main Feb 23, 2024
10 checks passed
@Sbozzolo Sbozzolo deleted the gb/try_new_partition branch February 23, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants