Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Add Zip for multiple Publishers #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 21, 2020
Merged

Add Zip for multiple Publishers #6

merged 10 commits into from
Mar 21, 2020

Conversation

jasdev
Copy link
Member

@jasdev jasdev commented Mar 16, 2020

Rough sketch of overloads to allow folks to zip arbitrarily many publishers. I tried to mirror the existing style in the repository, but please feel free to send any and all feedback (no nit too small)! 🙏🏽

@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #6 into master will increase coverage by 0.58%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   94.27%   94.86%   +0.58%     
==========================================
  Files          22       24       +2     
  Lines         908     1012     +104     
==========================================
+ Hits          856      960     +104     
  Misses         52       52              
Impacted Files Coverage Δ
Tests/WithLatestFromTests.swift 100.00% <ø> (ø)
Sources/Operators/ZipMany.swift 100.00% <100.00%> (ø)
Tests/ZipManyTests.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecef1a1...f923c63. Read the comment docs.

@freak4pc
Copy link
Member

image

Copy link
Member

@freak4pc freak4pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jasdev, thank you so much for making this!
I've had a couple of rough days with the entire COVID crisis, sorry this took a bit longer than expected.

This looks really good, I left a couple of minor notes / thoughts that I'd love your thoughts on. LMK!

@jasdev
Copy link
Member Author

jasdev commented Mar 21, 2020

I’ve had a couple of rough days with the entire COVID crisis, sorry this took a bit longer than expected.

No worries at all! Hope any dust has settled and that y’all are safe. Never any rush to reply—it’s already inspiring that you’re able to find the time, even as a new parent.

I think I covered everything (sorry for the force push, had a rebasing snag)! Let me know if there’s anything else blocking this PR, when you get some headspace. 🙏🏽

@freak4pc
Copy link
Member

I'm a fan of force-push on feature branches, no need to apologize :)
Thank you!

Copy link
Member

@freak4pc freak4pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some final nits but this looks awesome, ready from my side.
I think i'll just commit the nits and merge this in.

@freak4pc freak4pc changed the title First pass at ZipMany.swift, tests, and documentation. Add Zip for multiple Publishers Mar 21, 2020
@freak4pc freak4pc merged commit 4febfd7 into CombineCommunity:master Mar 21, 2020
@jasdev jasdev deleted the zip-many branch March 21, 2020 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants