Institute a 10 snapshot per probe per trace budget by evanchooly · Pull Request #8277 · DataDog/dd-trace-java

evanchooly · 2025-01-23T20:42:38Z

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: DEBUG-3368

pr-commenter · 2025-01-23T20:59:15Z

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1737733914	1737734286
end_time	2025-01-24T15:53:11	2025-01-24T15:59:23
git_branch	master	evanchooly/DEBUG-3368
git_commit_sha	`77b93e2`	`91f7384`
start_time	2025-01-24T15:51:54	2025-01-24T15:58:07

See matching parameters

	Baseline	Candidate
ci_job_id	779693923	779693923
ci_pipeline_id	53930910	53930910
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1737733286	1737733286

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 7 metrics, 8 unstable metrics.

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-60.884µs; +28.266µs] or [-21.141%; +9.815%]	unstable [-79.560µs; +40.504µs] or [-24.028%; +12.232%]	unstable [-91.273µs; +48.305µs] or [-26.315%; +13.927%]	unstable [-1011.542µs; +308.311µs] or [-110.620%; +33.716%]	same
scenario:basic	same	unstable [-23.546µs; +11.478µs] or [-7.549%; +3.680%]	unstable [-36.172µs; +17.069µs] or [-11.079%; +5.228%]	unstable [-505.853µs; +170.508µs] or [-73.779%; +24.868%]	unstable [-117.254op/s; +245.459op/s] or [-4.690%; +9.818%]
scenario:loop	unsure [+36.131µs; +65.711µs] or [+0.362%; +0.658%]	unsure [+30.707µs; +108.071µs] or [+0.303%; +1.066%]	same	same	same

Request duration reports for reports

gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (331.116 µs) : 256, 406
.   : milestone, 331,
basic (311.905 µs) : 290, 333
.   : milestone, 312,
loop (10.141 ms) : 10109, 10173
.   : milestone, 10141,
section candidate
noprobe (311.588 µs) : 280, 343
.   : milestone, 312,
basic (305.871 µs) : 295, 317
.   : milestone, 306,
loop (10.21 ms) : 10171, 10250
.   : milestone, 10210,

baseline results

Scenario	Request median duration [CI 0.99]
noprobe	331.116 µs [256.498 µs, 405.735 µs]
basic	311.905 µs [290.466 µs, 333.343 µs]
loop	10.141 ms [10.109 ms, 10.173 ms]

candidate results

Scenario	Request median duration [CI 0.99]
noprobe	311.588 µs [280.33 µs, 342.847 µs]
basic	305.871 µs [294.64 µs, 317.102 µs]
loop	10.21 ms [10.171 ms, 10.25 ms]

jpbempel

LGTM
I would add a test for the weak ref just to make sure we are not leaking it.
Like in

dd-trace-java/dd-java-agent/agent-debugger/src/test/java/com/datadog/debugger/exception/DefaultExceptionDebuggerTest.java

Line 154 in 0ab8864

System.gc();

pr-commenter · 2025-01-23T21:20:56Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	evanchooly/DEBUG-3368
git_commit_date	1737731098	1737733286
git_commit_sha	`77b93e2`	`91f7384`
release_version	1.46.0-SNAPSHOT~77b93e2b13	1.46.0-SNAPSHOT~91f7384179

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1737735771	1737735771
ci_job_id	779693917	779693917
ci_pipeline_id	53930910	53930910
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-fgow3nxt-project-304-concurrent-2-0iegp6z8 6.8.0-1018-aws #19~22.04.1-Ubuntu SMP Wed Oct 9 16:48:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-fgow3nxt-project-304-concurrent-2-0iegp6z8 6.8.0-1018-aws #19~22.04.1-Ubuntu SMP Wed Oct 9 16:48:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 1 performance improvements and 8 performance regressions! Performance is the same for 48 metrics, 6 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:startup:insecure-bank:iast:GlobalTracer	worse [+16.813ms; +22.083ms] or [+7.350%; +9.654%]	248.192ms	228.745ms
scenario:startup:insecure-bank:iast_HARDCODED_SECRET_DISABLED:GlobalTracer	worse [+15.262ms; +21.253ms] or [+6.650%; +9.261%]	247.754ms	229.497ms
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:GlobalTracer	worse [+15.211ms; +21.078ms] or [+6.635%; +9.194%]	247.397ms	229.252ms
scenario:startup:insecure-bank:tracing:GlobalTracer	worse [+11.518ms; +17.350ms] or [+4.798%; +7.227%]	254.502ms	240.068ms
scenario:startup:petclinic:appsec:GlobalTracer	worse [+12.536ms; +20.316ms] or [+5.249%; +8.507%]	255.236ms	238.811ms
scenario:startup:petclinic:appsec:AppSec	better [-7.001ms; -3.888ms] or [-3.945%; -2.191%]	172.009ms	177.453ms
scenario:startup:petclinic:iast:GlobalTracer	worse [+15.672ms; +23.510ms] or [+6.831%; +10.248%]	249.010ms	229.419ms
scenario:startup:petclinic:tracing:GlobalTracer	worse [+15.452ms; +16.873ms] or [+6.485%; +7.082%]	254.417ms	238.255ms
scenario:startup:petclinic:tracing:Remote Config	worse [+19.374µs; +39.436µs] or [+2.748%; +5.594%]	734.318µs	704.913µs

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~91f7384179, baseline=1.46.0-SNAPSHOT~77b93e2b13

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.034 s) : 0, 1034493
Total [baseline] (10.49 s) : 0, 10489567
Agent [candidate] (1.053 s) : 0, 1052587
Total [candidate] (10.477 s) : 0, 10476546
section appsec
Agent [baseline] (1.189 s) : 0, 1189394
Total [baseline] (10.799 s) : 0, 10798648
Agent [candidate] (1.197 s) : 0, 1197041
Total [candidate] (10.805 s) : 0, 10805286
section iast
Agent [baseline] (1.167 s) : 0, 1166739
Total [baseline] (10.964 s) : 0, 10964478
Agent [candidate] (1.198 s) : 0, 1198370
Total [candidate] (11.002 s) : 0, 11002200
section profiling
Agent [baseline] (1.25 s) : 0, 1250303
Total [baseline] (10.794 s) : 0, 10793649
Agent [candidate] (1.253 s) : 0, 1252607
Total [candidate] (10.95 s) : 0, 10949837

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.034 s	-
Agent	appsec	1.189 s	154.9 ms (15.0%)
Agent	iast	1.167 s	132.245 ms (12.8%)
Agent	profiling	1.25 s	215.81 ms (20.9%)
Total	tracing	10.49 s	-
Total	appsec	10.799 s	309.081 ms (2.9%)
Total	iast	10.964 s	474.911 ms (4.5%)
Total	profiling	10.794 s	304.082 ms (2.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.053 s	-
Agent	appsec	1.197 s	144.454 ms (13.7%)
Agent	iast	1.198 s	145.783 ms (13.9%)
Agent	profiling	1.253 s	200.02 ms (19.0%)
Total	tracing	10.477 s	-
Total	appsec	10.805 s	328.741 ms (3.1%)
Total	iast	11.002 s	525.654 ms (5.0%)
Total	profiling	10.95 s	473.291 ms (4.5%)

gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~91f7384179, baseline=1.46.0-SNAPSHOT~77b93e2b13

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (712.914 ms) : 0, 712914
BytebuddyAgent [candidate] (712.95 ms) : 0, 712950
GlobalTracer [baseline] (238.255 ms) : 0, 238255
GlobalTracer [candidate] (254.417 ms) : 0, 254417
AppSec [baseline] (55.529 ms) : 0, 55529
AppSec [candidate] (55.271 ms) : 0, 55271
Remote Config [baseline] (704.913 µs) : 0, 705
Remote Config [candidate] (734.318 µs) : 0, 734
Telemetry [baseline] (12.155 ms) : 0, 12155
Telemetry [candidate] (14.254 ms) : 0, 14254
section appsec
BytebuddyAgent [baseline] (739.226 ms) : 0, 739226
BytebuddyAgent [candidate] (735.991 ms) : 0, 735991
GlobalTracer [baseline] (238.811 ms) : 0, 238811
GlobalTracer [candidate] (255.236 ms) : 0, 255236
AppSec [baseline] (177.453 ms) : 0, 177453
AppSec [candidate] (172.009 ms) : 0, 172009
IAST [baseline] (19.68 ms) : 0, 19680
IAST [candidate] (19.637 ms) : 0, 19637
Remote Config [baseline] (668.555 µs) : 0, 669
Remote Config [candidate] (672.436 µs) : 0, 672
Telemetry [baseline] (8.345 ms) : 0, 8345
Telemetry [candidate] (8.244 ms) : 0, 8244
section iast
BytebuddyAgent [baseline] (833.675 ms) : 0, 833675
BytebuddyAgent [candidate] (843.642 ms) : 0, 843642
GlobalTracer [baseline] (229.419 ms) : 0, 229419
GlobalTracer [candidate] (249.01 ms) : 0, 249010
AppSec [baseline] (58.055 ms) : 0, 58055
AppSec [candidate] (58.8 ms) : 0, 58800
IAST [baseline] (21.256 ms) : 0, 21256
IAST [candidate] (22.127 ms) : 0, 22127
Remote Config [baseline] (661.58 µs) : 0, 662
Remote Config [candidate] (687.811 µs) : 0, 688
Telemetry [baseline] (8.731 ms) : 0, 8731
Telemetry [candidate] (8.891 ms) : 0, 8891
section profiling
BytebuddyAgent [baseline] (702.478 ms) : 0, 702478
BytebuddyAgent [candidate] (703.593 ms) : 0, 703593
GlobalTracer [baseline] (347.14 ms) : 0, 347140
GlobalTracer [candidate] (348.287 ms) : 0, 348287
AppSec [baseline] (54.559 ms) : 0, 54559
AppSec [candidate] (54.031 ms) : 0, 54031
Remote Config [baseline] (717.207 µs) : 0, 717
Remote Config [candidate] (712.358 µs) : 0, 712
Telemetry [baseline] (8.734 ms) : 0, 8734
Telemetry [candidate] (8.806 ms) : 0, 8806
ProfilingAgent [baseline] (94.861 ms) : 0, 94861
ProfilingAgent [candidate] (95.25 ms) : 0, 95250
Profiling [baseline] (94.885 ms) : 0, 94885
Profiling [candidate] (95.274 ms) : 0, 95274

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~91f7384179, baseline=1.46.0-SNAPSHOT~77b93e2b13

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047271
Total [baseline] (8.627 s) : 0, 8627068
Agent [candidate] (1.053 s) : 0, 1052694
Total [candidate] (8.607 s) : 0, 8606502
section iast
Agent [baseline] (1.163 s) : 0, 1163351
Total [baseline] (9.178 s) : 0, 9177889
Agent [candidate] (1.192 s) : 0, 1191616
Total [candidate] (9.229 s) : 0, 9229221
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.172 s) : 0, 1171560
Total [baseline] (9.156 s) : 0, 9156375
Agent [candidate] (1.191 s) : 0, 1191492
Total [candidate] (9.182 s) : 0, 9182145
section iast_TELEMETRY_OFF
Agent [baseline] (1.163 s) : 0, 1163197
Total [baseline] (9.2 s) : 0, 9200413
Agent [candidate] (1.192 s) : 0, 1192379
Total [candidate] (9.192 s) : 0, 9192031

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.047 s	-
Agent	iast	1.163 s	116.08 ms (11.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.172 s	124.29 ms (11.9%)
Agent	iast_TELEMETRY_OFF	1.163 s	115.926 ms (11.1%)
Total	tracing	8.627 s	-
Total	iast	9.178 s	550.821 ms (6.4%)
Total	iast_HARDCODED_SECRET_DISABLED	9.156 s	529.308 ms (6.1%)
Total	iast_TELEMETRY_OFF	9.2 s	573.345 ms (6.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.053 s	-
Agent	iast	1.192 s	138.922 ms (13.2%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.191 s	138.798 ms (13.2%)
Agent	iast_TELEMETRY_OFF	1.192 s	139.684 ms (13.3%)
Total	tracing	8.607 s	-
Total	iast	9.229 s	622.72 ms (7.2%)
Total	iast_HARDCODED_SECRET_DISABLED	9.182 s	575.643 ms (6.7%)
Total	iast_TELEMETRY_OFF	9.192 s	585.529 ms (6.8%)

gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~91f7384179, baseline=1.46.0-SNAPSHOT~77b93e2b13

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (724.328 ms) : 0, 724328
BytebuddyAgent [candidate] (712.252 ms) : 0, 712252
GlobalTracer [baseline] (240.068 ms) : 0, 240068
GlobalTracer [candidate] (254.502 ms) : 0, 254502
AppSec [baseline] (55.527 ms) : 0, 55527
AppSec [candidate] (55.39 ms) : 0, 55390
Remote Config [baseline] (717.731 µs) : 0, 718
Remote Config [candidate] (723.237 µs) : 0, 723
Telemetry [baseline] (11.407 ms) : 0, 11407
Telemetry [candidate] (14.832 ms) : 0, 14832
section iast
BytebuddyAgent [baseline] (830.875 ms) : 0, 830875
BytebuddyAgent [candidate] (838.386 ms) : 0, 838386
GlobalTracer [baseline] (228.745 ms) : 0, 228745
GlobalTracer [candidate] (248.192 ms) : 0, 248192
AppSec [baseline] (58.195 ms) : 0, 58195
AppSec [candidate] (58.443 ms) : 0, 58443
IAST [baseline] (21.23 ms) : 0, 21230
IAST [candidate] (21.932 ms) : 0, 21932
Remote Config [baseline] (643.129 µs) : 0, 643
Remote Config [candidate] (683.514 µs) : 0, 684
Telemetry [baseline] (8.676 ms) : 0, 8676
Telemetry [candidate] (8.948 ms) : 0, 8948
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (838.68 ms) : 0, 838680
BytebuddyAgent [candidate] (838.839 ms) : 0, 838839
GlobalTracer [baseline] (229.497 ms) : 0, 229497
GlobalTracer [candidate] (247.754 ms) : 0, 247754
AppSec [baseline] (57.717 ms) : 0, 57717
AppSec [candidate] (58.502 ms) : 0, 58502
IAST [baseline] (21.304 ms) : 0, 21304
IAST [candidate] (21.617 ms) : 0, 21617
Remote Config [baseline] (637.747 µs) : 0, 638
Remote Config [candidate] (690.676 µs) : 0, 691
Telemetry [baseline] (8.654 ms) : 0, 8654
Telemetry [candidate] (8.902 ms) : 0, 8902
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (830.506 ms) : 0, 830506
BytebuddyAgent [candidate] (840.74 ms) : 0, 840740
GlobalTracer [baseline] (229.252 ms) : 0, 229252
GlobalTracer [candidate] (247.397 ms) : 0, 247397
AppSec [baseline] (58.288 ms) : 0, 58288
AppSec [candidate] (58.371 ms) : 0, 58371
IAST [baseline] (20.818 ms) : 0, 20818
IAST [candidate] (21.238 ms) : 0, 21238
Remote Config [baseline] (655.431 µs) : 0, 655
Remote Config [candidate] (694.135 µs) : 0, 694
Telemetry [baseline] (8.71 ms) : 0, 8710
Telemetry [candidate] (8.758 ms) : 0, 8758

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-01-24T15:52:53	2025-01-24T15:59:59
git_branch	master	evanchooly/DEBUG-3368
git_commit_date	1737731098	1737733286
git_commit_sha	`77b93e2`	`91f7384`
release_version	1.46.0-SNAPSHOT~77b93e2b13	1.46.0-SNAPSHOT~91f7384179
start_time	2025-01-24T15:52:39	2025-01-24T15:59:45

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1737734757	1737734757
ci_job_id	779693918	779693918
ci_pipeline_id	53930910	53930910
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-exthqy6x-project-304-concurrent-1-myqb0uic 6.8.0-1018-aws #19~22.04.1-Ubuntu SMP Wed Oct 9 16:48:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-exthqy6x-project-304-concurrent-1-myqb0uic 6.8.0-1018-aws #19~22.04.1-Ubuntu SMP Wed Oct 9 16:48:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~91f7384179, baseline=1.46.0-SNAPSHOT~77b93e2b13
    dateFormat X
    axisFormat %s
section baseline
no_agent (382.865 µs) : 363, 403
.   : milestone, 383,
iast (508.023 µs) : 485, 531
.   : milestone, 508,
iast_FULL (742.591 µs) : 721, 764
.   : milestone, 743,
iast_GLOBAL (564.005 µs) : 539, 589
.   : milestone, 564,
iast_HARDCODED_SECRET_DISABLED (511.994 µs) : 489, 535
.   : milestone, 512,
iast_INACTIVE (458.785 µs) : 438, 480
.   : milestone, 459,
iast_TELEMETRY_OFF (502.673 µs) : 479, 526
.   : milestone, 503,
tracing (459.683 µs) : 438, 481
.   : milestone, 460,
section candidate
no_agent (387.449 µs) : 368, 407
.   : milestone, 387,
iast (512.934 µs) : 491, 535
.   : milestone, 513,
iast_FULL (740.6 µs) : 719, 762
.   : milestone, 741,
iast_GLOBAL (560.448 µs) : 539, 582
.   : milestone, 560,
iast_HARDCODED_SECRET_DISABLED (510.225 µs) : 488, 532
.   : milestone, 510,
iast_INACTIVE (462.297 µs) : 441, 484
.   : milestone, 462,
iast_TELEMETRY_OFF (497.183 µs) : 475, 519
.   : milestone, 497,
tracing (462.442 µs) : 441, 484
.   : milestone, 462,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	382.865 µs [362.957 µs, 402.772 µs]	-
iast	508.023 µs [485.219 µs, 530.826 µs]	125.158 µs (32.7%)
iast_FULL	742.591 µs [720.763 µs, 764.419 µs]	359.726 µs (94.0%)
iast_GLOBAL	564.005 µs [539.5 µs, 588.51 µs]	181.14 µs (47.3%)
iast_HARDCODED_SECRET_DISABLED	511.994 µs [489.362 µs, 534.627 µs]	129.13 µs (33.7%)
iast_INACTIVE	458.785 µs [437.616 µs, 479.954 µs]	75.921 µs (19.8%)
iast_TELEMETRY_OFF	502.673 µs [479.406 µs, 525.94 µs]	119.809 µs (31.3%)
tracing	459.683 µs [438.298 µs, 481.067 µs]	76.818 µs (20.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	387.449 µs [367.55 µs, 407.347 µs]	-
iast	512.934 µs [491.283 µs, 534.586 µs]	125.486 µs (32.4%)
iast_FULL	740.6 µs [718.712 µs, 762.488 µs]	353.151 µs (91.1%)
iast_GLOBAL	560.448 µs [538.932 µs, 581.964 µs]	173.0 µs (44.7%)
iast_HARDCODED_SECRET_DISABLED	510.225 µs [488.416 µs, 532.035 µs]	122.777 µs (31.7%)
iast_INACTIVE	462.297 µs [440.773 µs, 483.821 µs]	74.848 µs (19.3%)
iast_TELEMETRY_OFF	497.183 µs [475.264 µs, 519.101 µs]	109.734 µs (28.3%)
tracing	462.442 µs [440.939 µs, 483.944 µs]	74.993 µs (19.4%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~91f7384179, baseline=1.46.0-SNAPSHOT~77b93e2b13
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.381 ms) : 1361, 1401
.   : milestone, 1381,
appsec (1.765 ms) : 1741, 1789
.   : milestone, 1765,
appsec_no_iast (1.758 ms) : 1733, 1783
.   : milestone, 1758,
iast (1.529 ms) : 1505, 1554
.   : milestone, 1529,
profiling (1.515 ms) : 1492, 1539
.   : milestone, 1515,
tracing (1.507 ms) : 1483, 1531
.   : milestone, 1507,
section candidate
no_agent (1.369 ms) : 1349, 1388
.   : milestone, 1369,
appsec (1.756 ms) : 1732, 1780
.   : milestone, 1756,
appsec_no_iast (1.78 ms) : 1753, 1807
.   : milestone, 1780,
iast (1.488 ms) : 1463, 1512
.   : milestone, 1488,
profiling (1.503 ms) : 1480, 1526
.   : milestone, 1503,
tracing (1.483 ms) : 1458, 1508
.   : milestone, 1483,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.381 ms [1.361 ms, 1.401 ms]	-
appsec	1.765 ms [1.741 ms, 1.789 ms]	384.182 µs (27.8%)
appsec_no_iast	1.758 ms [1.733 ms, 1.783 ms]	376.83 µs (27.3%)
iast	1.529 ms [1.505 ms, 1.554 ms]	148.319 µs (10.7%)
profiling	1.515 ms [1.492 ms, 1.539 ms]	134.605 µs (9.7%)
tracing	1.507 ms [1.483 ms, 1.531 ms]	126.085 µs (9.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.369 ms [1.349 ms, 1.388 ms]	-
appsec	1.756 ms [1.732 ms, 1.78 ms]	387.357 µs (28.3%)
appsec_no_iast	1.78 ms [1.753 ms, 1.807 ms]	411.416 µs (30.1%)
iast	1.488 ms [1.463 ms, 1.512 ms]	119.196 µs (8.7%)
profiling	1.503 ms [1.48 ms, 1.526 ms]	134.655 µs (9.8%)
tracing	1.483 ms [1.458 ms, 1.508 ms]	114.371 µs (8.4%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	evanchooly/DEBUG-3368
git_commit_date	1737731098	1737733286
git_commit_sha	`77b93e2`	`91f7384`
release_version	1.46.0-SNAPSHOT~77b93e2b13	1.46.0-SNAPSHOT~91f7384179

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1737735296	1737735296
ci_job_id	779693919	779693919
ci_pipeline_id	53930910	53930910
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-fgow3nxt-project-304-concurrent-3-kx0etubh 6.8.0-1018-aws #19~22.04.1-Ubuntu SMP Wed Oct 9 16:48:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-fgow3nxt-project-304-concurrent-3-kx0etubh 6.8.0-1018-aws #19~22.04.1-Ubuntu SMP Wed Oct 9 16:48:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~91f7384179, baseline=1.46.0-SNAPSHOT~77b93e2b13
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.911 s) : 14911000, 14911000
.   : milestone, 14911000,
appsec (14.951 s) : 14951000, 14951000
.   : milestone, 14951000,
iast (19.016 s) : 19016000, 19016000
.   : milestone, 19016000,
iast_GLOBAL (18.271 s) : 18271000, 18271000
.   : milestone, 18271000,
profiling (15.126 s) : 15126000, 15126000
.   : milestone, 15126000,
tracing (15.01 s) : 15010000, 15010000
.   : milestone, 15010000,
section candidate
no_agent (15.071 s) : 15071000, 15071000
.   : milestone, 15071000,
appsec (15.284 s) : 15284000, 15284000
.   : milestone, 15284000,
iast (18.914 s) : 18914000, 18914000
.   : milestone, 18914000,
iast_GLOBAL (18.163 s) : 18163000, 18163000
.   : milestone, 18163000,
profiling (15.031 s) : 15031000, 15031000
.   : milestone, 15031000,
tracing (15.082 s) : 15082000, 15082000
.   : milestone, 15082000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.911 s [14.911 s, 14.911 s]	-
appsec	14.951 s [14.951 s, 14.951 s]	40.0 ms (0.3%)
iast	19.016 s [19.016 s, 19.016 s]	4.105 s (27.5%)
iast_GLOBAL	18.271 s [18.271 s, 18.271 s]	3.36 s (22.5%)
profiling	15.126 s [15.126 s, 15.126 s]	215.0 ms (1.4%)
tracing	15.01 s [15.01 s, 15.01 s]	99.0 ms (0.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.071 s [15.071 s, 15.071 s]	-
appsec	15.284 s [15.284 s, 15.284 s]	213.0 ms (1.4%)
iast	18.914 s [18.914 s, 18.914 s]	3.843 s (25.5%)
iast_GLOBAL	18.163 s [18.163 s, 18.163 s]	3.092 s (20.5%)
profiling	15.031 s [15.031 s, 15.031 s]	-40.0 ms (-0.3%)
tracing	15.082 s [15.082 s, 15.082 s]	11.0 ms (0.1%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~91f7384179, baseline=1.46.0-SNAPSHOT~77b93e2b13
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1478
.   : milestone, 1467,
appsec (2.376 ms) : 2332, 2419
.   : milestone, 2376,
iast (2.105 ms) : 2050, 2159
.   : milestone, 2105,
iast_GLOBAL (2.148 ms) : 2094, 2203
.   : milestone, 2148,
profiling (1.974 ms) : 1930, 2018
.   : milestone, 1974,
tracing (1.944 ms) : 1902, 1986
.   : milestone, 1944,
section candidate
no_agent (1.471 ms) : 1460, 1483
.   : milestone, 1471,
appsec (2.36 ms) : 2317, 2403
.   : milestone, 2360,
iast (2.112 ms) : 2057, 2166
.   : milestone, 2112,
iast_GLOBAL (2.157 ms) : 2102, 2212
.   : milestone, 2157,
profiling (1.961 ms) : 1918, 2005
.   : milestone, 1961,
tracing (1.95 ms) : 1907, 1993
.   : milestone, 1950,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.467 ms [1.456 ms, 1.478 ms]	-
appsec	2.376 ms [2.332 ms, 2.419 ms]	908.674 µs (61.9%)
iast	2.105 ms [2.05 ms, 2.159 ms]	637.643 µs (43.5%)
iast_GLOBAL	2.148 ms [2.094 ms, 2.203 ms]	681.496 µs (46.5%)
profiling	1.974 ms [1.93 ms, 2.018 ms]	507.187 µs (34.6%)
tracing	1.944 ms [1.902 ms, 1.986 ms]	477.243 µs (32.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.471 ms [1.46 ms, 1.483 ms]	-
appsec	2.36 ms [2.317 ms, 2.403 ms]	888.278 µs (60.4%)
iast	2.112 ms [2.057 ms, 2.166 ms]	640.48 µs (43.5%)
iast_GLOBAL	2.157 ms [2.102 ms, 2.212 ms]	685.537 µs (46.6%)
profiling	1.961 ms [1.918 ms, 2.005 ms]	490.133 µs (33.3%)
tracing	1.95 ms [1.907 ms, 1.993 ms]	478.541 µs (32.5%)

evanchooly · 2025-01-23T21:24:48Z

LGTM I would add a test for the weak ref just to make sure we are not leaking it. Like in

dd-trace-java/dd-java-agent/agent-debugger/src/test/java/com/datadog/debugger/exception/DefaultExceptionDebuggerTest.java

Line 154 in 0ab8864

System.gc();

I actually thought about it but traditionally we've (as in, java people) been telling people not to bother with System.gc() because it doesn't really do much beyond nudge the GC and may not actually result in anything happening. Can it be used here?

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/probe/LogProbe.java

shatzi

i assume there is a future PR to report the budget on the root-entry span by access the same budget object?

I assume that would cause this to be refactored and to have a synced hashmap for all traces to share?

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/probe/LogProbe.java

shatzi

LGTM

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.25.4` -> `2.26.0` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | --- ### Release Notes <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.26.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2260-2025-01-29) ##### Features - Add firestoreInDatastoreMode for datastore emulator ([#1698](googleapis/java-datastore#1698)) ([50f106d](googleapis/java-datastore@50f106d)) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.42.0 ([#1725](googleapis/java-datastore#1725)) ([1cbaf22](googleapis/java-datastore@1cbaf22)) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.46.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.46.0): 1.46.0 ##### Breaking Changes > \[!WARNING] > jnr-unixsocket is now an external dependency of dd-trace-ot and must be included when deploying dd-trace-ot. > \[!NOTE] > The API `TracerScope.setAsync(boolean)`, used to manually control asynchronous span propagation, does no more apply to the scope instance but to the active span scope. ##### Components ##### Application Security Management (IAST) - 🐛 Fix String.replace instrumentation for IAST ([#8281](DataDog/dd-trace-java#8281) - [@Mariovido](https://github.com/Mariovido)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#8244](DataDog/dd-trace-java#8244) - [@jandro996](https://github.com/jandro996)) - 🐛 Exclude false positive weak randomness ([#8232](DataDog/dd-trace-java#8232) - [@jandro996](https://github.com/jandro996)) - ✨ Propagation of translateEscapes of String class ([#8186](DataDog/dd-trace-java#8186) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Add security control metrics ([#8175](DataDog/dd-trace-java#8175) - [@jandro996](https://github.com/jandro996)) - ✨ Increase IAST propagation to StringBuffer setLength ([#8128](DataDog/dd-trace-java#8128) - [@Mariovido](https://github.com/Mariovido)) - ✨ Add IAST taint tracking for DB values ([#8072](DataDog/dd-trace-java#8072) - [@Mariovido](https://github.com/Mariovido)) ##### Application Security Management (WAF) - 🐛 Prevents a NPE when there is no subscriber for user events ([#8258](DataDog/dd-trace-java#8258) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#8244](DataDog/dd-trace-java#8244) - [@jandro996](https://github.com/jandro996)) - 🐛 Ensure cached subscriptions are cleared on reconfiguration via RC ([#8229](DataDog/dd-trace-java#8229) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Add support for session tracking in Vertx ([#8167](DataDog/dd-trace-java#8167) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Create span tag: \_dd.appsec.rasp.timeout ([#8269](DataDog/dd-trace-java#8269) - [@Mariovido](https://github.com/Mariovido)) ##### Build & Tooling - 🐛 Ensure shaded helpers have unique names when injected into class-loaders ([#8192](DataDog/dd-trace-java#8192) - [@mcculls](https://github.com/mcculls)) ##### Configuration at Runtime - 🐛 Remove filtering of `DD_SERVICE` and `DD_ENV` from the tracer ([#8176](DataDog/dd-trace-java#8176) - [@mhlidd](https://github.com/mhlidd)) ##### Continuous Integration Visibility - 🧹 Generalize TestRetryPolicy to TestExecutionPolicy ([#8302](DataDog/dd-trace-java#8302) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Parallelize CI Visibility settings requests ([#8299](DataDog/dd-trace-java#8299) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize test retry logic ([#8289](DataDog/dd-trace-java#8289) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize tests skipping logic ([#8288](DataDog/dd-trace-java#8288) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Remove skip and shouldBeSkipped methods from TestEventsHandler in favor of isSkippable ([#8286](DataDog/dd-trace-java#8286) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨⚡ Optimize Git repository information computation ([#8270](DataDog/dd-trace-java#8270) - [@dougqh](https://github.com/dougqh)) - ✨ Always request known tests from the backend ([#8268](DataDog/dd-trace-java#8268) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Fix NPE when trying to get retry analyzer in Test NG ([#8253](DataDog/dd-trace-java#8253) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Set test framework and test framework version tags atomically ([#8252](DataDog/dd-trace-java#8252) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add debug logging to Android Gradle module layout logic ([#8251](DataDog/dd-trace-java#8251) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix source and destination folders computation for Android Gradle projects ([#8190](DataDog/dd-trace-java#8190) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add basic Scala Weaver sbt support ([#8189](DataDog/dd-trace-java#8189) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement impacted tests detection ([#8188](DataDog/dd-trace-java#8188) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ##### Data Streams Monitoring - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#8201](DataDog/dd-trace-java#8201) - [@vandonr](https://github.com/vandonr)) ##### Database Monitoring - Add peer service tag in dbm sql commenter ([#7913](DataDog/dd-trace-java#7913) - [@jordan-wong](https://github.com/jordan-wong)) ##### Dynamic Instrumentation - ✨ Add support for SymDB to scan directories ([#8306](DataDog/dd-trace-java#8306) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add SymDB report for any jar scanning failures ([#8300](DataDog/dd-trace-java#8300) - [@jpbempel](https://github.com/jpbempel)) - ✨ Use two budgets depending on type ([#8283](DataDog/dd-trace-java#8283) - [@evanchooly](https://github.com/evanchooly)) - ✨ Institute a 10 snapshot per probe per trace budget ([#8277](DataDog/dd-trace-java#8277) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Avoid double snapshots for Exception Replay ([#8273](DataDog/dd-trace-java#8273) - [@jpbempel](https://github.com/jpbempel)) - ✨ Simplify code origins. Separate out snapshot generation. ([#8263](DataDog/dd-trace-java#8263) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add Exception probe custom instrumentation ([#8230](DataDog/dd-trace-java#8230) - [@jpbempel](https://github.com/jpbempel)) - ✨ Enhance log probes to honor debug session tags ([#8215](DataDog/dd-trace-java#8215) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Don't redact env tokens from debugger probe snapshots ([#8211](DataDog/dd-trace-java#8211) - [@watson](https://github.com/watson)) - ✨⚡ Move Trace/SpanId capture at commit time ([#8184](DataDog/dd-trace-java#8184) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Capture values at entry for method probe ([#8169](DataDog/dd-trace-java#8169) - [@jpbempel](https://github.com/jpbempel)) ##### JMX fetch - 🐛 Mute JMXFetch Shutdown in progress error ([#8068](DataDog/dd-trace-java#8068) - [@ygree](https://github.com/ygree)) ##### OpenTracing - ⚠️🧹 Make jnr-unixsocket an explicit dependency of dd-trace-ot ([#8307](DataDog/dd-trace-java#8307) - [@mcculls](https://github.com/mcculls)) ##### Profiling - 🐛 Avoid unsupported API call for creating folders on windows ([#8304](DataDog/dd-trace-java#8304) - [@jbachorik](https://github.com/jbachorik)) - ✨ Tag profiles for serverless ([#8279](DataDog/dd-trace-java#8279) - [@jbachorik](https://github.com/jbachorik)) - ✨ add queue type and length to queue events ([#8242](DataDog/dd-trace-java#8242) - [@richardstartin](https://github.com/richardstartin)) - 🐛 TempLocationManager Fixes and Improvements ([#8191](DataDog/dd-trace-java#8191) - [@jbachorik](https://github.com/jbachorik)) - ✨ Bump ddprof to 1.18.0 ([#8173](DataDog/dd-trace-java#8173) - [@jbachorik](https://github.com/jbachorik)) - ✨ Report profiler initialization and configuration errors to telemetry ([#8171](DataDog/dd-trace-java#8171) - [@jbachorik](https://github.com/jbachorik)) ##### Telemetry - ✨ Add pending traces report in tracer flares ([#8053](DataDog/dd-trace-java#8053) - [@mhlidd](https://github.com/mhlidd)) ##### Testing - ✨ Test http server requests in parallel ([#8222](DataDog/dd-trace-java#8222) - [@amarziali](https://github.com/amarziali)) ##### Trace context propagation - ✨ Add non default propagator registration ([#8310](DataDog/dd-trace-java#8310) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - ✨ Probe for existence of IBMSASL or ACCP security providers ([#8276](DataDog/dd-trace-java#8276) - [@mcculls](https://github.com/mcculls)) - ✨⚡ Overhead improvement to agent feedback based sampling ([#8265](DataDog/dd-trace-java#8265) - [@dougqh](https://github.com/dougqh)) - 🧹 Move async propagation API from scope to tracer ([#8231](DataDog/dd-trace-java#8231) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Introduce context propagation API ([#8161](DataDog/dd-trace-java#8161) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨🧪 Use env-entry to add tags per webapp deployment ([#8138](DataDog/dd-trace-java#8138) - [@amarziali](https://github.com/amarziali)) - ✨ Introduce context helpers API ([#8134](DataDog/dd-trace-java#8134) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Support IPv6 values for `DD_AGENT_HOST` and `DD_TRACE_AGENT_URL` ([#7984](DataDog/dd-trace-java#7984) - [@mhlidd](https://github.com/mhlidd)) ##### Instrumentations ##### Apache HttpComponents - 🐛 Properly finish spans and support latest apache httpclient5 ([#8272](DataDog/dd-trace-java#8272) - [@amarziali](https://github.com/amarziali)) ##### AWS Lambda instrumentation - 🐛 Properly capture lambda payloads for all handler types. ([#8264](DataDog/dd-trace-java#8264) - [@purple4reina](https://github.com/purple4reina)) ##### AWS S3 instrumentation - 💡 Create S3 instrumentation + add span pointers ([#8075](DataDog/dd-trace-java#8075) - [@nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Revert "Add avoid double instrumenting lambda non-streaming handlers." ([#8247](DataDog/dd-trace-java#8247) - [@nhulston](https://github.com/nhulston)) ##### Cassandra - ✨ Allow extracting keyspace from statement result ([#8239](DataDog/dd-trace-java#8239) - [@amarziali](https://github.com/amarziali)) ##### Core Java language instrumentation - ✨ Propagation of translateEscapes of String class ([#8186](DataDog/dd-trace-java#8186) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Eclipse Vert.x instrumentation - 🐛 Fix vertx worker propagation and error handling ([#8237](DataDog/dd-trace-java#8237) - [@amarziali](https://github.com/amarziali)) - ✨ Support vertx 5 ([#8220](DataDog/dd-trace-java#8220) - [@amarziali](https://github.com/amarziali)) - ✨ Add support for session tracking in Vertx ([#8167](DataDog/dd-trace-java#8167) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) ##### Kafka instrumentation - 🐛 Prevent possible NPE calculating Kafka record header size ([#8292](DataDog/dd-trace-java#8292) - [@ygree](https://github.com/ygree)) ##### Mule instrumentation - 🐛 Fix crash using Mule with JPMS ([#8187](DataDog/dd-trace-java#8187) - [@amarziali](https://github.com/amarziali)) ##### Protocol Buffer instrumentation - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#8201](DataDog/dd-trace-java#8201) - [@vandonr](https://github.com/vandonr)) ##### Spring instrumentation - 🐛 Preserve getQualifier from spring scheduling runnables ([#8293](DataDog/dd-trace-java#8293) - [@amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: bb09d47e4eed77a003f630273b4d0a84003eb899

institute a 10 snapshot per probe per trace budget

ce49eb9

evanchooly added type: enhancement Enhancements and improvements comp: debugger Dynamic Instrumentation labels Jan 23, 2025

evanchooly requested review from jpbempel and shatzi January 23, 2025 20:42

evanchooly requested a review from a team as a code owner January 23, 2025 20:42

evanchooly enabled auto-merge (squash) January 23, 2025 20:42

jpbempel approved these changes Jan 23, 2025

View reviewed changes

evanchooly disabled auto-merge January 23, 2025 21:34

fix NPE in other tests

ec59f6f

evanchooly enabled auto-merge (squash) January 23, 2025 22:45

jpbempel reviewed Jan 24, 2025

View reviewed changes

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/probe/LogProbe.java Show resolved Hide resolved

shatzi approved these changes Jan 24, 2025

View reviewed changes

jpbempel reviewed Jan 24, 2025

View reviewed changes

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/probe/LogProbe.java Outdated Show resolved Hide resolved

evanchooly added 2 commits January 24, 2025 10:21

make budgets apply only to debug sessions

b6c805e

return null if there's no debug session ID instead

91f7384

evanchooly requested review from jpbempel and shatzi January 24, 2025 16:12

evanchooly disabled auto-merge January 24, 2025 16:12

evanchooly added type: enhancement Enhancements and improvements and removed type: enhancement Enhancements and improvements labels Jan 24, 2025

shatzi approved these changes Jan 24, 2025

View reviewed changes

evanchooly merged commit 71309b3 into master Jan 24, 2025
178 of 179 checks passed

evanchooly deleted the evanchooly/DEBUG-3368 branch January 24, 2025 17:57

github-actions bot added this to the 1.46.0 milestone Jan 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Institute a 10 snapshot per probe per trace budget#8277

Institute a 10 snapshot per probe per trace budget#8277
evanchooly merged 4 commits intomasterfrom
evanchooly/DEBUG-3368

evanchooly commented Jan 23, 2025 •

edited by atlassian bot

Loading

Uh oh!

pr-commenter bot commented Jan 23, 2025 •

edited

Loading

Uh oh!

jpbempel left a comment

Uh oh!

pr-commenter bot commented Jan 23, 2025 •

edited

Loading

Uh oh!

evanchooly commented Jan 23, 2025

Uh oh!

Uh oh!

shatzi left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shatzi left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

evanchooly commented Jan 23, 2025 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenter bot commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Debugger benchmarks

Parameters

Summary

Uh oh!

jpbempel left a comment

Choose a reason for hiding this comment

Uh oh!

pr-commenter bot commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

evanchooly commented Jan 23, 2025

Uh oh!

Uh oh!

shatzi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shatzi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

evanchooly commented Jan 23, 2025 •

edited by atlassian bot

Loading

pr-commenter bot commented Jan 23, 2025 •

edited

Loading

pr-commenter bot commented Jan 23, 2025 •

edited

Loading