This repository was archived by the owner on Nov 11, 2022. It is now read-only.
Generalize type signature of KV.of#3
Merged
davorbonaci merged 1 commit intoGoogleCloudPlatform:masterfrom Jan 12, 2015
kwestbrooks:master
Merged
Generalize type signature of KV.of#3davorbonaci merged 1 commit intoGoogleCloudPlatform:masterfrom kwestbrooks:master
davorbonaci merged 1 commit intoGoogleCloudPlatform:masterfrom
kwestbrooks:master
Conversation
davorbonaci
added a commit
that referenced
this pull request
Jan 12, 2015
Generalize type signature of KV.of().
Contributor
|
Thanks for the contribution. Looks like an improvement. Merged. |
Contributor
|
This pull request was reverted due to a number of non-trivial build breaks. We may reconsider this in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found myself having to write this:
KV<String, Iterable<String>> kv = KV.<String, Iterable<String>>of("foo", new ArrayList<String>());
When I would have preferred to write this:
KV<String, Iterable<String>> kv = KV.of("foo", new ArrayList<String>());
What do you think about this change?