Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

chore(endpoints): remove old region tag secrets-1#13006

Merged
iennae merged 1 commit intoGoogleCloudPlatform:mainfrom
alarconesparza:alarconesparza-chore-remove-old-region-tag-347825630
Dec 19, 2024
Merged

chore(endpoints): remove old region tag secrets-1#13006
iennae merged 1 commit intoGoogleCloudPlatform:mainfrom
alarconesparza:alarconesparza-chore-remove-old-region-tag-347825630

Conversation

@alarconesparza
Copy link
Contributor

@alarconesparza alarconesparza commented Dec 18, 2024

Description

Internal b/347825630

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will have a full review ready in a few minutes. In the meantime, here's a quick summary to get everyone up to speed:

This pull request removes an outdated region tag (secrets-1) from the k8s-grpc-bookstore.yaml file within the endpoints/kubernetes directory. The change specifically removes lines 46-51 from the file, streamlining the Kubernetes deployment configuration. The intent, as I understand it from the PR title and description, is to clean up and simplify the sample configuration, removing unnecessary or obsolete elements. The change appears to be a straightforward removal of commented-out code, which should not impact functionality.

If I've missed anything crucial, please let me know. I'll provide a more detailed review shortly.


And now, a little haiku to brighten your day:

Old code, now removed,
Clean lines, a simpler sight,
Code's beauty revealed.

@product-auto-label product-auto-label bot added api: endpoints Issues related to the Cloud Endpoints API. samples Issues that are directly related to samples. labels Dec 18, 2024
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request removes an unused region tag. The change is small and straightforward. It's good to see the checklist items filled out.

@alarconesparza alarconesparza marked this pull request as ready for review December 19, 2024 17:15
@alarconesparza alarconesparza requested review from a team as code owners December 19, 2024 17:15
@snippet-bot
Copy link

snippet-bot bot commented Dec 19, 2024

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@iennae iennae merged commit e789679 into GoogleCloudPlatform:main Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: endpoints Issues related to the Cloud Endpoints API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants